[tcpm] CWND increase in disordered state in Linux?

Ingemar Johansson S <ingemar.s.johansson@ericsson.com> Tue, 03 September 2024 09:47 UTC

Return-Path: <ingemar.s.johansson@ericsson.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9F7BCC151066 for <tcpm@ietfa.amsl.com>; Tue, 3 Sep 2024 02:47:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.256
X-Spam-Level:
X-Spam-Status: No, score=-7.256 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.148, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kPH7GWQT3_ON for <tcpm@ietfa.amsl.com>; Tue, 3 Sep 2024 02:47:49 -0700 (PDT)
Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2048.outbound.protection.outlook.com [40.107.105.48]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 802A4C151062 for <tcpm@ietf.org>; Tue, 3 Sep 2024 02:47:49 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c5r4exktME0RYQizJ6SR1T5UTrd3fzprIS7KvE6hKg6XIb3iYKGaKw2fvPttpLXAXtanZcW+87yPdZAIbwOqPihS1hw6UrrgjOtcT8EDPGiLrsK1sW9qryuSOpxUGMZ4xp6f9Z9x6TUJ2412ZrUW2ihvYEiGDyZ/Z00EdxVaG69C1gq24RKfblPp8989gjii7nlMKQzyfsN4zatIItQsE///AktrQcZRZ+pjOmUemN/DStp9QPux1dpsZ9478PF54AFlQaq+tDRCrhv6Pz49wB3vu9p0IuIHiwGCLhXd9ku39sD1kvyuKa2ddaZDQtiDsATSOOOMIuaQa/C0B18+KA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gtdnkCi/U4OJAsXddvyvJodYCsfpQAMSqkOhqISttjI=; b=jWFKYGOq/rU1haoSoXwWcDvaBIEHS432QK5vSXKdSLp6oFqIpw//FrCUYQx6T7VZwYI7tYwMv2wjtAKOhQknL4w0jZSsEuT1u+ucaAARRoRGxXiFzbkmzaCmUHsPJwb5QtGPqJGqQB/+1t8GMPZCzbXyggqfmjqrIMLn/HMdyNuqeBMtYxfSv/EeCWhgYfUq83IGpdE44dEzodNCosLey1xkB2z4Xngv/XxcbcdNONfqQWcWDUNJgbRgMvvPXUMZbWovvrcNi1rJL5CdAe17DZ2nUh9Oa+W+vvgbKdUs/vlGisIiLc9E0t4/rhoFn1JfyG7oPvmzHFUS0EqTE/Je+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gtdnkCi/U4OJAsXddvyvJodYCsfpQAMSqkOhqISttjI=; b=Jm/hEAXo0d4B9chorAE5Pa7dVf7QlnTJpMXDwm0lTpOc7hmTn9iKNdaH7t1r1ohUxnRxJfwP3m678eEW9/bgooV204zQPYB5FxJaFngYjGslkQpZ4SZd8g5iRRd9mr4N6VeZY0mCZ8stftyTaeWxMf00uDE6zOldbqqgonJM0y5GsWkfCMepcCC3DtgjqT3mzP0Em/r3hTebw2XhEogdSxcOmQ2JoN6gNIj6ZKV13lqorkG4jraZpSruHOZK3BxqqcY/px5rcuR03fV/EIpuE7DjJ1SEAO8kSCjbgNC8ydhbD3ocJmXZZM83t2lHS1u6up2u5eqa7tfE/K41mErlsQ==
Received: from AM8PR07MB8137.eurprd07.prod.outlook.com (2603:10a6:20b:36c::18) by VI1PR0701MB6974.eurprd07.prod.outlook.com (2603:10a6:800:17f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.24; Tue, 3 Sep 2024 09:47:46 +0000
Received: from AM8PR07MB8137.eurprd07.prod.outlook.com ([fe80::9e03:ac31:a53:8b04]) by AM8PR07MB8137.eurprd07.prod.outlook.com ([fe80::9e03:ac31:a53:8b04%4]) with mapi id 15.20.7918.024; Tue, 3 Sep 2024 09:47:46 +0000
From: Ingemar Johansson S <ingemar.s.johansson@ericsson.com>
To: Neal Cardwell <ncardwell@google.com>
Thread-Topic: CWND increase in disordered state in Linux?
Thread-Index: Adr95iSQMFrOQBHATa+k9g+RIMSCqg==
Date: Tue, 03 Sep 2024 09:47:45 +0000
Message-ID: <AM8PR07MB81375A216023B9AC11EA6F3DC2932@AM8PR07MB8137.eurprd07.prod.outlook.com>
Accept-Language: sv-SE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ericsson.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: AM8PR07MB8137:EE_|VI1PR0701MB6974:EE_
x-ms-office365-filtering-correlation-id: 4573f2dc-acce-412f-7f15-08dccbfd76ce
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;ARA:13230040|366016|1800799024|376014|38070700018;
x-microsoft-antispam-message-info: hLKyB6K/S2fx6bkhvmnz4dIlqd4LH5omWAM5a9xksTH5fuHl9vakn/asHOt5jLwACx9cABKsJNi+DHYz8lxDfG+AE8SYXs62ZasGtPYVpdNjW9OGQm1SzDtbYhKEWzpAVhNlLHDrbm+sN9+ygW9RbDAt617LT61cy2IXvUi8PZtLOsKKjbQBiuk7xw00d56J/PAGF4VZS2T9N4qsX07XQFmqW7EyOSGM+AAecSpH37wAZ+AMTNjZ6TCylPg5ZKJcQDYl8RUp6MAf4Yb9JRQKylGIxvZMd2YI4P2a4nKZmjEtSqpT9J7d3VMvEO+4wp0ZlQ5jUczF5coHL9sVJosJzAlWTh114CTGGp1cLsWDTfULDkk2gj7DQa3fL5+3Qhv+I0q8VCB4SJ5R3mhH1qqJf6KDrM1D0BRiqSjjILQ5Lhp0Y4+wyIUBasw/qdmDcqL5Q8HYFLzi8CRTcmbon0lEN7Bmve67vDNWMFIJeAVb+OQhDALLOy3B5TLmOQD+A4FyiNMML23i0XfiH40Vlzfr7lv09t7PofDRJy1XsCQFzR6kMGfjFKV9MAQr2WHt1VGS4E+BvciSJMn7dOAtnaG8iFMA5Z2FZNGmIUpK2WGiPuqLYByyxh12kJ4v6eGebbw9MyZ4Im1LNBMICSAQfTLrJGSh3yp5EOjr3LCnY5dijrAOnlRSQtGBDhZOfJbtvXAUpL69PqXYVKbpCTfZhIWageVnSygIBZj7UnjLGdxHWc05dEiY2YEG0oQTCvdjaoF6IOTZ4KX8vwbRmLClMsXhGnEDY1S4KvOFAXkya8fITL8tUwpU4GrJ5xRXX+Ehl+PCxf+ko8/Jt5x/5d/qao9sh4Y+rX3MrcVD6eYArPpE4tFHFw1y6q8mgUElAPh0C67GXoDahGl8sOQCFaUNXg47FNAJBHQAsl+HPAdvrqh9ZgmUYSDQHDJe3sW29XkdhTlrE3wU6Zyk5/5h8HLBGkWSuw5FonXQO3dRhTnWKEvSVoMhAa9jHe4FlSF/3xd3jZDAqeKIVzaU8aETDmK1E5IShnKfcqSK7GLmSe5a0dOcp5PtLbeZsuDYFoxyDdXc0Cyveqy7IcNzgXlxiVXY0cS1ZrWayRSJLItKQ8aom+ARUHDEVWIiPkfrgu3LPCVYodyu/BIVKnR6+9f2vSQzkuTAJoO0KlwVUbseLjTJSKzc92UV0D1nh9Su40j9fOgQY0yflIAtMpK8NcshlIto4RKncqeBi2TFnPOatvGzCAXqkxcDIbo7h8fshjMytUNh2PgITBFqkXbNM3zbrwHKg7eUhHW8/GRKr24YX2RiO26RdkYlDvWVwCRtY1HzXPVm0hXDh/yihjfzrWIqQJimZrE38RhdHKugsxmxRB86yWXbE+X+nar12hEchx616QExxzXLtJ23/vpRpffnAOfLR1zReg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM8PR07MB8137.eurprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(38070700018);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 9kypMJoo6D7otfsTC/5VySo/r+WhrYhcpnQOn9dArNEg/rwiP87x0EzFSUQh1igg3Sr0/wJYLd2udlDXlykBzxCNV3RmRWz34vUBHlaxkEIcKkTIjnosmjsXuX6d4CEHPd4qzhu/8VZIzWpg3FmbJ2b1+LxNaFGAmIKe9Zq8NTdciVXIWPPlmkNBFosgDiT2hkSElpDB59+xqoOI8BhmmU5o0GPA0/H3ljmftB13FXU8vn1Squai+xnXpjI7/vB9cwGdOhZ36AYRklSKVjDN1fYmjJ3Ik9DaiKcw9Z/CPZMlqUc1V/Qdo6iQf9zodnhueQeNqJLdQUbJPpzFat7cG4Xd61AW1bqAfetHF3BkmEn6/6t20GTcgZjyXDFhXhOtZudkqwATYbhlD8tNAWAC+Y/HGucItVn6LAXTC8Zqglms+8kAELjvcMhKnsUZnAxU3T6crFfXQSQJaJrn/E9saRF3jkkFbuIwfqaCbL6YazqvOPMeJ38uO8vScmUC4m/FyHYt8dQtA5WrbBWehQotr/AxU1ssRaxi7TAXJWeWUxMX8vwCsx/2vsn7HLdHjXoNWtj+ObsBhoavcmi+QiGwSCc9iPxlOO9/nLS4L9RmNgcsbZ6MQgKI+v6uKEjXNP/zj+mYGIibXzDF6o2TqsGcWmvjTOjik0/DBhIuv1JqShZ3C9XZi/6ccz4xhfwWxS91VB3dNBf8LF/WxV4zzIpbSo/sRz5nwjJRdvnd0jSCTEyMOelYMKrEwcp7WNQho1jGPOYusN4JYRYIRRbOvxWHDae3nT8wpnoGHrEMqHVpSZl9kgyzyDHrQtKK0rptGEeZGdh9ZZae7KXLf6wWtBKU/2xCgTefZbMA3kFvAsXZzFU4ITbmWePm5/+Az5hLQTHYOuySNBgHIFeJqIhVcREB95IgEWEFF6c80yVm0UzGGRHeABfdaIj/opd2IelXITstZEVC6011J1rHDDE86BiRWIF9qxfyZaIE3Ni11MXRpeIkjBYT2S+f+r8yuBPIwkP/H9ul6TKH9UXZ9LNdBRt11aZJHjAZA08e0qOs2e59BEe4zfqJHHHvLK86DBkq7bOYOa58Z4vVsLf8OWoSMQ3ESRXnstK5vFxIKjLl4G58iJBhMqCCdI509dovR74++vHm8NuOHHqhFZg6rMIb3vToCKeNFImXWgzpUqx1vkvVsExktKi6qgPmmxk+3aUStLgW8e9HG4F/iVS4Bm4/+OY9XmxeYMJhAcHNPJzQEmUvL1V/6acpyJJ/apyxaNcinYxEZYxemuYHHL7aYqijh276DslXmMlNwme1UyuADMXE4IS/xxne9sbtrgRuaGxNB9xQfrwIsNhXJy5IzeTJKu28tKNJydHtKo4iuBhk04vQmMnwWeTC0XbtqA/Q9ZyjzUYulew9FEm5QZk0sEIWglkCJx/KfUhiTcAhcFkeP2QCOljaSuMtLgu0EUZOUXW+sRLoO4SF6xRaNjJYBZgolxr9WZ0I20oJuRTDdud+YlHJ7vyV6MzEL3+iULV3n1QVzIviBr5VGzXAU3I2LCanQuWFjAmmW0hgBLr2fZNRLzVwX3WHumxj/AS7JnJnQ3qA+V1x/ml862e+8AnZxuUEEKyOzA==
Content-Type: multipart/alternative; boundary="_000_AM8PR07MB81375A216023B9AC11EA6F3DC2932AM8PR07MB8137eurp_"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB8137.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4573f2dc-acce-412f-7f15-08dccbfd76ce
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Sep 2024 09:47:46.0024 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E76Iym/EmzTYHLT0+FkNVakdApWWfFqEHxcA/PCd7tqIv9p2iwoKydyKfDfpOHXGy/nM6VxD1v5BsVS7s8PbizrcoNY/CrppodUqQVqVmzblOxyYmabBcVNjsj/5q2tc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0701MB6974
Message-ID-Hash: Z4UYTBGN4LCYMSDVANHIBZE3H2QE7DVC
X-Message-ID-Hash: Z4UYTBGN4LCYMSDVANHIBZE3H2QE7DVC
X-MailFrom: ingemar.s.johansson@ericsson.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-tcpm.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "tcpm@ietf.org" <tcpm@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [tcpm] CWND increase in disordered state in Linux?
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/3NhWpvX5PwqH4zGsUYcpiPctYQE>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Owner: <mailto:tcpm-owner@ietf.org>
List-Post: <mailto:tcpm@ietf.org>
List-Subscribe: <mailto:tcpm-join@ietf.org>
List-Unsubscribe: <mailto:tcpm-leave@ietf.org>

Hi
Hope you are fine

I am working on improving the TCP stack in our 5G system simulator to pass all relevant packetdrill tests.
One thing that I I try to figure out is the behavior in CA_Disordered state. One such example is the prr-ss-10pkt-lost-1.pkt test.
What I see in the current implementation is that cwnd increases from 10 to 12 when it is in disordered state.
When it gets into CA_Recovery however the ssthresh should be set to 7 but it is set to 8 because int(12*0.7) = 8. So I guess ssthresh should be set based on cwnd from when the state was last in CA_Open ?.

What confuses me is that RFC3042 says that CWND should not be modified when in disordered state, however the explanation text in tcp_may_raise_cwnd() seem to indicate that CWND can increase as long as new data is SACKed, right?.

/Ingemar
PS: CC:ed the tcpm group in case this topic is of more general interest