Re: [tcpm] [EXTERNAL] Questions on HyStart++ draft 02

Junho Choi <junho.choi@gmail.com> Tue, 28 April 2020 00:30 UTC

Return-Path: <junho.choi@gmail.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AFD023A0A06 for <tcpm@ietfa.amsl.com>; Mon, 27 Apr 2020 17:30:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FSbyEpvAWesI for <tcpm@ietfa.amsl.com>; Mon, 27 Apr 2020 17:30:19 -0700 (PDT)
Received: from mail-ua1-x92a.google.com (mail-ua1-x92a.google.com [IPv6:2607:f8b0:4864:20::92a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D13EE3A09DA for <tcpm@ietf.org>; Mon, 27 Apr 2020 17:30:19 -0700 (PDT)
Received: by mail-ua1-x92a.google.com with SMTP id a10so19576554uad.7 for <tcpm@ietf.org>; Mon, 27 Apr 2020 17:30:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nLBHTpsDXIdiC/+kG1/dL9vU4r7tln5FTWUR7hM9yeE=; b=lovkPMVfxVdUkcOqtORhgj47j/b3eRptzC8gj8QN3mjVEHuHIJZKHNcStf/SJkbn3s 2y2uC7jo3Qwl1OIHNXEEMCZLt1+cgpkeIjKlsh06hyOOEVEzX+urJLn7lvgjDQC+emy9 s3yVONg5PHSDUZWHfAbg2y+Ajv4Xx7eAVhPnNdFKSFd8L/SIE/hriBxfnhzNFjZD5Uea I+laCzQ/J/hJqsOpEFHkmnjt9QnXcBv6ViemmGcI2IN2Uc8fXEneptuQMDvqvAUkcqP+ 73aLy3GpyUmgX511i8yW3izJppZhCPOhstlAUi84d7tEHHWQP7lz8u6NpQHlFJSeGFK7 XXaA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nLBHTpsDXIdiC/+kG1/dL9vU4r7tln5FTWUR7hM9yeE=; b=SonHRXax17sFIKY942j4sGwN4m8N88YR7vE5VPJUBBtQm7xIB+3TMgISO3iilgSBZ9 TXYaPhRpg1AAJrUagJySa6sxuaqUcMVXoC6DAXNDFFWmY7naPffUqrJCXfGjNWJ12m9s CnnX+s0raHH0Lp5mowl/6+5pldsu/KdLe+zWWmNduqiP2qKXu+8F+iDgQ5CW0w4DoPCF dyWQt51JvkGh8YOElVEeuf449BLiZiNocfz3b0+QooOIyIj2RbJOZoZptPoC+y1jeUsQ uMiSIclSkjUtpDKl2CwYWdBTbPdUBrGk0F3ZMxnHe+AeqVa9pFZovYmjCUKSGnYOIx7i rJOg==
X-Gm-Message-State: AGi0PuaQ7FGt/XhqrlZVD+m9k9Z68pjG/u58fRM3viX7DS7hp8OUsoGM +koKhapr69lw9ry6tfn7jVPgym0EWi4kv8HW51o=
X-Google-Smtp-Source: APiQypIY62qCvs4a5CuHafBm3g8EdR6OAmqY0vWfS0+ZkQ4DjpAM7BUy6NIKI5qRZLcyCTAaAeiUUjpSqbfAkc9DqO4=
X-Received: by 2002:a9f:3826:: with SMTP id p35mr17972965uad.123.1588033818650; Mon, 27 Apr 2020 17:30:18 -0700 (PDT)
MIME-Version: 1.0
References: <CAJ5e+HAtU=-Dy+rEtQ2cLDCj72nzpMymn7DDxc2+fuXr2cWzPw@mail.gmail.com> <SN2PR00MB00778599FB58D63C89C88BCCC3C60@SN2PR00MB0077.namprd00.prod.outlook.com> <CAJ5e+HBjsF6fTXSRABGsbNxUf-MhaErC6yQauN2N2urgNTay5Q@mail.gmail.com> <CY1PR00MB007307864A3675BE240369BDC3C00@CY1PR00MB0073.namprd00.prod.outlook.com> <CAJ5e+HC0CZX2KL7dKgnOOFb78aZH8r_Kmjnp2ESn0dHOzujHXg@mail.gmail.com>
In-Reply-To: <CAJ5e+HC0CZX2KL7dKgnOOFb78aZH8r_Kmjnp2ESn0dHOzujHXg@mail.gmail.com>
From: Junho Choi <junho.choi@gmail.com>
Date: Mon, 27 Apr 2020 17:29:42 -0700
Message-ID: <CAJ5e+HAd=0t2rgY0JpC8UBZv89Pe6vrEyRUsr2q_LwKpdwAD-g@mail.gmail.com>
To: Yi Huang <huanyi@microsoft.com>
Cc: Praveen Balasubramanian <pravb@microsoft.com>, "tcpm@ietf.org" <tcpm@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000a6ee3505a44eefa0"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/7ouJPM88rFX9RhEgzGKdwXWz3k4>
Subject: Re: [tcpm] [EXTERNAL] Questions on HyStart++ draft 02
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2020 00:30:26 -0000

FYI, I made a PR https://github.com/cloudflare/quiche/pull/476 for
implementing HyStart++ in quiche, based on draft 02.
The algorithm is modified for QUIC a little (e.g. tcp sequence number vs
quic packet number) but in general it's same.

Best,

On Tue, Apr 7, 2020 at 5:32 PM Junho Choi <junho.choi@gmail.com> wrote:

> Ok, thanks for clarifying!
>
> On Tue, Apr 7, 2020 at 5:24 PM Yi Huang <huanyi@microsoft.com> wrote:
>
>> Yeah, it does nothing for the first round.
>>
>>
>>
>> *From:* Junho Choi <junho.choi@gmail.com>
>> *Sent:* Thursday, April 2, 2020 12:55 AM
>> *To:* Yi Huang <huanyi@microsoft.com>
>> *Cc:* Praveen Balasubramanian <pravb@microsoft.com>; tcpm@ietf.org
>> *Subject:* Re: [EXTERNAL] Questions on HyStart++ draft 02
>>
>>
>>
>> Hi Yi,
>>
>>
>>
>> Thanks. See inline for my following question.
>>
>>
>>
>> On Wed, Apr 1, 2020 at 5:04 PM Yi Huang <huanyi@microsoft.com> wrote:
>>
>> 1. Section 4.2 -- each round is initialized as
>>
>>
>>
>>    lastRoundMinRTT = currentRoundMinRTT
>>
>>    currentRoundMinRTT = infinity
>>
>>    rttSampleCount = 0
>>
>>
>>
>> In the very beginning of the connection, what is "currentRoundMinRTT" when
>>
>> there is no previous value?
>>
>>
>>
>> I am using current rtt (or initial rtt value) and is it ok?
>>
>>
>>
>> [Yi]: In our implementation, lastRoundMinRTT and currentRoundMinRTT are
>> initialized to 0xffffffff as sentinel values. We only compare
>> lastRoundMinRTT with currentRoundMinRTT when both of them are valid values.
>> Using currRTT seems to essentially behave the same as assigning a sentinel
>> value.
>>
>>
>>
>> So in the beginning of the connection lastRoundMinRTT is <inf>. When ack
>> is received currentRoundMinRTT = min_rtt but
>>
>> lastRoundMinRTT is still <inf>. When the 1st round ends, it looks always
>> doing nothing because the following if() is always false?
>>
>>
>>
>>   if (currentRoundMinRTT >= (lastRoundMinRTT + RttThresh))
>>
>>
>>
>>
>>
>>
>>
>> 2. Section 4.2 -- When used with cubic, CA_cwnd() is based on cubic
>> algorithm I think.
>>
>>  This means I need to do cubic variables calculation during slow start
>>
>>  such as K and W_cubic. When is considered as a start of
>>
>>  congestion avoidance and what W_max will be?
>>
>>
>>
>>  Currently I use a start of limited slow start as a beginning of
>> congestion recovery
>>
>>  and use cwnd at the time for W_max. Is my understanding correct?
>>
>>
>>
>> [Yi]: Yes, that’s exactly what we do in Windows.
>>
>>
>>
>> Sound great. Thanks.
>>
>>
>>
>> Best,
>>
>>
>> --
>>
>> Junho Choi <junho dot choi at gmail.com
>> <https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgmail.com%2F&data=02%7C01%7Chuanyi%40microsoft.com%7C5ed42de0b38e497d502a08d7d6db4055%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637214109469856737&sdata=%2FA2fvoRO0452I5P2CnWRyoDOhO38wHDyOAF6n58UDLY%3D&reserved=0>
>> >
>>
>
>
> --
> Junho Choi <junho dot choi at gmail.com>
>


-- 
Junho Choi <junho dot choi at gmail.com>