Re: [tcpm] [EXTERNAL] Review of hystartplusplus-01

Praveen Balasubramanian <pravb@microsoft.com> Thu, 23 January 2020 06:00 UTC

Return-Path: <pravb@microsoft.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A3E1112003F for <tcpm@ietfa.amsl.com>; Wed, 22 Jan 2020 22:00:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LfMKtIdKgfAm for <tcpm@ietfa.amsl.com>; Wed, 22 Jan 2020 22:00:17 -0800 (PST)
Received: from NAM06-DM3-obe.outbound.protection.outlook.com (mail-eopbgr640106.outbound.protection.outlook.com [40.107.64.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B2FED12002F for <tcpm@ietf.org>; Wed, 22 Jan 2020 22:00:17 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EOf+hPebrKi92GA2eGHlus707Tb4Fug3iR6iV1u6YZg+qUAwrhfI/oEaI7gLjHgkSpbIhUAeBfdtHbQgbUe0sf0ETB0QMCybPu7+OkhlERdW9j4bj8va6JdNXv2Jf8IxSVbCn8fZ0OtDgRUvuB0bjrBZSvkfXRh001qvjuOPD7k4F+H2RICkZVKVs65+SX5jdyvr0bKf9QpJgTrXc0B21W9eoeKEvqE64P6FcWNIm2YbUcsz5EAZt4j/zrYsoWokAun5vgQg0NhtH1UaxNjiA3ckHyLpYr7hX4pD5SusGvM3zrcjDOXUA/ZSTUzeALvELlf4JIQIjeovA2fmHd7kRw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oHV0Zk6pW0hL2Cq5DeeT7bMHjdzrSQ7ErtvSlpWapQo=; b=gdi8c4F8d1CyepDCmJwqFgg0+LfykEu35OGsZA6jbYVHhqv+knOysWSH8Yju53hq5uxDx5MU3IjcVz6iI+k68bmDOyVqwvTNRRr+NeZg+115GIMM7oK0sI5i0wB1HEcPKH/tgmzQyokO9LJViO9FesctxP3ZA6+DXUGuCGbN0Ws19OeGLnhPTZPrtuWtkSZxUevQgvOIXWZMZh4zW8yWylZvbZhzGLEbRHoP6KSElZkji37qS755oPE6u3A8Tn8kF+kbhR6YIgLJQPJWN5Bc6P+CjVJOb/udQOWIeZTWq7Gu2orUD2mTk8WOfjvVytDqgz0y2ka6sJZ/14I47Hw5yw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oHV0Zk6pW0hL2Cq5DeeT7bMHjdzrSQ7ErtvSlpWapQo=; b=Mg1lOlfroQvcklieS1fgtz6tjqf0WdDi8WW6KCG7/Kair5G8EFF91JD3jA+idH3Le6CX6R3lm6QqFhHPQP7nNNS4T3WgEfwbaS3bS7R8p+iEf9vJmKLaTIGU6ajDr+O+erYqCd7rAsLm9vl+qYpjXDi6RIV4ADjvGsvd7GJ6npw=
Received: from BYAPR00MB0454.namprd00.prod.outlook.com (20.178.53.202) by BYAPR00MB0568.namprd00.prod.outlook.com (20.179.56.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2698.0; Thu, 23 Jan 2020 06:00:14 +0000
Received: from BYAPR00MB0454.namprd00.prod.outlook.com ([fe80::ed84:dd1d:d241:ced1]) by BYAPR00MB0454.namprd00.prod.outlook.com ([fe80::ed84:dd1d:d241:ced1%4]) with mapi id 15.20.2705.000; Thu, 23 Jan 2020 06:00:14 +0000
From: Praveen Balasubramanian <pravb@microsoft.com>
To: Ilpo Järvinen <ilpo.jarvinen@cs.helsinki.fi>, "tcpm@ietf.org" <tcpm@ietf.org>, Yi Huang <huanyi@microsoft.com>, Matt Olson <maolson@microsoft.com>
Thread-Topic: [EXTERNAL] Review of hystartplusplus-01
Thread-Index: AQHV0R7kfRB3qKw5302hW7apN/7iv6f3lbAA
Date: Thu, 23 Jan 2020 06:00:11 +0000
Message-ID: <BYAPR00MB0454FEA9A2F9EBDB60A544EBB60F0@BYAPR00MB0454.namprd00.prod.outlook.com>
References: <alpine.DEB.2.20.2001221413070.25645@whs-18.cs.helsinki.fi>
In-Reply-To: <alpine.DEB.2.20.2001221413070.25645@whs-18.cs.helsinki.fi>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=pravb@ntdev.microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-01-23T06:00:10.4608689Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=1a0111a6-1cfd-44d3-a662-f5e62820e20c; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic
authentication-results: spf=none (sender IP is ) smtp.mailfrom=pravb@microsoft.com;
x-originating-ip: [2001:4898:80e8:8:6c76:cda3:12a0:f9f8]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 6ab66465-3a0a-4878-78be-08d79fc98404
x-ms-traffictypediagnostic: BYAPR00MB0568:|BYAPR00MB0568:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BYAPR00MB0568197A45CC010F08568254B60F0@BYAPR00MB0568.namprd00.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-forefront-prvs: 029174C036
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(199004)(189003)(76116006)(2906002)(66556008)(66476007)(10290500003)(64756008)(66946007)(478600001)(66446008)(52536014)(5660300002)(9686003)(8936002)(55016002)(316002)(296002)(8676002)(110136005)(81156014)(71200400001)(81166006)(53546011)(6636002)(6666004)(33656002)(6506007)(8990500004)(86362001)(7696005)(186003); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR00MB0568; H:BYAPR00MB0454.namprd00.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: +lOv8vgQISyi209sIv93N8a9YilHrrJJol0yyJl9WL0D6dJMA/dBUic2LdffxiT+WumgRnLPHsDca09m2BrZJji1aKrC18Rj56/HfmnMwcPONtNS36T2bfe3SgswBLLKvYix16iIP9DJ6EiBq1BJ7tLMyNamUDFobaNQaJlPfUerrTHyhIDoKvb+EF4C3NcMO5RwjIOzzZZnpqQFIC3RZnmyA3HW8hDni3kzfKD22Y89+x29zpLWssx9wKK95XY/vbe1UyHIYr/xSAWEB/kNZXsOCUtrJsXFNchTA2dfDoq5R5/7Dt17ibBd9BW2ppnQoSj1xdgt+IdjsxpHtAt0IHFQo8WRfZhTmjy4LR2OdiQ6GcsjJGgtvKyx/8PLUPtbMaFYur/FW874jW9a+h28NZ4Zw1pQokce5qKaskub2akUJx9S98dRcjujKVcbgyW4
x-ms-exchange-antispam-messagedata: C00jYCMZz3X/gR8bRnkOwGK7/4N5d5cDHLxfs3uZa0eVOEE+h1GM1SvPxuDNqXIHQNMjV6zCfyR2cJ4ymhbP7Ovni7hqddtr8qMBgjxDjGezuLLNFEHszY7gvdFEGjaCQzK2pg1rKGGV/JG9ZKBteA7qaXaQXZ/oF3nXDBYVByp/DniLbPi7ILuSL11KAmTyvlG1OTfmfrIWRIO6jQl+3Q==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ab66465-3a0a-4878-78be-08d79fc98404
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2020 06:00:11.7310 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LEO7CVYK0vNDwNxKFfDmGX0EW6+EHKz9A7daFvtQ/ruD3PW4+F/JOnWqpCqN2+q1Vp1E/HS6j/G9CvzBiHQNfe9MpE6asP/p1GA80BnKBcY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR00MB0568
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/A7Aht43uNy3dxauvk8fOT8vJAdI>
Subject: Re: [tcpm] [EXTERNAL] Review of hystartplusplus-01
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jan 2020 06:00:22 -0000

Thanks for the review!

The variable name Eta comes from equations in the HyStart paper " Hybrid Slow Start for High-Bandwidth and Long-Distance Networks" which use the Greek alphabet η. We will change to call it RTT threshold to avoid confusion with "estimated time of arrival".

Indeed that is a contradiction and is a mistake. HyStart++ ends after the first congestion signal is observed. 

Thanks

-----Original Message-----
From: Ilpo Järvinen <ilpo.jarvinen@cs.helsinki.fi> 
Sent: Wednesday, January 22, 2020 4:24 AM
To: tcpm@ietf.org; Praveen Balasubramanian <pravb@microsoft.com>; Yi Huang <huanyi@microsoft.com>; Matt Olson <maolson@microsoft.com>
Subject: [EXTERNAL] Review of hystartplusplus-01

Hi all,

I've just read through the HyStart++ draft v01. Two comments:

I find using variable named "Eta" and related constants (MIN/MAX_ETA) somewhat strange as to me ETA reads "estimated time of arrival" which in the context didn't seem to make much of a sense.

Then there is a major contradiction within the draft:

if (currentRoundMinRTT >= (lastRoundMinRTT + Eta))
               ssthresh = cwnd
               exit slow start and enter LSS

  "HyStart++ ends when cwnd exceeds ssthresh or when congestion is
   observed."

...ssthresh is set to cwnd when exiting slow start and LSS is entered as per the algorithm but the quoted sentence tells that LSS will be terminated as soon as cwnd grows any?

--
 i.