[tcpm] Full review of: draft-ietf-tcpm-hystartplusplus-02 (editorial)

Bob Briscoe <ietf@bobbriscoe.net> Thu, 22 July 2021 15:43 UTC

Return-Path: <ietf@bobbriscoe.net>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D5C63A4AC9; Thu, 22 Jul 2021 08:43:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=bobbriscoe.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S_kqSBbApNkc; Thu, 22 Jul 2021 08:43:14 -0700 (PDT)
Received: from mail-ssdrsserver2.hostinginterface.eu (mail-ssdrsserver2.hostinginterface.eu [185.185.85.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 063053A4AC6; Thu, 22 Jul 2021 08:43:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bobbriscoe.net; s=default; h=Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:Cc:References:To:Subject:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NrKstjJUVTxCBUu/swiC9P2nTi9Bk6yiGSWdjaoNbX8=; b=McCJDzkXZBv2ni6e584ma2D6Qy BzgsbePBKeb8THgoinwuPUKhMlqY0APNGLEj61BVljxV3bO+++b7/427955cLbj+uzvRV3Hp/8XeG uNCdpqBu5OxioB1bEeXz7q+PIJCzEXG35HZ8e4ewkJYaTTviAX4dti4oSVB8qmHrb7cOLCXD2/xwM 3lX/dXrLeY8kaaY3nJwtil/r9+brr8Tnn9azqhxBLwuqH88zMp0oIe9AKx+9pfDHUH666oIxa81Ei E+SMKnXgEOziuBEW66U1ihr0kcYXnBczmo1sk3ehzLsCZz9IqISm5AuIzRgJ+6wJ10tjLIsttHTKO swhh9SmQ==;
Received: from 67.153.238.178.in-addr.arpa ([178.238.153.67]:48764 helo=[192.168.1.10]) by ssdrsserver2.hostinginterface.eu with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from <ietf@bobbriscoe.net>) id 1m6aqw-0002vl-94; Thu, 22 Jul 2021 16:43:07 +0100
From: Bob Briscoe <ietf@bobbriscoe.net>
To: Praveen Balasubramanian <pravb@microsoft.com>
References: <162610476442.30543.4667406094304409800@ietfa.amsl.com>
Cc: tcpm@ietf.org, draft-ietf-tcpm-hystartplusplus@ietf.org
Message-ID: <81092896-921b-9563-42b5-e9f412d5782d@bobbriscoe.net>
Date: Thu, 22 Jul 2021 16:43:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <162610476442.30543.4667406094304409800@ietfa.amsl.com>
Content-Type: multipart/alternative; boundary="------------15980C87736543ED7F9D9E1D"
Content-Language: en-GB
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - ssdrsserver2.hostinginterface.eu
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - bobbriscoe.net
X-Get-Message-Sender-Via: ssdrsserver2.hostinginterface.eu: authenticated_id: in@bobbriscoe.net
X-Authenticated-Sender: ssdrsserver2.hostinginterface.eu: in@bobbriscoe.net
X-Source:
X-Source-Args:
X-Source-Dir:
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/AGbUiCWEa25xCnmaXnqmeyZqHfM>
Subject: [tcpm] Full review of: draft-ietf-tcpm-hystartplusplus-02 (editorial)
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jul 2021 15:43:20 -0000

Praveen and co-authors.

Thank you for hystart++.
I've sent a separate posting with technical review comments.

Cheers


Bob


    ==Editorial comments==


      Abstract

s/doument/document/
s/overshotting/overshooting


      1. Intro

s/pefrormance/performance/

"...lead to overshooting the ideal sending rate and cause significant 
packet loss"
Also queuing delay? Is reducing queuing delay (for other flows) also a 
goal of Hystart++?

Last para of intro seems to be about Hystart, and it doesn't make it 
clear how Hystart relates to Hystart++:
* "HyStart++ adds delay increase..."
    Adds to what?
* "After the HyStart delay algorithm finds an exit point, a Conservative 
Slow Start (CSS) phase is used"
   But what about Hystart++? does it do CSS too?

Final sentence is not related to the rest of the para about Hystart, so 
should be a separate para.


      3. Definitions

It seems odd to define some well-known variables (like cwnd), but not 
others like SND.UNA, SND.NXT, etc.

cwnd: Would be useful to define the units assumed in the pseudocode 
later (bytes), because some implementations use segments.
It's confusing for cwnd to use bytes but LOW_CWND to use segments.


      4.2 Algorithm Details


     "The choice of value of L is up to the implementation."
I suggest:
     "The choice of value of L is discussed in RFC 3465."
Reason: RFC3465 doesn't say it's completely up to the implementation - 
it gives recommendations and advice.

"normal slow start"
I appreciate you were asked to use this word, but... I suggest it's best 
to define this phrase because, for instance, the normal slow start for 
Cubic (Hystart) is different from the normal slow start for Reno. It's 
also a problem finding a good word that means the pre-existing thing. 
'Reno slow start' would be more precise than 'normal slow start' (if you 
mean the one in Reno). Because Cubic is more normal than Reno these 
days. And saying 'standard' will soon be ambiguous, because Cubic is on 
its way onto the standards track.


     "If congestion is observed anytime during slow start or CSS, enter 
congestion avoidance."
The word 'congestion' is ambiguous, because it could include delay 
increase. How about:
     "If loss or ECN-marking is observed anytime during slow start or 
CSS, enter congestion avoidance."


      5.  Deployments and Performance Evaluations

    As of the time of writing, HyStart++ has been default enabled for all
    TCP connections in Windows for two years.  The original Hystart has
    been default-enabled for all TCP connections in Linux TCP for a
    decade.


I suggest you give the actual deployment times, so these two sentences 
don't keep having to be updated as the draft ages.
Also, in Linux, Hystart is only implemented for Cubic (the default CC 
module), so Hystart is not default if a non-default CC module is in use. 
How about:

    In Linux, the original Hystart has been default enabled for
    TCP connections using the default congestion control module (Cubic)
    for a decade.


Regards


Bob


On 12/07/2021 16:46, internet-drafts@ietf.org wrote:
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the TCP Maintenance and Minor Extensions WG of the IETF.
>
>          Title           : HyStart++: Modified Slow Start for TCP
>          Authors         : Praveen Balasubramanian
>                            Yi Huang
>                            Matt Olson
> 	Filename        : draft-ietf-tcpm-hystartplusplus-02.txt
> 	Pages           : 8
> 	Date            : 2021-07-12
>
> Abstract:
>     This doument describes HyStart++, a simple modification to the slow
>     start phase of TCP congestion control algorithms.  Traditional slow
>     start can cause overshotting of the ideal send rate and cause large
>     packet loss within a round-trip time which results in poor
>     performance.  HyStart++ is composed of the delay increase variant of
>     HyStart to prevent overshooting of the ideal sending rate, while also
>     mitigating poor performance which can result from false positives.
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-tcpm-hystartplusplus/
>
> There is also an htmlized version available at:
> https://datatracker.ietf.org/doc/html/draft-ietf-tcpm-hystartplusplus-02
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-tcpm-hystartplusplus-02
>
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
>
> _______________________________________________
> tcpm mailing list
> tcpm@ietf.org
> https://www.ietf.org/mailman/listinfo/tcpm


-- 
________________________________________________________________
Bob Briscoe                               http://bobbriscoe.net/