Re: [tcpm] Genart last call review of draft-ietf-tcpm-rto-consider-14

Mark Allman <mallman@icir.org> Mon, 08 June 2020 19:52 UTC

Return-Path: <mallman@icsi.berkeley.edu>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AE5373A0F75 for <tcpm@ietfa.amsl.com>; Mon, 8 Jun 2020 12:52:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.648
X-Spam-Level:
X-Spam-Status: No, score=-1.648 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fQjFeMMS62pe for <tcpm@ietfa.amsl.com>; Mon, 8 Jun 2020 12:52:21 -0700 (PDT)
Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 63DCF3A0F72 for <tcpm@ietf.org>; Mon, 8 Jun 2020 12:52:21 -0700 (PDT)
Received: by mail-ot1-f47.google.com with SMTP id e5so14661631ote.11 for <tcpm@ietf.org>; Mon, 08 Jun 2020 12:52:21 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=Upez9eIeT9AvHRzUK+lVGNytAgvsPj1BlLYi14tvyDg=; b=V8dsRIlh8MNdEmmbN+fwwWY+2Ko+diZGDVC/KwqQ+LBZAFkh9SWuPqZo0I/QY4Ebje x4a4MNZcQSq/PseeuNtS3KDwCXoJSpg5XniHNHfw+wqE8jQ9Lzsr7aMIuXFvQ9VRwHXC 5wle0ZPcgqvihd9ZtZLs1gsyw319bLEEzpAe93AxBE9yIa+GHxqlBIU89tJ2ghVXw0Fb nZInaw7qvBO+6vWnoLtYBvZ84H0n5ggf0YL15pe36D7Mjz7m/sJybnq7mrk57UNQREyp 0n+cOkI4BqVNSsMyD+bTI34UrQbCMglmRd/Q+oPzADe9T3H5QOrvysva3/ZPAQt72kp4 kQow==
X-Gm-Message-State: AOAM531vEUS0Hnfpmc7Y0ug9pFU5dqJrsFLFWTr6TCHCHVQOpExmN1Vq CvydQ+d+tBj+hr5Qv6WqxnDI4A==
X-Google-Smtp-Source: ABdhPJzdvhEwIKWPOGAPQfQXs0FzlbAH4HmvOjqoISdzn388k38ub0r7KIz/MS9+WN/bD+/l8y61Hg==
X-Received: by 2002:a9d:5190:: with SMTP id y16mr7800282otg.68.1591645940497; Mon, 08 Jun 2020 12:52:20 -0700 (PDT)
Received: from [192.168.1.244] ([2600:1700:b380:3f00:fc:25c4:9d82:7cf3]) by smtp.gmail.com with ESMTPSA id g10sm1722761otn.34.2020.06.08.12.52.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jun 2020 12:52:19 -0700 (PDT)
From: Mark Allman <mallman@icir.org>
To: Stewart Bryant <stewart.bryant@gmail.com>
Cc: Review Team <gen-art@ietf.org>, tcpm <tcpm@ietf.org>, Last Call <last-call@ietf.org>, draft-ietf-tcpm-rto-consider.all@ietf.org, tom petch <daedulus@btconnect.com>
Date: Mon, 08 Jun 2020 15:52:16 -0400
X-Mailer: MailMate (1.13.1r5671)
Message-ID: <0F4B56B1-C8B9-493E-B3CD-AC2FBA9E62E4@icir.org>
In-Reply-To: <9A0DBDC4-2E39-4D09-80A6-FEDE72ED205B@gmail.com>
References: <159083802039.5596.14695350463305243689@ietfa.amsl.com> <FE0FA7D5-176D-4111-95DA-BD5424A24FE2@icir.org> <9A0DBDC4-2E39-4D09-80A6-FEDE72ED205B@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=_MailMate_966D57F8-BB69-424D-B202-762EE2016A5E_="; micalg="pgp-sha1"; protocol="application/pgp-signature"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/C1A0E_epvDsPILa3hOL5I7TyGog>
Subject: Re: [tcpm] Genart last call review of draft-ietf-tcpm-rto-consider-14
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jun 2020 19:52:23 -0000

Hi Stewart, et.al.!

I just submitted a new version of rto-consider.  Please ask the
datatracker for diffs between this and rev -14.  The highlights:

  - The diffs with the last rev are here: https://tools.ietf.org/rfcdiff?difftype=--hwdiff&url2=draft-ietf-tcpm-rto-consider-15.txt

  - All small comments addressed.

  - I think we all agree that this is not a one-size-fits-all
    situation.  Rather, this document is meant to be a default case.
    So, the main action of this rev is to make that point more
    clearly.  The first paragraph in the intro is new.  Also, there
    are some more words fleshing out the context more in section 2.
    In particular, more emphatically making the point that other
    loss detectors are fine for specific cases.

  - The first paragraph in the intro also makes clear we adopt the
    loss == congestion model (as that is the conservative default,
    not because it is always true).

  - I made one other change that wasn't exactly called for, but
    seems like an oversight.

    Previously guideline (4) said loss MUST be taken as an
    indication of congestion and some standard response taken.  But,
    this guideline has an explicit exception for cases where we know
    the loss was caused by some non-congestion event.  Guideline (3)
    says you MUST backoff.  But, it did not have this exception for
    cases where we can tell the cause.  But, I think based on the
    spirit of (4), (3) should also have these words.  So, I added
    them.

    Also, I swapped (3) and (4) because it seemed more natural in
    re-reading to first think about taking congestion action and
    then dealing with backoff.  I think the ordering is a small
    thing, but folks can yell and I'll put it back if there is
    angst.

Please take a look and let me know if this helps things along or
not.

allman