Re: [tcpm] I-D Action: draft-ietf-tcpm-converters-12.txt

<philip.eardley@bt.com> Mon, 21 October 2019 13:10 UTC

Return-Path: <philip.eardley@bt.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 23B31120033 for <tcpm@ietfa.amsl.com>; Mon, 21 Oct 2019 06:10:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=bt.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R7_QfHd4WInn for <tcpm@ietfa.amsl.com>; Mon, 21 Oct 2019 06:10:10 -0700 (PDT)
Received: from smtpe1.intersmtp.com (smtpe1.intersmtp.com [213.121.35.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0656A12004D for <tcpm@ietf.org>; Mon, 21 Oct 2019 06:10:10 -0700 (PDT)
Received: from tpw09926dag11f.domain1.systemhost.net (10.9.212.19) by BWP09926082.bt.com (10.36.82.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1713.5; Mon, 21 Oct 2019 14:10:04 +0100
Received: from tpw09926dag18g.domain1.systemhost.net (10.9.212.34) by tpw09926dag11f.domain1.systemhost.net (10.9.212.19) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 21 Oct 2019 14:10:07 +0100
Received: from bwp09926079.bt.com (10.36.82.110) by tpw09926dag18g.domain1.systemhost.net (10.9.212.34) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Mon, 21 Oct 2019 14:10:07 +0100
Received: from GBR01-CWL-obe.outbound.protection.outlook.com (104.47.20.52) by smtpe1.intersmtp.com (10.36.82.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1713.5; Mon, 21 Oct 2019 14:10:05 +0100
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nz7cujndNJKZrhzN2vHsDvuP5jiWPVUycNKpwl+veqjMT/Fp6y+vssKHxPCAJTeQzvWaRAmhSjqOkjR6tVdFpz3pUPX93NGHBAK9MycV7FWvd3bbxDCPQiabGEmXlSNy8pE/hRgW0NQHeA1P3aTgG5UtWFj4y7JQCfhHoms2t32FDAp8j+u53INfGKkjboGGFqMMPcXY0QOPu/mG2uMgLKNCT6hcWI9ki+mp0535FwNXcZzpTrKF1qYQNtHLq+uK5OxLxTY1y2gdPvBvKC7yMKHRlgmiDQy6UIjxn3IDIbqoLqoXpWeNIs3gc/keBWPWCwEOrPIdepDsoymhA+RWRg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qG+tXSlMwMpcp+DzLwININj8OA/kWrul3mL7ArNFY9A=; b=TCjuOp/oNm2p8c2ctUoTyJ8xOVuRx92ZHfKhuVazm4zYnRhZQdED5sz5+c8uoGCpvxNvMzinBIeNz3EKkBmrCpgMWLnc+/zUXgAlBAgbicqZwkF04f5PmSr017rgqysTJH9OfBTNU8TJUs/Kpd5ufUK1MEbdY2hGLhz6YfvhtcbobIfxL2BA0ZlFYq5+BYs80MRtl/lrWacdHAYAgfvcs5hMXdJF9SuU1EPHcOmRN+vDlD+em3LiZHYaWwAxNusklcYw09Q4NDSl6kQtAYksaje0RNV2q2ISRpk+XXaro63ec9JfORrQolNwZ3NE5TDkxqVR9B3Hyh147DJQ80TcFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bt.com; dmarc=pass action=none header.from=bt.com; dkim=pass header.d=bt.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qG+tXSlMwMpcp+DzLwININj8OA/kWrul3mL7ArNFY9A=; b=TQxvOmrJ+2SA9gtJqoi+vy9YbuF2tizmcnhqpSfaAkFrPWP11b6mHBX32E33UTZKvVqHPqnFsh0uVQk2CmMcE+Xr1+V8dbrTcJVjQjAHqep4NyZPLRhhUhxt2lnSmwPfQqlpMw8D2UyBfiixIv5vPflPjiYLcUwO88Unb0SZNO0=
Received: from CWLP123MB2579.GBRP123.PROD.OUTLOOK.COM (20.176.58.79) by CWLSPR01MB0010.GBRP123.PROD.OUTLOOK.COM (20.176.40.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.20; Mon, 21 Oct 2019 13:10:06 +0000
Received: from CWLP123MB2579.GBRP123.PROD.OUTLOOK.COM ([fe80::5c43:4d65:4081:f8a8]) by CWLP123MB2579.GBRP123.PROD.OUTLOOK.COM ([fe80::5c43:4d65:4081:f8a8%5]) with mapi id 15.20.2347.029; Mon, 21 Oct 2019 13:10:05 +0000
From: <philip.eardley@bt.com>
To: <mohamed.boucadair@orange.com>, <Michael.Scharf@hs-esslingen.de>
CC: <tcpm@ietf.org>
Thread-Topic: [tcpm] I-D Action: draft-ietf-tcpm-converters-12.txt
Thread-Index: AQHVesazxMnJ0MpTtUGYTCO0/wPXnKdKmMEAgBqMdbA=
Date: Mon, 21 Oct 2019 13:10:04 +0000
Message-ID: <CWLP123MB2579C2F8AE08479F02AD64DBEB690@CWLP123MB2579.GBRP123.PROD.OUTLOOK.COM>
References: <157020217020.1400.989960668789303006@ietfa.amsl.com> <787AE7BB302AE849A7480A190F8B933031338ED7@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
In-Reply-To: <787AE7BB302AE849A7480A190F8B933031338ED7@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=philip.eardley@bt.com;
x-originating-ip: [193.113.37.9]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5f99fd45-736a-47f7-d864-08d75627fd63
x-ms-traffictypediagnostic: CWLSPR01MB0010:
x-ms-exchange-purlcount: 5
x-microsoft-antispam-prvs: <CWLSPR01MB0010858F60CE88694BE50841EB690@CWLSPR01MB0010.GBRP123.PROD.OUTLOOK.COM>
x-antispam-2: 1
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0197AFBD92
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(396003)(39860400002)(346002)(366004)(136003)(189003)(199004)(13464003)(66476007)(476003)(71190400001)(256004)(66556008)(305945005)(66946007)(76116006)(26005)(76176011)(316002)(7696005)(53546011)(6506007)(110136005)(11346002)(446003)(99286004)(102836004)(14444005)(64756008)(66446008)(6246003)(9686003)(8676002)(6436002)(81156014)(81166006)(2501003)(66574012)(55016002)(6306002)(71200400001)(486006)(25786009)(7736002)(229853002)(966005)(5660300002)(8936002)(52536014)(74316002)(3846002)(14454004)(6116002)(186003)(66066001)(478600001)(4326008)(33656002)(86362001)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:CWLSPR01MB0010; H:CWLP123MB2579.GBRP123.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: bt.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: eUrHxl4nZOZblIkTC5c6Ro53mW79FXv3CRKy4qrdSulgG/GbzOOVTkBCTXDXtlbqaCTeel5UavBG65tqSDzTN3zptW/WxIpN7Z8kHDwvsS0WdeP/7SRSdO9xafKLKlXK1TmYovDPN8NDMvWPiFcsBg6SFv9YIyAvGhB6LYGZrBIFVCd6wg2pZn1oG4hBeB2/QA4IwaBdQylCdtUNEMEet1M5/L7ODZURli85mUHhnfQ0aeziMHvNAyGB1grurkG/j2pZEZ3lsdlbYCBJQsRdeEuOkgDme5dWaZHlXHicS6Vo4iDRsE7GZBMpb08Kt8P5R4F13ok8jKYA+Q2eT3CjAMhmdNvGVAQOky1lOmcRekPvnxdHq586RNrnZjghuUkUKIAa2CS1rdhUjSxAGw0CIRQqMSHv/VUovMS3b6Z4I/lPX97zlocsX0+2pQ50rwdOO/Hc85Rc1jipVFr8fiL0xpX2qxfISjqgSTk5OxNL81k=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f99fd45-736a-47f7-d864-08d75627fd63
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2019 13:10:04.9807 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a7f35688-9c00-4d5e-ba41-29f146377ab0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: p0WGKjbWYiO8ow8jTlgeiMies4A75eh0mx1gYV05MGEtl769h17igePOv8bnKCB0dod2a+E1dc9mL/nuTNvj3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLSPR01MB0010
X-NAI-Spam-Flag: NO
X-NAI-Spam-Threshold: 5
X-NAI-Spam-Score: 0
X-NAI-Spam-Report: 3 Rules triggered * 0 -- EDT_SDHA_ADR_FRG * 0 -- EDT_SDHA_DMN_FRG * 0 -- RV6659
X-NAI-Spam-Version: 2.2.0.9309 : core <6659> : inlines <7155> : streams <1836268> : uri <2925444>
X-OriginatorOrg: bt.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/EBgV92yqrUd1tm1aTfYTJ3kBoJs>
Subject: Re: [tcpm] I-D Action: draft-ietf-tcpm-converters-12.txt
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Oct 2019 13:10:13 -0000

Med,
Thanks for creating these new pieces of text, I think they're helpful and it's looking good!

Comments:
Section 3.3
<<User data is unambiguously distinguished from Convert TLVs by a Transport Converter owing to the Total Length field in the Convert messages>>
Better:
User data is unambiguously distinguished from Convert TLVs by a Transport Converter by the Convert Fixed Header (Figure 12) in the Convert messages

In Section 3.3, I think you should move the text about MPTCP out of S3.3 (into S3.4, maybe with some renumbering of S3.4 & 3.5 to make a section about mptcp)
[this is the text "Note that for the Multipath TCP case..." to the Figure 8 caption and the bullet "In reference to Figure 8"]
Reason: handle the general case first, then the MPTCP variant. 

<< Note that for the Multipath TCP case, the Transport Converter identifies an MPTCP connection by means, e.g., of the token assigned to the MPTCP connection.>>
If I get it right, this is nothing to do with the token defined in MPTCP, but is simply an identifier internal to the Converter (to help it keep together entries for the same Client). Ie this token is not seen on the wire. Please could you re-phrase the para and the definition of "token" in the Figure 8 caption. 

Section 4.1
In the Figure 12 caption, I suggest deleting "-Sized" (so: "Figure 12: The Fixed Header of the Convert Protocol" or even "Figure 12: The Convert Fixed Header")

Section D.2
Appendix D.1 has a final paragraph which doesn't appear at the end of D.2 (<<The Transport Converter must be on the forwarding path of incoming traffic.>>)
I assume the same text is true for the IPv4 address sharing model. I suggest adding a comment at the end of D.2 that the same considerations apply (or repeating the paragraph, possibly with "IP address" changed to "IP address prefix")
I also suggest changing the title "IPv4 Address Sharing" to "Address Sharing"

Best wishes,
phil


-----Original Message-----
From: mohamed.boucadair@orange.com [mailto:mohamed.boucadair@orange.com] 
Sent: 04 October 2019 16:20
To: Eardley,PL,Philip,TUD1 R <philip.eardley@bt.com>om>; Scharf, Michael (Michael.Scharf@hs-esslingen.de) <Michael.Scharf@hs-esslingen.de>
Cc: tcpm@ietf.org
Subject: RE: [tcpm] I-D Action: draft-ietf-tcpm-converters-12.txt

Hi Phil, Michael, 

This version implements the suggestions discussed so far: add a new section to discuss data processing once a state is created + appendix to discuss address sharing/preservation modes. 

I think this version solves the concerns raised by Phil. 

Looking forward to advance the document. 

Cheers,
Med

> -----Message d'origine-----
> De : tcpm [mailto:tcpm-bounces@ietf.org] De la part de internet- 
> drafts@ietf.org Envoyé : vendredi 4 octobre 2019 17:16 À : 
> i-d-announce@ietf.org Cc : tcpm@ietf.org Objet : [tcpm] I-D Action: 
> draft-ietf-tcpm-converters-12.txt
> 
> 
> A New Internet-Draft is available from the on-line Internet-Drafts 
> directories.
> This draft is a work item of the TCP Maintenance and Minor Extensions 
> WG of the IETF.
> 
>         Title           : 0-RTT TCP Convert Protocol
>         Authors         : Olivier Bonaventure
>                           Mohamed Boucadair
>                           Sri Gundavelli
>                           SungHoon Seo
>                           Benjamin Hesmans
> 	Filename        : draft-ietf-tcpm-converters-12.txt
> 	Pages           : 52
> 	Date            : 2019-10-04
> 
> Abstract:
>    This document specifies an application proxy, called Transport
>    Converter, to assist the deployment of TCP extensions such as
>    Multipath TCP.  This proxy is designed to avoid inducing extra delay
>    when involved in a network-assisted connection (that is, 0-RTT).
> 
>    This specification assumes an explicit model, where the proxy is
>    explicitly configured on hosts.
> 
>    -- Editorial Note (To be removed by RFC Editor)
> 
>    Please update these statements with the RFC number to be assigned to
>    this document: [This-RFC]
> 
>    Please update TBA statements with the port number to be assigned to
>    the 0-RTT TCP Convert Protocol.
> 
> 
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-tcpm-converters/
> 
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-tcpm-converters-12
> https://datatracker.ietf.org/doc/html/draft-ietf-tcpm-converters-12
> 
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-tcpm-converters-12
> 
> 
> Please note that it may take a couple of minutes from the time of 
> submission until the htmlized version and diff are available at 
> tools.ietf.org.
> 
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
> 
> _______________________________________________
> tcpm mailing list
> tcpm@ietf.org
> https://www.ietf.org/mailman/listinfo/tcpm