[tcpm] Comments on draft-ietf-tcpm-icmp-attacks-04.txt

Gorry Fairhurst <gorry@erg.abdn.ac.uk> Wed, 26 November 2008 10:39 UTC

Return-Path: <tcpm-bounces@ietf.org>
X-Original-To: tcpm-archive@megatron.ietf.org
Delivered-To: ietfarch-tcpm-archive@core3.amsl.com
Received: from [127.0.0.1] (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 97C2E3A691A; Wed, 26 Nov 2008 02:39:09 -0800 (PST)
X-Original-To: tcpm@core3.amsl.com
Delivered-To: tcpm@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 95FC428C0ED for <tcpm@core3.amsl.com>; Wed, 26 Nov 2008 02:39:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V1cZ+7JLES6K for <tcpm@core3.amsl.com>; Wed, 26 Nov 2008 02:39:07 -0800 (PST)
Received: from erg.abdn.ac.uk (dee.erg.abdn.ac.uk [IPv6:2001:630:241:204:203:baff:fe9a:8c9b]) by core3.amsl.com (Postfix) with ESMTP id 573A43A68D1 for <tcpm@ietf.org>; Wed, 26 Nov 2008 02:39:06 -0800 (PST)
Received: from Gorry-Fairhursts-Laptop.local (fgrpf.plus.com [212.159.18.54]) (authenticated bits=0) by erg.abdn.ac.uk (8.13.4/8.13.4) with ESMTP id mAQAcU5H024892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 26 Nov 2008 10:38:31 GMT
Message-ID: <492D2726.3060505@erg.abdn.ac.uk>
Date: Wed, 26 Nov 2008 10:38:30 +0000
From: Gorry Fairhurst <gorry@erg.abdn.ac.uk>
Organization: The University of Aberdeen is a charity registered in Scotland, No SC013683.
User-Agent: Thunderbird 2.0.0.17 (Macintosh/20080914)
MIME-Version: 1.0
To: tcpm@ietf.org
X-ERG-MailScanner: Found to be clean
X-ERG-MailScanner-From: gorry@erg.abdn.ac.uk
Cc: Gorry <gorry@erg.abdn.ac.uk>, fernando@gont.com.ar
Subject: [tcpm] Comments on draft-ietf-tcpm-icmp-attacks-04.txt
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: gorry@erg.abdn.ac.uk
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://www.ietf.org/mailman/private/tcpm>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Sender: tcpm-bounces@ietf.org
Errors-To: tcpm-bounces@ietf.org

I volunteered to review this I-D in the TCPM meeting in MPLS.

I'd like to make the following observations, and explore whether these 
are issues:

* It was interesting to read the issues presented in the I-D. The I-D is 
mainly documentation of algorithms and current practice. If published, 
this seems like an informational document - I can not determine whether 
this is needed, and whether the material could already be covered by 
other documentation.

* One section of the document (6) describes issues with Source-Quench, 
however this is not a credible issue - it has long been known that 
Source-Quench is not of value. I think this section could safely be 
omitted, reduced or combined with earlier sections to provide more 
rationale for the main part of the I-D.

* The main part of the document is about PMTUD vulnerabilities to ICMP 
attacks and some deployed countermeasures. In my opinion, this 
discussion should be set against the framework defined by the IETF 
standards-track  "Packetization Layer Path MTU Discovery", RFC 4821, 
March 2007. This is not currently mentioned, which I find very 
confusing. I'd suggest that if the document is to be published as a 
useful output of the transport area it must compare the non-ICMP methods 
to those in RFC 4821.

* Appendix A concludes with an interpretation of the meaning of several 
RFCs. If this is the result of an IETF WG consensus call, this needs to 
be made clear and more effort needs to be made to determine the correct 
advice. If this is the editor's own view, then it should be omitted from 
a working group draft.

* Finally, I do not see a detailed discussion of ICMP issues in general 
as the title suggests, but more of a focus on PMTUD attacks. A change to 
the title and abstract would help attract the right people to read this 
and better reflect the actual content.

I will separately send some comments on the document itself to the list, 
but have decided to postpone the final stage of the review until I hear 
more about the relationship to PLPMTUD, since this may require some 
reworking of the document. It may be that there has been discussion on 
this topic before, if so please let me know.

Best wishes,

Gorry
_______________________________________________
tcpm mailing list
tcpm@ietf.org
https://www.ietf.org/mailman/listinfo/tcpm