Re: [tcpm] WGLC for draft-ietf-tcpm-converters-08

<mohamed.boucadair@orange.com> Fri, 28 June 2019 09:27 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0EFD11201C5; Fri, 28 Jun 2019 02:27:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.598
X-Spam-Level:
X-Spam-Status: No, score=-2.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v5QQeiBz7_WN; Fri, 28 Jun 2019 02:27:06 -0700 (PDT)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.66.40]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5F2B7120096; Fri, 28 Jun 2019 02:27:06 -0700 (PDT)
Received: from opfedar03.francetelecom.fr (unknown [xx.xx.xx.5]) by opfedar25.francetelecom.fr (ESMTP service) with ESMTP id 45Zry06fs7z8yBS; Fri, 28 Jun 2019 11:27:04 +0200 (CEST)
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.89]) by opfedar03.francetelecom.fr (ESMTP service) with ESMTP id 45Zry05VF8zCqkc; Fri, 28 Jun 2019 11:27:04 +0200 (CEST)
Received: from OPEXCAUBMA2.corporate.adroot.infra.ftgroup ([fe80::e878:bd0:c89e:5b42]) by OPEXCAUBM44.corporate.adroot.infra.ftgroup ([fe80::e8a4:8bb:d7c2:f4e2%21]) with mapi id 14.03.0439.000; Fri, 28 Jun 2019 11:27:04 +0200
From: <mohamed.boucadair@orange.com>
To: "philip.eardley@bt.com" <philip.eardley@bt.com>, "Michael.Scharf@hs-esslingen.de" <Michael.Scharf@hs-esslingen.de>, "tcpm@ietf.org" <tcpm@ietf.org>
CC: "tcpm-chairs@ietf.org" <tcpm-chairs@ietf.org>
Thread-Topic: WGLC for draft-ietf-tcpm-converters-08
Thread-Index: AdUrckm1sQAV9Sf8TqW1iT6fsU2DwgBZdsDwACyBV3A=
Date: Fri, 28 Jun 2019 09:27:03 +0000
Message-ID: <787AE7BB302AE849A7480A190F8B93302EAAF429@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
References: <6EC6417807D9754DA64F3087E2E2E03E2D35AB8E@rznt8114.rznt.rzdir.fht-esslingen.de> <LNXP123MB258781EFAC897351EDB153E2EBFD0@LNXP123MB2587.GBRP123.PROD.OUTLOOK.COM>
In-Reply-To: <LNXP123MB258781EFAC897351EDB153E2EBFD0@LNXP123MB2587.GBRP123.PROD.OUTLOOK.COM>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.114.13.247]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/KuHN8GVKu_e6UmNTLABeiQWrNwQ>
Subject: Re: [tcpm] WGLC for draft-ietf-tcpm-converters-08
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Jun 2019 09:27:08 -0000

Re-,

Focusing on this part of the review. 

Please see inline. 

Cheers,
Med

> -----Message d'origine-----
> De : tcpm [mailto:tcpm-bounces@ietf.org] De la part de
> philip.eardley@bt.com
> Envoyé : jeudi 27 juin 2019 17:58
> À : Michael.Scharf@hs-esslingen.de; tcpm@ietf.org
> Cc : tcpm-chairs@ietf.org
> Objet : Re: [tcpm] WGLC for draft-ietf-tcpm-converters-08
> 
> I support this document. Thanks to the authors for the nice work.
> 
> 
> --------------
> Suggested clarifications - significant:-
> 
> I think it would be great if Section 3 was expanded into a "protocol
> model" https://tools.ietf.org/html/rfc4101 in particular to expand on

[Med] Section 3 is purposely edited "to quickly grasp the essence of" the convert protocol. It focuses on the main design rationale that is use one single SYN to supply data to a converter. That supplied data is unambiguously distinguished by means of TLVs and location within the payload.  

> <<   2. What messages are being transmitted and what do they mean?>> -
> figures show the basic msg exchanges (info, connect, extended, supported,
> cookie and error)

[Med] There is a risk to be redundant with Section 4 (4.2.2, in particular) + discuss messages that are not defined yet. We may consider adding figures to section 4, though. 

> <<   3. What are the important, but unobvious, features of the protocol?>>
> eg use of assigned port# ; use of first bytes of bytestream ;etc.

[Med] Again, there is a risk to be redundant here. Will think about this further. 

> 
> I think you could distinguish more carefully between: the initiator of the
> TCP convert protocol and the other 'legacy' end point versus the end
> device downstream on a broadband line and the server upstream in the
> internet. The language of the doc basically assumes that a "Client"
> fulfils both the first roles and a "Server" fulfils both the last roles,
> but this needs not always be the case. I realised this reading Section
> 4.2.8, but I suspect it's true in many other places.

[Med] I agree with the comment. 

The assumption are as follows:
* The default communication direction is assumed to be from a host (Client role) to a remote host (Server role): denoted as "outgoing"
* A host (which is used to be a client for outgoing connections) may accept incoming connections because it embeds an application server. We called that "client" too for simplification reasons. 

Point taken, we will need to figure out how to make this better. 

> 
>