Re: [tcpm] Seeking WG opinions on ACKing ACKs with good cause (was: Possible error in accurate-ecn)

Martin Duke <martin.h.duke@gmail.com> Tue, 16 March 2021 19:11 UTC

Return-Path: <martin.h.duke@gmail.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 923A03A0A38 for <tcpm@ietfa.amsl.com>; Tue, 16 Mar 2021 12:11:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9efDbyKZgcsn for <tcpm@ietfa.amsl.com>; Tue, 16 Mar 2021 12:11:22 -0700 (PDT)
Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3FE4C3A0A3B for <tcpm@ietf.org>; Tue, 16 Mar 2021 12:11:22 -0700 (PDT)
Received: by mail-il1-x132.google.com with SMTP id d5so13755769iln.6 for <tcpm@ietf.org>; Tue, 16 Mar 2021 12:11:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F//WEso1KPdb6HpBmjM2TaV4HRLMVddbw5+QEdkLt7A=; b=Wr9Y6NMJTfn0rv4bfWd1jp0KdS8pqhi7X0CU0SocakxTKtRwJ6RHNlUyOWxM107Qtp aB2vT3LXjgdq+ZFg2JfOVvTu6KwSOR0+f/TiIywYC1zko8yRYcAEoZpovlciP7ghcs2u 3AK5d6SPvTwA9naTpw5LJg5PMhzMBWbHOra4PKUBY0kp32/eeu1NvX/YApZ4PlH6Szs1 ReEGelHbdPPQ4hmhHzh8wS2pSpug6uZCLoaRqGAxP7tqF+6R3QLZrKx+bIRKZkEzJFU/ C32mG+AJzOzcKgEdC7ZB6sLiF4MfNPwSlVGBVrjPJGQYnyH54gtsuRGVPuIqhDiO/aX0 raNQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F//WEso1KPdb6HpBmjM2TaV4HRLMVddbw5+QEdkLt7A=; b=oTzwmIFrqqVibFucRcJfYn69OlSKxqVLarkguScs1fUAfzzDvNaaYxPSz10iEIgA6d /2fX7yFkll9/H8ge1isZG12Ql5NTN0jyP/wu7ZJf0Iq9tEnlm7m2l8kIvQSKn75Yqb+l rA8Tsqimkuw5Lh/g4eetdc/uxOgzXPQEwIqah3H9vLo5RqVGlj0fZPxJJGpQAf370rua jkw75VV9AR8JFX3PIwkl3hLROtHo/0+QQLQ9LhUcbX7YAczYIN9lMEHTrVUAaU+XwEVM b9O0VAt1J+GFEoKzt/KEq2G90mgpDXn+Lorm35TfEyoM9mwKO9Fvnyu44D4WluwXQ514 DO/w==
X-Gm-Message-State: AOAM532S/PNHks7tDo8A+uCvEIDdTeYkIHwd0oTNbB4u6UYL9Nb8SnxT QB1cNztAZrzoa7Wm6pmnW/tBtYF7GqMgsX3GBs0=
X-Google-Smtp-Source: ABdhPJyxoL8wSl81VPUmaFQQG5MzmVOrzr1dWMMsu8i9c5MWzpGmpzrfodFpVB0umJsesVBwiOlJe2BDnyf4DF730Ss=
X-Received: by 2002:a92:c541:: with SMTP id a1mr4818556ilj.249.1615921881605; Tue, 16 Mar 2021 12:11:21 -0700 (PDT)
MIME-Version: 1.0
References: <47df9b8b-515e-d40d-3473-599b0a3e3876@bobbriscoe.net> <6031BE2B-4D33-426F-BA17-DDF15CF821DE@kuehlewind.net> <060c8bd8-d64b-3e46-7874-742e35e6d114@bobbriscoe.net> <221e58f3-ada0-c880-db72-d98af84fedb8@gmx.at> <bd6ab65d-ccd5-9fa9-58be-6d9fea4af870@bobbriscoe.net> <CAAK044QgF4pz5Wamnxkobthou5ac4_LBxh8=nBYWyOxQUtcW-Q@mail.gmail.com> <8151fdef-ae78-80f3-adfc-d40db878ac8e@gmx.at> <CAAK044RhdAYexcGRj_XDkdY_o6JqB0DDo1X0H2AeFkRcsb0i4A@mail.gmail.com> <48c5910d-5340-acd6-8fd9-fff1b7758310@bobbriscoe.net> <CAM4esxTiw7_es60DDK2E1wa3-c1nUD2W_Rf7Fhw5u0qJ0bFQpg@mail.gmail.com> <8275e3ff-24af-7f0c-d251-867673503741@gmx.at> <631a3f3d-52e1-68c0-8b5f-ce41b30d2e7f@bobbriscoe.net>
In-Reply-To: <631a3f3d-52e1-68c0-8b5f-ce41b30d2e7f@bobbriscoe.net>
From: Martin Duke <martin.h.duke@gmail.com>
Date: Tue, 16 Mar 2021 12:11:10 -0700
Message-ID: <CAM4esxQDp9jbsA=ycMVRKwYmZgaKwgzB4DRi6-KAV9P1+QubXQ@mail.gmail.com>
To: Bob Briscoe <ietf@bobbriscoe.net>
Cc: "Scheffenegger, Richard" <rs.ietf@gmx.at>, tcpm IETF list <tcpm@ietf.org>, Mirja Kuehlewind <ietf@kuehlewind.net>, Yoshifumi Nishada <nishida@sfc.wide.ad.jp>
Content-Type: multipart/alternative; boundary="000000000000bcec3305bdac2176"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/LEyIToAb_Ov0vjWaLCeIb2G78ns>
Subject: Re: [tcpm] Seeking WG opinions on ACKing ACKs with good cause (was: Possible error in accurate-ecn)
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Mar 2021 19:11:24 -0000

Hi Bob,

On Mon, Mar 15, 2021 at 3:57 PM Bob Briscoe <ietf@bobbriscoe.net> wrote:

> [BB] I think Martin is not disagreeing with your assessment. He was just
> pointing out that the knock-on effects of ACKing pure ACKs originally
> stems from allowing pure ACKs to be ECN capable in the first place. He's
> not saying that's bad. Just it's the root cause of the new phenomenon
> we're seeing here.
>

Yep


> [BB] I was going to say roughly the same as Richard in response to
> Martin here.
>
> Just because some apparent DupACKs with an increased CE count are not
> DupACKs, does not imply that a true DupACK cannot have increase CE count.
>
> That's why we need other tests, like lack of SACK when negotiated, or
> timestamp evidence.
>
>
> Bob
>

Absolutely: by the same token, a window update could also be a genuine
duplicate ACK, but TCP uses a heuristic.

If people are uncomfortable with the heuristic, we could eliminate it by
saying.
- pure counter updates are not duplicate acks, as an extension to the 5681
definition, and
- A receiver that gets both an OOO packet (which might be CE marked) and
one or more CE-marked ACKs must send *two* acks; one that updates the
counter and one that does not. The one that does not is unambiguously a
duplicate ack.

I don't think this is necessary, but it would resolve the problem.