[tcpm] Intdir early review of draft-ietf-tcpm-accurate-ecn-30

Joseph Touch via Datatracker <noreply@ietf.org> Fri, 30 August 2024 15:09 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: tcpm@ietf.org
Delivered-To: tcpm@ietfa.amsl.com
Received: from [10.244.2.118] (unknown [104.131.183.230]) by ietfa.amsl.com (Postfix) with ESMTP id 47DFCC14F5F4; Fri, 30 Aug 2024 08:09:22 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Joseph Touch via Datatracker <noreply@ietf.org>
To: int-dir@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.23.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <172503056189.309399.18089424881706751837@dt-datatracker-68b7b78cf9-q8rsp>
Date: Fri, 30 Aug 2024 08:09:21 -0700
Message-ID-Hash: ZT6BSL3WBLOR6ZEJAHZT5IJZ4VLZ7JSN
X-Message-ID-Hash: ZT6BSL3WBLOR6ZEJAHZT5IJZ4VLZ7JSN
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-tcpm.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-tcpm-accurate-ecn.all@ietf.org, tcpm@ietf.org
X-Mailman-Version: 3.3.9rc4
Reply-To: Joseph Touch <touch@strayalpha.com>
Subject: [tcpm] Intdir early review of draft-ietf-tcpm-accurate-ecn-30
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/Pz4INzRhpNWQgiZnypyAXuYNphE>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Owner: <mailto:tcpm-owner@ietf.org>
List-Post: <mailto:tcpm@ietf.org>
List-Subscribe: <mailto:tcpm-join@ietf.org>
List-Unsubscribe: <mailto:tcpm-leave@ietf.org>

Reviewer: Joseph Touch
Review result: Ready with Issues

>From an INTAREA perspective, this document has no concerns.

However, viewed from a transport perspective, the document has one key concern
- the use of two TCP code points. Information expressed in TCP options should
occur inside the option payload, not be encoded indirectly in code points. The
variants desired in Table 5 can easily be differentiated using a single bit of
the first counter indicated. There's no good reason to consume two TCP code
points for this optimization.

Additionally and somewhat less significantly, it is nonsensical to assign
non-adjacent code points, again as this unnecessarily breaks up the TCP code
point space for use by other future assignments (e.g., were there to be a
legitimate need for a range of code points). Frankly, see no good reason why
this mechanism should not use code points in order of availability, e.g., 80
(and, with GREAT hesitation, 81 if warranted).