Re: [tcpm] Please review 793bis!

<mohamed.boucadair@orange.com> Mon, 29 July 2019 09:35 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5AB411200F8 for <tcpm@ietfa.amsl.com>; Mon, 29 Jul 2019 02:35:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3gr7ZJbkr0Dx for <tcpm@ietfa.amsl.com>; Mon, 29 Jul 2019 02:35:33 -0700 (PDT)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.66.41]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 21717120018 for <tcpm@ietf.org>; Mon, 29 Jul 2019 02:35:33 -0700 (PDT)
Received: from opfedar03.francetelecom.fr (unknown [xx.xx.xx.5]) by opfedar27.francetelecom.fr (ESMTP service) with ESMTP id 45xvgR28W2z35XS; Mon, 29 Jul 2019 11:35:31 +0200 (CEST)
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.20]) by opfedar03.francetelecom.fr (ESMTP service) with ESMTP id 45xvgR148yzCqkj; Mon, 29 Jul 2019 11:35:31 +0200 (CEST)
Received: from OPEXCAUBMA2.corporate.adroot.infra.ftgroup ([fe80::e878:bd0:c89e:5b42]) by OPEXCAUBMA1.corporate.adroot.infra.ftgroup ([::1]) with mapi id 14.03.0439.000; Mon, 29 Jul 2019 11:35:30 +0200
From: <mohamed.boucadair@orange.com>
To: "Scharf, Michael" <Michael.Scharf@hs-esslingen.de>, "tcpm@ietf.org" <tcpm@ietf.org>
Thread-Topic: Please review 793bis!
Thread-Index: AdVDxBaWqg1nKqsFQCmaSvOixpeJnwCKuSXw
Date: Mon, 29 Jul 2019 09:35:30 +0000
Message-ID: <787AE7BB302AE849A7480A190F8B9330312EA496@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
References: <6EC6417807D9754DA64F3087E2E2E03E2D3CB17C@rznt8114.rznt.rzdir.fht-esslingen.de>
In-Reply-To: <6EC6417807D9754DA64F3087E2E2E03E2D3CB17C@rznt8114.rznt.rzdir.fht-esslingen.de>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.114.13.245]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/RK1ixEOA6HaP7TGmtNLXGI2RBdM>
Subject: Re: [tcpm] Please review 793bis!
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jul 2019 09:35:35 -0000

Hi all, 

Please find below some very minor comments to enhance the readability of the document:

* Consider moving Section 2.1 to be listed under Section 3.

* Rsrvd - Reserved:  s/Reserved/Unassigned. This is to be aligned with https://tools.ietf.org/html/rfc8126#section-6 (reserved in 8126 has a special meaning: "Reserved:  Not assigned and not available for assignment.")

* Add a pointer to the "TCP Header Flags" registry: https://www.iana.org/assignments/tcp-header-flags/tcp-header-flags.xhtml  

* Add an IANA action to update the above registry to include all TCP flags, not only those in 3168. Also, the description text in that page should be reworked, IMHO. Unassigned bits should also be indicated as such in that page.

I would like to have those referenced in that page rather than having documents requiring access to these bits to duplicate the effort: see for example  RFC8519 (look for "reserved" and "flags" in Page 33).

* Position titles right after figure #, e.g., 

OLD:

                               TCP Header Format

             Note that one tick mark represents one bit position.

                                 Figure 1

NEW:

             Note that one tick mark represents one bit position.

                                 Figure 1: TCP Header Format


* Introduce some notations used in the document (and a pointer to Appendix B), e.g., 

     The window size MUST be treated as an unsigned number, or else
     large window sizes will appear like negative windows and TCP will
     now work (MUST-1) .  It is RECOMMENDED that implementations will
              ^^^^^^^^
     reserve 32-bit fields for the send and receive window sizes in the
     connection record and do all window computations with 32 bits (REC-
                                                                    ^^^^
     1 ).

Idem for SHLD-, etc. 

* Section 3.1

OLD:

     The checksum also covers a pseudo header conceptually prefixed to
     the TCP header.  The pseudo header is 96 bits for IPv4 and 320 bits
     for IPv6.  For IPv4, this pseudo header contains the Source
     Address, the Destination Address, the Protocol, and TCP length.

NEW:
     The checksum also covers a pseudo header conceptually prefixed to
     the TCP header.  The pseudo header is 96 bits for IPv4 and 320 bits
     for IPv6.  For IPv4, this pseudo header contains the Source
     Address, the Destination Address, the Protocol (PTCL), and TCP length.
                                                    ^^^^^^ 

* Section 3.1: Add missing figure legend, e.g., 

                   +--------+--------+--------+--------+
                   |           Source Address          |
                   +--------+--------+--------+--------+
                   |         Destination Address       |
                   +--------+--------+--------+--------+
                   |  zero  |  PTCL  |    TCP Length   |
                   +--------+--------+--------+--------+

* Section 3.3:

OLD: 
 The synchronization requires each side to send it's own initial

NEW:
 The synchronization requires each side to send its own initial
 
Cheers,
Med

> -----Message d'origine-----
> De : tcpm [mailto:tcpm-bounces@ietf.org] De la part de Scharf, Michael
> Envoyé : vendredi 26 juillet 2019 17:17
> À : tcpm@ietf.org
> Objet : [tcpm] Please review 793bis!
> 
> Hi all,
> 
> As discussed at IETF 105, we need reviews of draft-ietf-tcpm-rfc793bis in
> order to complete this important TCPM milestone. The draft can be found
> at:
> 
> https://tools.ietf.org/html/draft-ietf-tcpm-rfc793bis-13
> 
> If you care about TCP (after all you have decided to subscribe the TCPM
> list for some reason, no?), please try to find some cycles and please have
> a look at this document.
> 
> Thanks
> 
> Michael
> 
> _______________________________________________
> tcpm mailing list
> tcpm@ietf.org
> https://www.ietf.org/mailman/listinfo/tcpm