From nobody Sun Jan 30 17:14:42 2022 Return-Path: X-Original-To: tcpm@ietfa.amsl.com Delivered-To: tcpm@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D4E2F3A152C; Sun, 30 Jan 2022 17:14:28 -0800 (PST) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -1.318 X-Spam-Level: X-Spam-Status: No, score=-1.318 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=strayalpha.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EXKkpOaexDTR; Sun, 30 Jan 2022 17:14:24 -0800 (PST) Received: from server217-1.web-hosting.com (server217-1.web-hosting.com [198.54.114.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1D60F3A1529; Sun, 30 Jan 2022 17:14:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=strayalpha.com; s=default; h=To:References:Message-Id:Cc:Date:In-Reply-To: From:Subject:Mime-Version:Content-Type:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q2IXGbgWp9C8jZ/1dXCY/uOLKYhtDAGGafNHnOfADpM=; b=oxkjTpyRuluD9gxsWFkLjkI+KI I9EB0jiGgysho7RRRm2WV7gplo3U6vDr9TNazaqzkzo4PJF632y0WO3IP8iisQhnGqhf1m5X06+ff 20IMqftg+lKczD19ZP9opZ5mr5plCVDlNL4Rwa4E3m87qydewbpbEeRk9r2p5P5kJF8m3xePdHZj1 PNG/Q8D8McxJFbGqUis67s8SZm5tbjCdtb0Se+WX6JGpvV1ZDI0pyjQNmTf4mrfyWtD5yVyBSr7NF 0/dCyKFLAIQmcY+TBpoCRtsrAptf83ZJCcNf1fc2jpYURZ2K3vkfPoubyoyNyZdB6UYo5u3pWE1/t 1y6ZT1Lg==; Received: from cpe-172-114-237-88.socal.res.rr.com ([172.114.237.88]:60347 helo=smtpclient.apple) by server217.web-hosting.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nELGp-00A8lY-Jk; Sun, 30 Jan 2022 20:14:20 -0500 Content-Type: multipart/alternative; boundary="Apple-Mail=_981D9F2C-6E0D-474C-8770-30809434E07A" Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) From: "touch@strayalpha.com" In-Reply-To: <164358152867.17369.12451192921874290368@ietfa.amsl.com> Date: Sun, 30 Jan 2022 17:14:12 -0800 Cc: gen-art@ietf.org, Last Call , tcpm IETF list , draft-ietf-tcpm-ao-test-vectors.all@ietf.org Message-Id: <6BD05086-0E6C-48D9-BAD3-FB2BC398F19A@strayalpha.com> References: <164358152867.17369.12451192921874290368@ietfa.amsl.com> To: Peter Yee X-Mailer: Apple Mail (2.3693.40.0.1.81) X-OutGoing-Spam-Status: No, score=-0.5 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server217.web-hosting.com X-AntiAbuse: Original Domain - ietf.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - strayalpha.com X-Get-Message-Sender-Via: server217.web-hosting.com: authenticated_id: touch@strayalpha.com X-Authenticated-Sender: server217.web-hosting.com: touch@strayalpha.com X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched Archived-At: Subject: Re: [tcpm] [Last-Call] Genart last call review of draft-ietf-tcpm-ao-test-vectors-05 X-BeenThere: tcpm@ietf.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: TCP Maintenance and Minor Extensions Working Group List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2022 01:14:29 -0000 --Apple-Mail=_981D9F2C-6E0D-474C-8770-30809434E07A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi, Peter, Many thanks for the edit suggestions. All were implemented, though: - reference to RFC 6978 was moved after the word =E2=80=99traversa= l=E2=80=99 for clarity - master_key is capitalized in the same way as RFC5925, i.e., = all lower-case, except when starting a bullet or sentence, where it has an = initial capital=20 An update should appear as -06 very shortly. Joe =E2=80=94 Joe Touch, temporal epistemologist www.strayalpha.com > On Jan 30, 2022, at 2:25 PM, Peter Yee via Datatracker = wrote: >=20 > Reviewer: Peter Yee > Review result: Ready with Nits >=20 > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being processed > by the IESG for the IETF Chair. Please treat these comments just > like any other last call comments. >=20 > For more information, please see the FAQ at >=20 > . >=20 > Document: draft-ietf-tcpm-ao-test-vectors-05 > Reviewer: Peter Yee > Review Date: 2022-01-30 > IETF LC End Date: 2022-02-01 > IESG Telechat date: Not scheduled for a telechat >=20 > Summary: This document supplies test vectors for the MTI = authentication > algorithms used in the TCP Authentication Option. There are a few nits = that > should be corrected prior to publication. I'm not equipped to validate = the test > vectors themselves and did not attempt to do so. [Ready with nits.] >=20 > Major issues: None >=20 > Minor issues: None >=20 > Nits/editorial comments: >=20 > Page 2, Abstract: move this entire section before the "Status of this = Memo" > section, as required by RFC 7322, section 4. >=20 > Page 4, first full paragraph: move "[RFC6978]" after "experimental = extension" > to avoid confusion. >=20 > Page 10, section 5, 1st paragraph: add a period at the end of the = sentence. >=20 > Page 20, section 7, 1st sentence: add a period at the end of the = sentence. >=20 > Page 24, section 8.2: add a comma after "e.g.". >=20 > Page 25, section 8.4, 2nd bullet item: change "to" to "in". >=20 > Page 25, section 8.4, 3rd bullet item: change first "to" to "in". >=20 > Page 25, section 9, 2nd paragraph: between the usage in section 3.1.1 = and here, > choose a consistent case for "master_key". I know, RFC 5926 = (Master_Key) and > RFC 5925 (master_key) are not consistent between themselves. >=20 >=20 >=20 > --=20 > last-call mailing list > last-call@ietf.org > https://www.ietf.org/mailman/listinfo/last-call --Apple-Mail=_981D9F2C-6E0D-474C-8770-30809434E07A Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hi, = Peter,

Many thanks = for the edit suggestions.

All were implemented, though:
= - reference to RFC 6978 was moved after the word = =E2=80=99traversal=E2=80=99 for clarity
- = master_key is capitalized in the same way as RFC5925, i.e., all = lower-case,
except when starting a bullet or = sentence, where it has an initial capital 

An update should appear as -06 very = shortly.

Joe

=E2=80=94
Joe Touch, = temporal epistemologist
www.strayalpha.com

On Jan 30, 2022, at 2:25 PM, Peter Yee via Datatracker <noreply@ietf.org> = wrote:

Reviewer: Peter Yee
Review result: Ready with = Nits

I am the assigned Gen-ART reviewer for = this draft. The General Area
Review Team (Gen-ART) reviews = all IETF documents being processed
by the IESG for the = IETF Chair.  Please treat these comments just
like = any other last call comments.

For more = information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: = draft-ietf-tcpm-ao-test-vectors-05
Reviewer: Peter Yee
Review Date: 2022-01-30
IETF LC End Date: = 2022-02-01
IESG Telechat date: Not scheduled for a = telechat

Summary: This document supplies = test vectors for the MTI authentication
algorithms used in = the TCP Authentication Option. There are a few nits that
should be corrected prior to publication. I'm not equipped to = validate the test
vectors themselves and did not attempt = to do so. [Ready with nits.]

Major issues: = None

Minor issues: None

Nits/editorial comments:

Page 2, = Abstract: move this entire section before the "Status of this Memo"
section, as required by RFC 7322, section 4.

Page 4, first full paragraph: move "[RFC6978]" after = "experimental extension"
to avoid confusion.

Page 10, section 5, 1st paragraph: add a = period at the end of the sentence.

Page 20, = section 7, 1st sentence: add a period at the end of the sentence.

Page 24, section 8.2: add a comma after = "e.g.".

Page 25, section 8.4, 2nd bullet = item: change "to" to "in".

Page 25, section = 8.4, 3rd bullet item: change first "to" to "in".

Page 25, section 9, 2nd paragraph: between the usage in = section 3.1.1 and here,
choose a consistent case for = "master_key". I know, RFC 5926 (Master_Key) and
RFC 5925 = (master_key) are not consistent between themselves.



--
last-call = mailing list
last-call@ietf.org
https://www.ietf.org/mailman/listinfo/last-call

= --Apple-Mail=_981D9F2C-6E0D-474C-8770-30809434E07A--