[tcpm] Re: Secdir review of draft-ietf-tcpm-tpc-ao-algs

Brian Weis <bew.stds@gmail.com> Wed, 30 September 2026 23:05 UTC

Received: from mail-dy2-x0d.google.com (mail-dy2-x0d.google.com [IPv6:2607:f8b0:4864:36::d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx.ietf.org (Postfix) with ESMTPS id ADC0F46 for <tcpm@ietf.org>; Wed, 30 Sep 2026 23:05:57 +0000 (UTC)
Authentication-Results: mx.ietf.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=RWfoUeHM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx.ietf.org: domain of bew.stds@gmail.com designates 2607:f8b0:4864:36::d as permitted sender) smtp.mailfrom=bew.stds@gmail.com
Received: by mail-dy2-x0d.google.com with SMTP id 5a478bee46e88-34c5d196b0bso195120eec.3 for <tcpm@ietf.org>; Wed, 30 Sep 2026 16:05:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790809557; x=1791414357; darn=ietf.org; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:content-type:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vQbqn8ORxKTNZH3VI9w2XhvyOxaqTZvNGCyzq0RdSTY=; b=RWfoUeHM2tl4GcMGYLj4DuzafK77OdVp52ZJ8S1Hjqqql3jHONFA4WxTmsrvsOQcG8 9AgGDd/RX43jO3ith3bqWZKKT5GZg50fQAVfsdHefJIDvgjKJeqE2PF6DLK245XofbJK cP71uXf7TM6MzkmRY1yFVvCywkAedUTpm2uV6EOQqStluh9ik6vf0dAI6ZvaQBzJREQ7 UanHBCVoamTgHo2qScA8Winev6OllhQvUyB2AYZ53wjpaVZVxERYPJpqJQCmAOt626gK iDU3M4KiFGL8n8MKXixl4MtLxk78gbyLQ0rrYgnac+Yoas2jsiVpRRZX+AlZBPvdkqjD VLdw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790809557; x=1791414357; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vQbqn8ORxKTNZH3VI9w2XhvyOxaqTZvNGCyzq0RdSTY=; b=w8zfOR0aqh3GZCNu6pqnjcSiDXBzTSVFIn4q5Bnb7Yyr1xjE5XvuGrA8M3OwMVOegb fTbyu8HImvN5Xo6VB508nTAojr5LvjVyU59ByHWx7BWb4YRjoJ3/OqYSZrXLlxbxYCaa NueUeT/MAWj0dacAO4CvFIv2jEKJmiK9fUmpwuLfcDbCrzfHpvYQtKK9lF+B5oD0+WvE NtFQdLIBxtYEYKHP6yvpCs3gaAc+Crr8rQmrtSPlCZlq2NUcfr6w5esTHq/4mionIim6 1EOh212ewXDW73NMJML2ugkWq9BfJc+UdtBqhlt9zawE3STIyW92EEf+YnuZQyyzCd7m FskA==
X-Forwarded-Encrypted: i=1; AKwUvByIDDW9F4C7vp3w10sn0VBRsBSd4+2MtV7CCjYhbcA2gZJE5Xnujrnwb6vFdMawH3upYUrI@ietf.org
X-Gm-Message-State: AFq9FYK03tUH+AlEe7IV+892J2imzm1uqjYP40YFIrNwitpBeJZP1+fA kSXFF9Ev2Fo6LxnDd6olhEOU+G7jEolzBHj+4DpsYfW29ZLcd8w7jfr8e/tyTA==
X-Gm-Gg: AYBFou0dRMomiBvbE+XJjAwvIbEQR/zWRATljGMloGJlArHWAFahzf2JA2AYtvgKsI0 yk1fHFvdia33V6efYxbmVVyJmED3vZtpFk7RR60o6fUECikIqaA2LJh3di9mraqn0lknq3zla3q I+80ii3hUVdZMRYzj+F4ySURUTe64Eb98nZbP1wXtK98A6IePqeSFlee5fbwXW0OmHorX1p8u8t MPzdwvyt4mQMh2fY29u5zg8MnGIfaqzezGaTDH0KAQbReRuoFcFgY63pvBZpTKtLmrtP26Wfzgp IJqoFUDBY71cQlK1UFQwEYxKwJrD7N+GqcQZXhHQkjAyeLf5I2vA59bhp8+ytV48CeiS2SHkcDu WvGuvEavNd1mI62kNxg/ebTNBHgiJTjknfd1BWlM961Sk3lQ2EoGqEAQf9hPEThm4/9IkdioXJt sOZAn+CAwyzmUBgaE/YDalXQnUREpAb9xf6oHCYfhIwWXt6iD7pno38zLhX+qgDamfwGTcJhnMu AIWb/DOW5D9M4dDKEJajD0KOGi8
X-Received: by 2002:a05:7300:b54b:b0:343:fdea:9a0 with SMTP id 5a478bee46e88-34cdd9900bfmr5939634eec.2.1790809556409; Wed, 30 Sep 2026 16:05:56 -0700 (PDT)
Received: from smtpclient.apple ([2600:381:4811:ec71:fcbc:d478:7fdd:cb09]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-34db315e877sm1707938eec.9.2026.09.30.16.05.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 16:05:55 -0700 (PDT)
Content-Type: multipart/alternative; boundary="Apple-Mail-D579D105-85E0-40EB-BA29-7A7EFBD6BEAB"
Content-Transfer-Encoding: 7bit
From: Brian Weis <bew.stds@gmail.com>
Mime-Version: 1.0 (1.0)
Date: Wed, 30 Sep 2026 16:05:44 -0700
Message-Id: <8456439D-7E40-4FBB-A0E4-55AA35E00471@gmail.com>
References: <DM4PR84MB2310554B1A7859C60E8FCEF2F48B2@DM4PR84MB2310.NAMPRD84.PROD.OUTLOOK.COM>
In-Reply-To: <DM4PR84MB2310554B1A7859C60E8FCEF2F48B2@DM4PR84MB2310.NAMPRD84.PROD.OUTLOOK.COM>
To: Ron Bonica <ronald.bonica@hpe.com>
X-Mailer: iPhone Mail (23G83)
X-Spamd-Bar: /
Message-ID-Hash: U67PUMZNFAOSTI35L4SXU6BHUZGBZEYF
X-Message-ID-Hash: U67PUMZNFAOSTI35L4SXU6BHUZGBZEYF
X-MailFrom: bew.stds@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-tcpm.ietf.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-tcpm-tcp-ao-algs.all@ietf.org, "tcpm@ietf.org Extensions" <tcpm@ietf.org>
X-Mailman-Version: 3.3.10
Precedence: list
Subject: [tcpm] Re: Secdir review of draft-ietf-tcpm-tpc-ao-algs
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/TjYNkNcS1bjRycxUaLRfxjZ4ZCE>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Owner: <mailto:tcpm-owner@ietf.org>
List-Post: <mailto:tcpm@ietf.org>
List-Subscribe: <mailto:tcpm-join@ietf.org>
List-Unsubscribe: <mailto:tcpm-leave@ietf.org>

Hi Ron,

Looks good to me. Thanks for clarifying the counter; I would just note that it seems to be acting like more of a code point worthy of a registry if that were possible, but that’s just a thought. 

Regarding the last comment, I was just puzzled what it meant! I agree no additional string is needed for HMAC-SHA256. What does the text refer to, or should it be removed?

Thanks,
Brian

On Sep 30, 2026, at 12:26 PM, Bonica, Ron <ronald.bonica@hpe.com> wrote:


Brian,

Thanks for yet another review.

I think that the attached .txt and .diff files address your first three comments. Please tell me if they do.

I would like to push back on your final comment, because HMAC-SHA256 doesn’t required an initialization string. (Am I missing something?)

— 
Pax et bonum
Ron Bonica


From: Brian Weis <bew.stds@gmail.com>
Date: Friday, September 25, 2026 at 6:12 PM
To: Bonica, Ron <ronald.bonica@hpe.com>
Cc: draft-ietf-tcpm-tcp-ao-algs.all@ietf.org <draft-ietf-tcpm-tcp-ao-algs.all@ietf.org>; tcpm@ietf.org Extensions <tcpm@ietf.org>
Subject: Re: Secdir review of draft-ietf-tcpm-tpc-ao-algs

Hi Ron

The current version looks pretty good to me. I have some small suggestions/comments;

Section 3.1.1. Strictly speaking, RFC 5869 only specifies HKDF, not HKDF-SHA256. Probably this should be something like “ HKDF is specified in [RFC5869].” and then add a bullet under “where” to say
* The Hash function is SHA-256 as defined in [RFC6234].

Section 3.1.2. The arguments for the KMAC256 definition originally defined in NIST SP 800-185 differ from the ones in NIST SP 8700-56Cr2, which is renamed to be KMAC#. Since you’re now referencing the KMAC# definition it would be very helpful to point out which definition of KMAC256 that you’re using. Otherwise it will be very confusing for implementers looking at the inputs to KMAC256 as defined in  [NIST.SP.800-185] to understand why the salt is being treated as a key. Maybe add something like, “It should be noted that this document conforms to the KMAC# variant of KMAC as defined in  Section 4.1 of [DOI.10.6028_NIST.SP.800-56Cr2], which re-defines the KMAC inputs of [NIST.SP.800-185].”

Section 3.1.2. In the interests of clarity it would be good to specify the purpose of the “counter” input to KMAC256. It is defined as the value “1" without any reason to increment it. I imagine you are planning for future updates to the protocol, and if so that’s would be a fine rationale worth saying.

Section 3.2.2 mentions a "default customization string for KMAC256-KDF, which I can’t seem to find mentioned in KMAC256-KDF. Can you clarify this?


Thanks,

Brian


On Sep 21, 2026, at 5:54 AM, Bonica, Ron <ronald.bonica@hpe.com> wrote:

Hi Brian,

Does the current version of https://urldefense.com/v3/__https://datatracker.ietf.org/doc/draft-ietf-tcpm-tcp-ao-algs/__;!!NpxR!jQlsAA0p6nhw32QBhSoG0lIijiQpF5GVYBAZnDQzf0gzgl5yHJvi1w34hCwftg1cnHLXAng1hejzPLOx6A$" rel="nofollow"> Cryptographic Algorithms That Produce 128-bit MACs For Use With TCP-AO address the concerns that you raised in your SECDIR review?

— 
Pax et bonum
Ron Bonica


<draft-ietf-tcpm-tcp-ao-algs-08.diff.html>
<draft-ietf-tcpm-tcp-ao-algs-08.txt>