IETF Logo Mail Archive

Re: [tcpm] Genart last call review of draft-ietf-tcpm-ao-test-vectors-05

Lars Eggert <lars@eggert.org> Tue, 01 March 2022 15:44 UTC

Return-Path: <lars@eggert.org>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B40143A0BC6; Tue, 1 Mar 2022 07:44:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.226
X-Spam-Level: *
X-Spam-Status: No, score=1.226 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JX4YbfOpi3nO; Tue, 1 Mar 2022 07:44:15 -0800 (PST)
Received: from mail.eggert.org (mail.eggert.org [IPv6:2a00:ac00:4000:400:211:32ff:fe22:186f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3BD5C3A0BD1; Tue, 1 Mar 2022 07:44:15 -0800 (PST)
Received: from smtpclient.apple (unknown [195.65.18.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id AA2431D30B9; Tue, 1 Mar 2022 17:44:03 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1646149444; bh=vsANfY/3Uef2LHTuuIklczi+MRgWBTGlmI/NcOhH51g=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=lAkNdKU10lHudzsE4SvoThVwSYy8Uo3UwEHdKrkPDDPtjIHzs/sN1yjqoOFn+x7Gr dlLQFjxpxwg9lpN1S1YiHdoLWP1llT4JRDr3jkgocjkQIgqnImBr4FSyDiRxtfODKf hfu8tbB7r96quwF4c6fLeu1tNQ/09nKiq8p7ibrY=
Content-Type: multipart/signed; boundary="Apple-Mail=_CAC7BBA5-AF3F-41D0-ADAB-57E70BB81D90"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.60.0.1.1\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <164358152867.17369.12451192921874290368@ietfa.amsl.com>
Date: Tue, 01 Mar 2022 16:44:02 +0100
Cc: gen-art@ietf.org, last-call@ietf.org, tcpm@ietf.org, draft-ietf-tcpm-ao-test-vectors.all@ietf.org
Message-Id: <30CAB138-13A6-4029-8DA7-9ED310A3B257@eggert.org>
References: <164358152867.17369.12451192921874290368@ietfa.amsl.com>
To: Peter Yee <peter@akayla.com>
X-MailScanner-ID: AA2431D30B9.A348A
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/WUa9UCa_IjEH3cRikwb9OfOVs4Q>
Subject: Re: [tcpm] Genart last call review of draft-ietf-tcpm-ao-test-vectors-05
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Mar 2022 15:44:20 -0000

Peter, thank you for your review. I have entered a No Objection ballot for this document.

Lars


> On 2022-1-30, at 23:25, Peter Yee via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Peter Yee
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-tcpm-ao-test-vectors-05
> Reviewer: Peter Yee
> Review Date: 2022-01-30
> IETF LC End Date: 2022-02-01
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: This document supplies test vectors for the MTI authentication
> algorithms used in the TCP Authentication Option. There are a few nits that
> should be corrected prior to publication. I'm not equipped to validate the test
> vectors themselves and did not attempt to do so. [Ready with nits.]
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments:
> 
> Page 2, Abstract: move this entire section before the "Status of this Memo"
> section, as required by RFC 7322, section 4.
> 
> Page 4, first full paragraph: move "[RFC6978]" after "experimental extension"
> to avoid confusion.
> 
> Page 10, section 5, 1st paragraph: add a period at the end of the sentence.
> 
> Page 20, section 7, 1st sentence: add a period at the end of the sentence.
> 
> Page 24, section 8.2: add a comma after "e.g.".
> 
> Page 25, section 8.4, 2nd bullet item: change "to" to "in".
> 
> Page 25, section 8.4, 3rd bullet item: change first "to" to "in".
> 
> Page 25, section 9, 2nd paragraph: between the usage in section 3.1.1 and here,
> choose a consistent case for "master_key". I know, RFC 5926 (Master_Key) and
> RFC 5925 (master_key) are not consistent between themselves.
> 
> 
> 
> _______________________________________________
> tcpm mailing list
> tcpm@ietf.org
> https://www.ietf.org/mailman/listinfo/tcpm

v2.23.0 | Report a Bug | By Email