Re: [tcpm] Erik Kline's No Objection on draft-ietf-tcpm-ao-test-vectors-08: (with COMMENT)

["[e-mail]" <[e-mail]>]

Hi, Erik,

Thanks for your review. Comments below; please let me know if you concur or have a better suggestion forward.

Thanks,

Joe

> On Mar 2, 2022, at 2:26 PM, Erik Kline via Datatracker <[e-mail]> wrote:
> 
> Erik Kline has entered the following ballot position for
> draft-ietf-tcpm-ao-test-vectors-08: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
> for more information about how to handle DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-tcpm-ao-test-vectors/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> [S3.1, etc.; nit]
> 
> * I'm somewhat surprised that IETF standard documentation prefixes aren't
>  being used (192.0.2.0/24, 2001:db8::/32).
> 
>  I do not feel strongly enough, however, to suggest that the examples need
>  to be rewritten and the values recomputed.

We considered this, but test vectors are an odd case. Although they are for “documentation” purposes, the IP addresses given need to be those that can be used in an actual test environment. That’s why we used private addresses rather than documentation addresses.

> [S3.1.4; nit]
> 
> * If these examples are typical of BGP sessions and GSTM (RFC 5082) is
>  a typical BGP deployment practice I would have expected to see the IPv6
>  hop limit in use also be 255, rather than 64.
> 
>  Again: no need to redo all the examples.

Hopcount is not included in the calculation so would not affect the overall results. We can change them if needed, but it would affect only parts of the examples that are not being tested or validated.

--