Re: [tcpm] another review of draft-ietf-tcpm-tcpsecure[-10]

"Anantha Ramaiah (ananth)" <ananth@cisco.com> Sun, 28 September 2008 21:07 UTC

Return-Path: <tcpm-bounces@ietf.org>
X-Original-To: tcpm-archive@megatron.ietf.org
Delivered-To: ietfarch-tcpm-archive@core3.amsl.com
Received: from [127.0.0.1] (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id B9B463A698E; Sun, 28 Sep 2008 14:07:48 -0700 (PDT)
X-Original-To: tcpm@core3.amsl.com
Delivered-To: tcpm@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 58FF93A698E for <tcpm@core3.amsl.com>; Sun, 28 Sep 2008 14:07:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.849
X-Spam-Level:
X-Spam-Status: No, score=-4.849 tagged_above=-999 required=5 tests=[AWL=0.850, BAYES_00=-2.599, J_CHICKENPOX_33=0.6, MIME_8BIT_HEADER=0.3, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pE-unNoslsRf for <tcpm@core3.amsl.com>; Sun, 28 Sep 2008 14:07:46 -0700 (PDT)
Received: from sj-iport-6.cisco.com (sj-iport-6.cisco.com [171.71.176.117]) by core3.amsl.com (Postfix) with ESMTP id 6AEFA3A6989 for <tcpm@ietf.org>; Sun, 28 Sep 2008 14:07:46 -0700 (PDT)
X-IronPort-AV: E=Sophos;i="4.33,327,1220227200"; d="scan'208";a="164579142"
Received: from sj-dkim-4.cisco.com ([171.71.179.196]) by sj-iport-6.cisco.com with ESMTP; 28 Sep 2008 21:08:03 +0000
Received: from sj-core-2.cisco.com (sj-core-2.cisco.com [171.71.177.254]) by sj-dkim-4.cisco.com (8.12.11/8.12.11) with ESMTP id m8SL83gY023222; Sun, 28 Sep 2008 14:08:03 -0700
Received: from xbh-sjc-221.amer.cisco.com (xbh-sjc-221.cisco.com [128.107.191.63]) by sj-core-2.cisco.com (8.13.8/8.13.8) with ESMTP id m8SL83Ph026236; Sun, 28 Sep 2008 21:08:03 GMT
Received: from xmb-sjc-21c.amer.cisco.com ([171.70.151.176]) by xbh-sjc-221.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Sun, 28 Sep 2008 14:08:02 -0700
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Date: Sun, 28 Sep 2008 14:08:01 -0700
Message-ID: <0C53DCFB700D144284A584F54711EC5805DF435A@xmb-sjc-21c.amer.cisco.com>
In-Reply-To: <200808140650.IAA05627@TR-Sys.de>
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Thread-Topic: another review of draft-ietf-tcpm-tcpsecure[-10]
Thread-Index: Acj92i4QWt95JBWwQLeg6Sqf0q8UTQjzKXsA
References: <200808140650.IAA05627@TR-Sys.de>
From: "Anantha Ramaiah (ananth)" <ananth@cisco.com>
To: =?iso-8859-1?Q?Alfred_H=CEnes?= <ah@tr-sys.de>, <rrs@cisco.com>, "Mitesh Dalal (mdalal)" <mdalal@cisco.com>
X-OriginalArrivalTime: 28 Sep 2008 21:08:02.0965 (UTC) FILETIME=[4B642450:01C921AE]
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; l=3915; t=1222636083; x=1223500083; c=relaxed/simple; s=sjdkim4002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=ananth@cisco.com; z=From:=20=22Anantha=20Ramaiah=20(ananth)=22=20<ananth@cisco .com> |Subject:=20RE=3A=20another=20review=20of=20draft-ietf-tcpm -tcpsecure[-10] |Sender:=20; bh=mT7BXMFbiHrIdyyNQ7Kf7veE+quylKGxHF69EX0KGcs=; b=JXk7PMyZaNFSi10ZrJb0PNtssqPPKWoWEPC2aNne+basAzeNgR3DcWDXcQ GAzjTHhygDJjbURI+xTyelW6+NMc3NiwlrECgPCpitSz7237hjqGSy9lj/BN oMJ638fpep;
Authentication-Results: sj-dkim-4; header.From=ananth@cisco.com; dkim=pass ( sig from cisco.com/sjdkim4002 verified; );
Cc: tcpm@ietf.org
Subject: Re: [tcpm] another review of draft-ietf-tcpm-tcpsecure[-10]
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://www.ietf.org/mailman/private/tcpm>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: tcpm-bounces@ietf.org
Errors-To: tcpm-bounces@ietf.org

Alfred,
    I am compiling all the changes including the last call comments into the next revision. I will incorporate all your comments below. 

In particular, regarding your observation of mentioning what the document is doing, I agree that we should mention that it "updates 793". I am hoping that nobody has any objection to this point. 

-Anantha
-----Original Message-----
From: Alfred HÎnes [mailto:ah@tr-sys.de] 
Sent: Wednesday, August 13, 2008 11:50 PM
To: Anantha Ramaiah (ananth); rrs@cisco.com; Mitesh Dalal (mdalal)
Cc: tcpm@ietf.org
Subject: another review of draft-ietf-tcpm-tcpsecure[-10]

Hello all,
I have once more tried to closely read the latest (-10) version of the 'tcpsecure' draft, and only found a very small number of nits -- see below.


Furthermore, I once more advocate making clear in the document metadata what the document does, by adding to the heading:

    Updates: 793 (if approved)

Doing so will definitely help guide implementers to quickly locate the document once published as an RFC.
By WG consensus, the document is intended for Standards Track, and Sections 3.2, 4.2, and 5.2 clearly state that they update RFC 793; thus, this should be made visible at the metadata level as well.


Nits (in recently added / modified text):

(1)
At the very end of section 1, please change:

              [...] please refer to draft [RFC4953]
                                   ^^^^^^          ^
   to:
              [...] please refer to RFC 4953 [RFC4953].
                                   ^^^^^^^^^          ^
   or:
              [...] please refer to [RFC4953].
                                   ^         ^

(2)
In the first paragraph of section 5.2, please correct two punctuation flaws (missing period, and extraneous apostrophe).
I also have included two minor stylistic improvement below:

                                                    [...].  It needs to
|  be noted that RFC 793 page 72 (fifth check) says : "If the ACK is a
                        ^                          ^^
   duplicate (SEG.ACK < SND.UNA), it can be ignored.  If the ACK
   acknowledges something not yet sent (SEG.ACK > SND.NXT) then send an
|  ACK, drop the segment, and return" This mitigation makes the ACK
                                    ^^
   check more stringent since any ACK < SND.UNA wouldn't be accepted,
|  instead only ACK's which are in the range ((SND.UNA - MAX.SND.WND) <=
                   ^^
   SEG.ACK <= SND.NXT) gets through.
---
                                                    [...].  It needs to
|  be noted that RFC 793 on page 72 (fifth check) says: "If the ACK is a
                        ^^^^                          ^
   duplicate (SEG.ACK < SND.UNA), it can be ignored.  If the ACK
   acknowledges something not yet sent (SEG.ACK > SND.NXT) then send an
|  ACK, drop the segment, and return."  This mitigation makes the ACK
                                    ^^^^
   check more stringent since any ACK < SND.UNA wouldn't be accepted,
|  instead only ACKs which are in the range ((SND.UNA - MAX.SND.WND) <=
                   ^^
   SEG.ACK <= SND.NXT) gets through.

Note: The quotation comprises multiple sentences; hence the "rational
      quotation" rule of the RFC-Ed does not apply.


IMO, otherwise the draft is ready to go, and because of the importance of the topic, it should now be advanced quickly!

Kind regards,
  Alfred HÎnes.

-- 

+------------------------+--------------------------------------------+
| TR-Sys Alfred Hoenes   |  Alfred Hoenes   Dipl.-Math., Dipl.-Phys.  |
| Gerlinger Strasse 12   |  Phone: (+49)7156/9635-0, Fax: -18         |
| D-71254  Ditzingen     |  E-Mail:  ah@TR-Sys.de                     |
+------------------------+--------------------------------------------+

_______________________________________________
tcpm mailing list
tcpm@ietf.org
https://www.ietf.org/mailman/listinfo/tcpm