Re: [tcpm] draft-ietf-tcpm-rack-02 - TLP algorithm question

Neal Cardwell <ncardwell@google.com> Tue, 21 March 2017 23:51 UTC

Return-Path: <ncardwell@google.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 252DB1300BC for <tcpm@ietfa.amsl.com>; Tue, 21 Mar 2017 16:51:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LjQA2DAHduX0 for <tcpm@ietfa.amsl.com>; Tue, 21 Mar 2017 16:51:47 -0700 (PDT)
Received: from mail-oi0-x22f.google.com (mail-oi0-x22f.google.com [IPv6:2607:f8b0:4003:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3DF72129496 for <tcpm@ietf.org>; Tue, 21 Mar 2017 16:51:38 -0700 (PDT)
Received: by mail-oi0-x22f.google.com with SMTP id r203so40014321oib.3 for <tcpm@ietf.org>; Tue, 21 Mar 2017 16:51:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1WO/47LMsOizdVCc1KzllO/2trciIojzsKNlZBmYyzc=; b=oVBc3yDSlwsS5azR+MiDW3u1JkD/F706gFSgVUNh4EtqEOPcsEvIFZ3FNLo0Cr6nrL G1lNUceuGaBITCqpn85H/5fCulNcJ10yoQbxrqmqtKcFSR9x8d+d0p8Kq687b7giLitY AouLIqmY6SxST7Ve4QrrDjyCCfeWiR70LBKGmzkGdmtioDSyurjclRtGOS9d3pVGJq0+ aEh0fP0wtt6ZZ2AGIvRWl74n+IIEgGMINlc03YchHjKVNz795XuBwOVX1MLmZ9gY6XV8 t99Ojx7JJYyHVto2z4hu0cP8s4KSucygBqkLhOA25IjQXVGsOY0zDSGHDsGB0+MnOPOH A2vg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1WO/47LMsOizdVCc1KzllO/2trciIojzsKNlZBmYyzc=; b=TT6QcnIKafy4aD+JC4UmYB4jebzXlPmjedR6yY4GugFd8qTbShaOAlpkVRSjKuNUYG GDvLuES3jpVe/tonoUuJN5lOE7/SpU95Pq++/AnT3Rt10XfoVUpHIeDfISFRqP61GD+O 5LBRzbzjFZLocRcU1n0OAOe9INy+gkvtwRd3AeBidA0IsdTJW3ljsVm9/H4auybMzZRx LzhgT/UDoFL21xbirjkvzVJY82pvU2RKbuPSreLeAjqqdjNHfi4Tp1Lfvv1ti4PidNB1 eRRsxI0VYJhgU26wi6Y3/dIfJvWGipGg4FGsZW5lURb5nr5iBpVNhYRYiZ7dT/eB5q0T ph7A==
X-Gm-Message-State: AFeK/H3YEyIvAcudLBw9k3eyAjlZl3Z5fU/N7L3IhHiMSrre1Z+auQeN3DL/fPA/HSYf6szo2hPde7ZCuIfoxcb+
X-Received: by 10.202.93.10 with SMTP id r10mr10320184oib.7.1490140297506; Tue, 21 Mar 2017 16:51:37 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.202.170.74 with HTTP; Tue, 21 Mar 2017 16:51:07 -0700 (PDT)
In-Reply-To: <38ddb175-86b2-46af-ac56-cd2b9aee5e3a@weinrank.net>
References: <38ddb175-86b2-46af-ac56-cd2b9aee5e3a@weinrank.net>
From: Neal Cardwell <ncardwell@google.com>
Date: Tue, 21 Mar 2017 19:51:07 -0400
Message-ID: <CADVnQynU-3P9ePa8iNC8_umDoxvk+-tGxOwGKs0=P6-5L8AWvQ@mail.gmail.com>
To: Felix Weinrank <ietf@weinrank.net>
Cc: "tcpm@ietf.org Extensions" <tcpm@ietf.org>, Yuchung Cheng <ycheng@google.com>, Nandita Dukkipati <nanditad@google.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/e8VRoYLjT2YQa_oT9s34k0EjDeI>
Subject: Re: [tcpm] draft-ietf-tcpm-rack-02 - TLP algorithm question
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Mar 2017 23:51:49 -0000

On Tue, Mar 21, 2017 at 6:53 PM, Felix Weinrank <ietf@weinrank.net> wrote:
>
> Hey all,
>
> I have a question regarding the TLP algorithm in draft-ietf-tcpm-rack-02
> In 6.2.1.  Phase 1: Scheduling a loss probe:
...
>        PTO = max(10ms, PTO)
>        PTO = max(RTO, PTO)
>
> The last line "PTO = max(RTO, PTO)" makes no sense to me.
> It has been changed from "min" to "max" in the 02 version.

Yes, I believe you are right that a bug crept in between
draft-ietf-tcpm-rack-01 and draft-ietf-tcpm-rack-02. I have reverted
to:

   PTO = min(RTO, PTO)

 in our internal copy, so this fix should be reflected in the next
version of the RACK Internet Draft.

Thanks for catching that!

neal