Re: [tcpm] [Technical Errata Reported] RFC7413 (5373)

Yuchung Cheng <ycheng@google.com> Thu, 31 May 2018 14:36 UTC

Return-Path: <ycheng@google.com>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 389E112EC3B for <tcpm@ietfa.amsl.com>; Thu, 31 May 2018 07:36:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.51
X-Spam-Level:
X-Spam-Status: No, score=-17.51 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GVVKRPuyFnEt for <tcpm@ietfa.amsl.com>; Thu, 31 May 2018 07:36:25 -0700 (PDT)
Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E06B412EC88 for <tcpm@ietf.org>; Thu, 31 May 2018 07:36:24 -0700 (PDT)
Received: by mail-it0-x241.google.com with SMTP id d10-v6so27880063itj.1 for <tcpm@ietf.org>; Thu, 31 May 2018 07:36:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=DqzhMxcS6mbLOwNCxgqEhnRZc5960S9my+37+Setnwo=; b=Ywz87LgcOtoppxTwV9iqcpiv2hko1vSPZfhc16A2pFDY7mY54xKTT14CMFCeBom12C 04rp/FvKs60vGLQV0bdFXuiEBLnUIpKZsX0HZks4amKg0z24jyJ8/F1y998iR9f0ju52 qCBTnH18i1ZZJUJ6bIDLsSFwXKKGkykmZ2+IIRYqE0lTnk+JwdkOWn9v8S8pa9MyDQuC R/nORCP18Xv7fYIMU84+ebC2vz92gbAhGi3xQJYX5wmV8sChZMgqRk+52B+aWHy/zbfH L0ljifcE2ZSkao4v97eYkRZ1RTmAYzhUSTbgK4QTVhZHmFg+k5dm6lylxUlxtc2iQ6XJ BiCQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DqzhMxcS6mbLOwNCxgqEhnRZc5960S9my+37+Setnwo=; b=MKZGnmh3TLPyRU/sdeH+6r0B3MX+2q6UGwJfXbXCUi9Qmu+yXljsJrHQXNpfCxcHA5 kvL4YfqI3GN66Hg5Wi3yQWs0Iif7XpqCFqIcbD9TzI2ZZIqfZwSLttcokKNPgcOKdIT4 W/JrY9mHPDhxipPoGooIwhKDB94dkhnrfGA84eg9OJTuseJVOxTPr22ix8biHWgRvjvE 9718qyfrSIlp9yJtH44+WTTIpa1+1nJLdDTsGk3gsOaMjtXv6BGWBobmC34g7bWHeRaM HeGZxdfuS2tVrc2YPWaldkb3QGN74oGECvkA4eXcQ+atp5OSEJc8SsckOTNgR8gp0Zj5 IXjA==
X-Gm-Message-State: APt69E34Rs6hnKGqbfm9giLrCoDfnOhuT2fA6Z699vV5FhDY1HvV51Aj PnpDv5RYa3K7btsWN2E0Dxyf5TxgMELfGKyhOVf9Hw==
X-Google-Smtp-Source: ADUXVKKZR/7bCl/blJ+QndjW+kbMXfc7SjyPA7kyhVxDs+jfwbJScCQjbzDfRszQVEeqDBEMHVFzGL/DBsOGzT+WV18=
X-Received: by 2002:a24:17c2:: with SMTP id 185-v6mr186586ith.45.1527777383789; Thu, 31 May 2018 07:36:23 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a6b:6b17:0:0:0:0:0 with HTTP; Thu, 31 May 2018 07:35:42 -0700 (PDT)
In-Reply-To: <20180531142355.B5ED7B825CF@rfc-editor.org>
References: <20180531142355.B5ED7B825CF@rfc-editor.org>
From: Yuchung Cheng <ycheng@google.com>
Date: Thu, 31 May 2018 07:35:42 -0700
Message-ID: <CAK6E8=fBD3LTxJQGs6SzMUYUYS6wtqFH-wnzqJHXPmbtO4dQyw@mail.gmail.com>
To: RFC Errata System <rfc-editor@rfc-editor.org>
Cc: Jerry Chu <hkchu@google.com>, Sivasankar Radhakrishnan <sivasankar@cs.ucsd.edu>, Arvind Jain <arvind@google.com>, Spencer Dawkins <spencerdawkins.ietf@gmail.com>, "Mirja Kuehlewind (IETF)" <ietf@kuehlewind.net>, "SCHARF, Michael (Michael)" <michael.scharf@nokia.com>, Michael Tuexen <tuexen@fh-muenster.de>, Yoshifumi Nishida <nishida@sfc.wide.ad.jp>, vladnc@gmail.com, "tcpm@ietf.org Extensions" <tcpm@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/fq4ZMNOkjN-vhdHIgdYeXdNBbGE>
X-Mailman-Approved-At: Thu, 31 May 2018 08:17:20 -0700
Subject: Re: [tcpm] [Technical Errata Reported] RFC7413 (5373)
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 31 May 2018 14:36:27 -0000

On Thu, May 31, 2018 at 7:23 AM, RFC Errata System
<rfc-editor@rfc-editor.org> wrote:
>
> The following errata report has been submitted for RFC7413,
> "TCP Fast Open".
>
> --------------------------------------
> You may review the report below and at:
> http://www.rfc-editor.org/errata/eid5373
>
> --------------------------------------
> Type: Technical
> Reported by: Vladimir Nicolici <vladnc@gmail.com>
>
> Section: 4.1.3.1.
>
> Original Text
> -------------
>    For any negative responses, the client SHOULD disable Fast Open on
>    the specific path (the source and destination IP addresses and ports)
>    at least temporarily.
>
>
> Corrected Text
> --------------
>    For any negative responses, the client SHOULD disable Fast Open on
>    the specific path (the source and destination IP addresses
>    and the destination port) at least temporarily.
Looks good to me. Thanks for catching this!

>
>
> Notes
> -----
> The original language seems to imply that the cached negative response should only affect connections if they are initiated from the same source port and source IP.
>
> Since the client source port can change for subsequent TCP connections, and it's unlikely that just changing the source port would result in a successful TCP FO connection when a previous connection from a different source port failed, associating the cached negative response with the source port is probably not very useful, and could actually be detrimental to performance and reliability, depending on the implementation.
>
> If the implementation would decide to check the source port when matching negative cached responses to a new connection, it would negatively impact performance when the source port changes, because the implementation wouldn't find a matching negative response in the cache.
>
> Furthermore, if each connection retry is made from a different source port, checking the source port when matching the cached negative responses would make the client unable to connect to the server, until all possible source ports are included in cached negative responses.
>
> This means it's much better not recommending to associate the source port to the cached negative responses, to prevent any confusion and possible implementation issues.
>
> Either that, or add additional clarification, describing exactly how a negative cached response should be matched to a subsequent connection attempt.
>
> Instructions:
> -------------
> This erratum is currently posted as "Reported". If necessary, please
> use "Reply All" to discuss whether it should be verified or
> rejected. When a decision is reached, the verifying party
> can log in to change the status and edit the report, if necessary.
>
> --------------------------------------
> RFC7413 (draft-ietf-tcpm-fastopen-10)
> --------------------------------------
> Title               : TCP Fast Open
> Publication Date    : December 2014
> Author(s)           : Y. Cheng, J. Chu, S. Radhakrishnan, A. Jain
> Category            : EXPERIMENTAL
> Source              : TCP Maintenance and Minor Extensions
> Area                : Transport
> Stream              : IETF
> Verifying Party     : IESG