[tcpm] draft-ietf-tcpm-rtorestart-07

Nicolas Kuhn <nicolas.kuhn@telecom-bretagne.eu> Thu, 07 May 2015 14:59 UTC

Return-Path: <nicolas.kuhn@telecom-bretagne.eu>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DD9421A9115 for <tcpm@ietfa.amsl.com>; Thu, 7 May 2015 07:59:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.149
X-Spam-Level: *
X-Spam-Status: No, score=1.149 tagged_above=-999 required=5 tests=[BAYES_50=0.8, HELO_EQ_FR=0.35, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GmoYyXUHHa9Q for <tcpm@ietfa.amsl.com>; Thu, 7 May 2015 07:59:38 -0700 (PDT)
Received: from zproxy220.enst-bretagne.fr (zproxy220.enst-bretagne.fr [192.108.117.9]) by ietfa.amsl.com (Postfix) with ESMTP id 0BA5D1A912D for <tcpm@ietf.org>; Thu, 7 May 2015 07:59:34 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by zproxy220.enst-bretagne.fr (Postfix) with ESMTP id ADEA130270 for <tcpm@ietf.org>; Thu, 7 May 2015 16:59:32 +0200 (CEST)
Received: from zproxy220.enst-bretagne.fr ([127.0.0.1]) by localhost (zproxy220.enst-bretagne.fr [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id GJd88-LGsU8m for <tcpm@ietf.org>; Thu, 7 May 2015 16:59:32 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1]) by zproxy220.enst-bretagne.fr (Postfix) with ESMTP id 427743026E for <tcpm@ietf.org>; Thu, 7 May 2015 16:59:32 +0200 (CEST)
X-Virus-Scanned: amavisd-new at zproxy220.enst-bretagne.fr
Received: from zproxy220.enst-bretagne.fr ([127.0.0.1]) by localhost (zproxy220.enst-bretagne.fr [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ZzMc3ADTrqKN for <tcpm@ietf.org>; Thu, 7 May 2015 16:59:32 +0200 (CEST)
Received: from [IPv6:2001:660:7301:3728:7029:3b3:d619:ec9b] (passerelle-interne.enst-bretagne.fr [192.108.117.210]) by zproxy220.enst-bretagne.fr (Postfix) with ESMTPSA id 1F23E30270 for <tcpm@ietf.org>; Thu, 7 May 2015 16:59:32 +0200 (CEST)
From: Nicolas Kuhn <nicolas.kuhn@telecom-bretagne.eu>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <882B8BE8-D02D-4E46-90B0-FE9CB2E88BF9@telecom-bretagne.eu>
Date: Thu, 07 May 2015 16:59:32 +0200
To: tcpm@ietf.org
Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\))
X-Mailer: Apple Mail (2.1990.1)
Archived-At: <http://mailarchive.ietf.org/arch/msg/tcpm/o6EutHqD_8qbDAu069R45cVWWj8>
Subject: [tcpm] draft-ietf-tcpm-rtorestart-07
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 May 2015 14:59:40 -0000

Hi all, 

I had a look at this draft-ietf-tcpm-rtorestart-07 draft. 
I have some minor comments on the document. 

#############################################################

- "The RTO Restart (RTOR) mechanism described in this document makes the
   RTO slightly more aggressive when the number of outstanding segments
   is too small for fast retransmit to work, in an attempt to enable
   faster loss recovery for all segments while being robust to
   reordering."

The RTO is not aggressive ; but the retransmission scheme ruled by RTO expirations is. 
I would recommend to rephrase that. 

#############################################################

- “   The RTO Restart (RTOR) mechanism described in this document makes the
   RTO slightly […] highly varying RTTs, e.g. mobile networks."

This whole paragraph comes to early in the document, as the reader has no clear 
idea about what RTOR is actually doing. I propose to add that in a dedicated sub-
section in Section 5.

#############################################################

- “ 3 RTO Restart Overview” -> should it not be “3- RTO Overview and rationale of RTOR “ or something equivalent ?
It is confusing, as you do not actually present RTOR. 

Also, in this section 3:
The first paragraph finishes with “Hence,  in most situations, the time before a retransmission is triggered is equal to "RTO + RTT”.” 
But the example to illustrate it comes after - I think things should moved around to:
1- introduce the classic RTO 
2- explain the rationale of classic RTO
3- example to show that RTO+RTT is common
4- more parameters could affect that (2 outstanding segments; other factors)
5- conclusion on “hence, RTO+RTT is common for application limited traffic"

I would propose to introduce a ToC for this section 3:

3- RTO Overview and rationale of RTOR
  3-1. Experienced RTO is RTO+RTT
  3-2. RTO safety margin
  3-3. Rationale of RTOR: when fast retransmit is not possible

#############################################################

Section 4 : should focus on the description of the algorithm only. 

I would keep 
“ 
This approach makes the RTO more
   aggressive than the standardized approach in [RFC6298] but still
   conforms to the requirement in [RFC6298] that segments must not be
   retransmitted earlier than RTO seconds after their original
   transmission.
"

for the discussion section (at this stage of the reading, the reader still does not know exactly what RTOR is actually doing). 

#############################################################

Section 4: "it will prevent RTOR
   from being more aggressive and potentially causing RTOs instead of
   fast retransmits.”

More aggressive than what ? Has the "four" being experimentally obtained ?
I think more discussion is required on this parameter. 

Regards, 

Nicolas