Re: [tcpm] WGLC for 793bis - Review comments

[Rahul Jadhav <[e-mail]>]

This is an incredibly detailed work, covering protocol,
implementation, and different scenarios aspects. The scenarios/context
provided for "Quiet Time specification" and "Reset handling", were
particularly interesting to note for me. Following are my comments:

Section 3.1: "The window size MUST be treated as an unsigned number,
or else large window sizes will appear like negative windows and TCP
will now work (MUST-1)."
[RJ] It should be "TCP will _not_ work (MUST-1)" ... I guess its a typo (?).

Section 3.5.1: ... an application that has called CLOSE cannot
continue to read data from the connection (MAY-1).
[RJ] shouldn't this be that "an application that has called CLOSE
_can_ continue to read data from the connection (MAY-1)"? ... Again I
suppose it's a typo but want to make sure.

Section 3.5.1: See [18] section 2.17 for discussion.
[RJ] This reference is broken since section 2.17 no more exists.

Section 2.1: ... with each TCP segment sent as an Internet Protocol
(IP) datagram.
[RJ] Even though recommended, it isn't necessary that each TCP segment
be sent as a single IP datagram.

Section 2.1: Anycast applications exist that successfully use TCP
without modifications, though there is some risk of instability due to
changes of lower-layer forwarding behavior.
[RJ] A ref would help.

Small Nits:
Section 3.3: ...likelihood of reuse of ports and sequency numbers after reboots.
[RJ] s/sequency/sequence

Section 3.6.5: ...present IPv6 Node Requiements
[RJ] s/Requiements/Requirements

Best,
Rahul

On Sat, 3 Oct 2020 at 23:59, Scharf, Michael
<[e-mail]> wrote:
>
> Hi all,
>
> This is a friendly reminder. Please have a look at 793bis!
>
> Thanks
>
> Michael
>
>
> > -----Original Message-----
> > From: tcpm <[e-mail]> On Behalf Of Scharf, Michael
> > Sent: Friday, September 18, 2020 2:12 PM
> > To: [e-mail] Extensions <[e-mail]>
> > Subject: [tcpm] WGLC for 793bis - REVIEW NEEDED
> >
> > Dear TCPM contributors,
> >
> > This e-mail starts a working group last call for draft-ietf-tcpm-rfc793bis-18.
> > Information about the document can be found at this link:
> >
> > https://datatracker.ietf.org/doc/draft-ietf-tcpm-rfc793bis/
> >
> > For instance, the current version can be found at
> > https://datatracker.ietf.org/doc/html/draft-ietf-tcpm-rfc793bis-18.
> >
> > When adopting draft-ietf-tcpm-rfc793bis, the TCPM working group
> > consensus was to limit the scope of 793bis to TCP changes that are specified
> > either in standards-track RFCs or in verified errata. Also, the consensus was
> > to focus on the base protocol and exclude mechanisms that can be specified
> > separately (e.g., congestion control). As a result, 793bis should in principle
> > not contain anything new. Nonetheless, we all know that TCP is a complex
> > protocol and even small details of the specification matter a lot.
> >
> > Given that 793bis will obsolete RFC 793, which is one of the most important
> > Internet Standards, this WGLC will run for *four weeks*, i.e., until October
> > 16.
> >
> > Therefore, *your* help is needed: PLEASE review 793bis in the next weeks!
> > The earlier, the better...
> >
> > - Any comments or suggestions are important and highly appreciated. Even if
> > you don't speak up often on the TCPM mailing list, please let us know if you
> > have any feedback.
> >
> > - Even if you read the document without finding any errors or issue, please
> > let us know ("+1").
> >
> > - It is also perfectly fine to look only at a subset of the document, e.g., if you
> > are familiar with specific details of TCP. Partial reviews are welcome, too.
> >
> > - If you own TCP running code, you definitively should have a very close look;
> > this document is supposed to be the new base specification of TCP.
> >
> > RFC 793 lays the ground for all work in TCPM, and 793bis is probably one of
> > the most important deliverables of TCPM. Please help us with completing
> > this milestone.
> >
> > Thanks!
> >
> > Michael Scharf
> > Yoshifumi Nishida
> > Michael Tuexen
> > (TCPM chairs)
> >
> > _______________________________________________
> > tcpm mailing list
> > [e-mail]
> > https://www.ietf.org/mailman/listinfo/tcpm
>
> _______________________________________________
> tcpm mailing list
> [e-mail]
> https://www.ietf.org/mailman/listinfo/tcpm