[tcpm] Review: draft-ietf-tcpm-early-rexmt-01

Alexander Zimmermann <alexander.zimmermann@nets.rwth-aachen.de> Fri, 14 August 2009 10:09 UTC

Return-Path: <alexander.zimmermann@nets.rwth-aachen.de>
X-Original-To: tcpm@core3.amsl.com
Delivered-To: tcpm@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 68AFC3A687D for <tcpm@core3.amsl.com>; Fri, 14 Aug 2009 03:09:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.457
X-Spam-Level:
X-Spam-Status: No, score=-2.457 tagged_above=-999 required=5 tests=[AWL=0.855, BAYES_05=-1.11, HELO_EQ_DE=0.35, HELO_MISMATCH_DE=1.448, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id am9GfKKq9-zP for <tcpm@core3.amsl.com>; Fri, 14 Aug 2009 03:09:37 -0700 (PDT)
Received: from mta-1.ms.rz.rwth-aachen.de (mta-1.ms.rz.RWTH-Aachen.DE [134.130.7.72]) by core3.amsl.com (Postfix) with ESMTP id 523D83A67B5 for <tcpm@ietf.org>; Fri, 14 Aug 2009 03:09:36 -0700 (PDT)
MIME-version: 1.0
Received: from ironport-out-1.rz.rwth-aachen.de ([134.130.5.40]) by mta-1.ms.rz.RWTH-Aachen.de (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008)) with ESMTP id <0KOD00CAH2RM5MG0@mta-1.ms.rz.RWTH-Aachen.de> for tcpm@ietf.org; Fri, 14 Aug 2009 12:06:58 +0200 (CEST)
X-IronPort-AV: E=Sophos; i="4.43,379,1246831200"; d="sig'?scan'208"; a="22492389"
Received: from smarthost-2.ms.rz.rwth-aachen.de (HELO smarthost.rwth-aachen.de) ([134.130.7.90]) by ironport-in-1.rz.rwth-aachen.de with ESMTP; Fri, 14 Aug 2009 12:06:58 +0200
Received: from miami.nets.RWTH-Aachen.DE (miami.nets.RWTH-Aachen.DE [137.226.12.180]) by smarthost.rwth-aachen.de (8.13.8+Sun/8.13.8/1) with ESMTP id n7EA6vbd013239; Fri, 14 Aug 2009 12:06:57 +0200 (CEST)
Message-id: <A63D9429-A09B-42CD-AD4A-BFF7C9D9E768@nets.rwth-aachen.de>
From: Alexander Zimmermann <alexander.zimmermann@nets.rwth-aachen.de>
To: Mark Allman <mallman@icir.org>
Content-type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary=Apple-Mail-18--793204669
Content-transfer-encoding: 7bit
Date: Fri, 14 Aug 2009 12:06:58 +0200
X-Pgp-Agent: GPGMail 1.2.0 (v56)
X-Mailer: Apple Mail (2.936)
Cc: tcpm@ietf.org
Subject: [tcpm] Review: draft-ietf-tcpm-early-rexmt-01
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/tcpm>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Aug 2009 10:09:38 -0000

Hi Mark, hi TCPM

as requested at the last TCPM meeting in Stockholm that we need some  
reviews for Early Retransmit (draft-ietf-tcpm-early-rexmt-01), here  
are some comments from me:

*** Content

* First of all I like the draft. Short and easy. There exist a byte- 
based and a packet-based version. In both cases there is also a SACK  
and a non-SACK version described.

* The "entry point" of the algorithm could be better described. For  
example lets begin paragraph 2 in section 2.1 as follows: When an  
acknowledgment arrives at the sender, the sender ...

* What about RFC4653 - Improving the Robustness of TCP to Non- 
Congestion Events? Is Early Retransmit compatible to RFC4653? At first  
glance I think yes, when we define a priority which algo should alter  
Dupthresh


*** Minor comments

* Section 1, para 3: s/Small windows/Small congestion windows/

* Section 1, last para: Explanation of the difference between Limited  
Transmit and Early Retransmit. Maybe we can put here a pointer to the  
aforementioned case why a CWND can be small. For example (last  
sentence): The "Early Retransmit" mechanism outlined in this document  
covers the case when previously unsent data is not available (case 2)  
for transmission or cannot be transmitted due to an advertised window  
limitation (case 1).

* Check nits: http://tools.ietf.org/idnits?url=http://tools.ietf.org/id/draft-ietf-tcpm-early-rexmt-01.txt 
. Broken references and so on.

*** Misspellings

* Consistent quotation marks: Line 94/95 - s/``Fast Retransmit''/"Fast  
Retransmit"/

* Ref [RFC2018], line 440: s/Acknowledgement/Acknowledgment/g :-)

Alex


//
// Dipl.-Inform. Alexander Zimmermann
// Department of Computer Science, Informatik 4
// RWTH Aachen University
// Ahornstr. 55, 52056 Aachen, Germany
// phone: (49-241) 80-21422, fax: (49-241) 80-22220
// email: zimmermann@cs.rwth-aachen.de
// web: http://www.umic-mesh.net
//