[tcpm] Yangdoctors early review of draft-ietf-tcpm-yang-tcp-06

Ebben Aries via Datatracker <noreply@ietf.org> Mon, 07 March 2022 00:52 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: tcpm@ietf.org
Delivered-To: tcpm@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 7BBDD3A0443; Sun, 6 Mar 2022 16:52:36 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ebben Aries via Datatracker <noreply@ietf.org>
To: yang-doctors@ietf.org
Cc: draft-ietf-tcpm-yang-tcp.all@ietf.org, tcpm@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.46.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <164661435641.9057.1721002349923203081@ietfa.amsl.com>
Reply-To: Ebben Aries <exa@juniper.net>
Date: Sun, 06 Mar 2022 16:52:36 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/tckxrxRDxMf65WxNpASzeE1D2Mo>
Subject: [tcpm] Yangdoctors early review of draft-ietf-tcpm-yang-tcp-06
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2022 00:52:37 -0000

Reviewer: Ebben Aries
Review result: On the Right Track

1 module in this draft:
- ietf-tcp@2022-02-04.yang

YANG compiler errors or warnings (pyang 2.5.2, yanglint 2.0.112, yangson 1.4.13)
- No compiler errors or warnings.  Instance data verified with features

Module ietf-tcp@2022-02-04.yang:
- Overall the module is concise and conforms to the guidelines put forth in
  RFC8409.  Only a few minor nits as well as some comments and questions on
  the draft itself
- L#91 - Is there any reason to put a range that covers the entire uint8
- L#104 - Same as L#91

General comments on the draft/modules:
- The title is "A YANG Model for TCP Configuration" however the intent is to
  cover TCP connection tables and statistics.  While configuration parameters
  are introduced, is it not likely that as the model progresses will encompass
  additional state over time?  I would suggest readjusting wording to
  accomodate that this is not only geared towards configuration of TCP
  parameters (which multiple sections concentrate on) and more to TCP
  configuration, connection tables and state

- Section 3.3 - Tree Diagram.  If you are calling out this section is only for
  the abridged version you may want to include a reference to the full diagram
  in Appendix C

- Appendix B.2 - Use IPv6 addresses from the documentation prefixes defined
  inRFC3849 (draft-ietf-tcpm-ao-test-vectors should be updated accordingly as

- Understood that it is mentioned in the introduction this is a minimal set of
  features but statistics wise, there are currently only aggregate/global TCP
  statistics defined. Has there been any consideration for per-connection
  statistics and additional attributes much like outputs of `ss -tpi`
  (processes, counters, mss, pmtu, congestion ctl alg, etc..)? Or is the
  intent this will be served by a future version or separate
  module/augmentation at a later date?