[tcpm] Feedback on draft-ietf-tcpm-accurate-ecn-14

Ilpo Järvinen <ilpo.jarvinen@cs.helsinki.fi> Thu, 15 April 2021 10:26 UTC

Return-Path: <ilpo.jarvinen@cs.helsinki.fi>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6654F3A1A06 for <tcpm@ietfa.amsl.com>; Thu, 15 Apr 2021 03:26:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cs.helsinki.fi
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bORkh4jolq5L for <tcpm@ietfa.amsl.com>; Thu, 15 Apr 2021 03:26:49 -0700 (PDT)
Received: from script.cs.helsinki.fi (script.cs.helsinki.fi [128.214.11.1]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 167B83A19ED for <tcpm@ietf.org>; Thu, 15 Apr 2021 03:26:48 -0700 (PDT)
X-DKIM: Courier DKIM Filter v0.50+pk-2017-10-25 mail.cs.helsinki.fi Thu, 15 Apr 2021 13:26:23 +0300
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.helsinki.fi; h=date:from:to:cc:subject:message-id:mime-version:content-type; s=dkim20130528; bh=jJiKAJ95M6nD9sqNILnztL9SYLu/Qo2JpLNWBSIFVzU=; b= c2WBA0tbMQyC14PR8s4hfO20smaDXAVGphuwWf7gipJQVJE6fdTrzqrU6N+9P8Fr UNbMY5N69EfLsuxvxJUKFDFxbvQdHZFwKt6nXqJyXlHGDE2OtBhofDXiqfBVyYOg 6qE1dxlixIfLEzWe9/67PfEkmD/klnJtEn0tQA9r4BA=
Received: from whs-18.cs.helsinki.fi (whs-18.cs.helsinki.fi [128.214.166.46]) (TLS: TLSv1/SSLv3,256bits,AES256-GCM-SHA384) by mail.cs.helsinki.fi with ESMTPS; Thu, 15 Apr 2021 13:26:23 +0300 id 00000000005A1C6E.00000000607814CF.0000530F
Date: Thu, 15 Apr 2021 13:26:23 +0300
From: Ilpo Järvinen <ilpo.jarvinen@cs.helsinki.fi>
X-X-Sender: ijjarvin@whs-18.cs.helsinki.fi
To: Bob Briscoe <research@bobbriscoe.net>
cc: tcpm@ietf.org
Message-ID: <alpine.DEB.2.22.394.2104151322120.331634@whs-18.cs.helsinki.fi>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/tklgJQOFZr886eQKH3YlObuJvxQ>
Subject: [tcpm] Feedback on draft-ietf-tcpm-accurate-ecn-14
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2021 10:26:54 -0000

Hi,

I read through the changes since -09. Some recommendations/notes:

- "The server MAY include a test to avoid this case."
  I'd say: "The server MAY implement a filter in ESTABLISHED state
  for ACKs with handshake encoding."
  The problem with the original wording is that "this case" is not
  that obvious (in fact, the previous sentence talked exactly
  opposite thing, that is, interpreting the ACE field normally).

- "For each field, it takes the least significant 24 bits of its
  associated local counter (s.ceb, s.e0b or s.e1b) and subtracts
  them from the counter in the associated field of the incoming
  AccECN Option (respectively ECEB, EE0B, EE1B), to work out the
  minimum positive increment it could apply to s.ceb, s.e0b or
  s.e1b (assuming the field in the option only wrapped at most
  once).".
  When using a heuristic to update the byte counters, "the minimum
  positive increment" is too restricting as the byte counters may
  have to be backtracked after heuristic misguessed which of them
  to increment.
  Also in appendix, there's the now the same assumption that the
  byte counter difference will always be non-negative.

- Paragraph seems to appear twice (only 2 words differ in them):
  "Even though the first bullet is stated as a "SHOULD", it is important
   for a transition to immediately trigger an ACK if at all possible, ..."

- Compatibility with TCP Experiments and Common TCP Options
  Should re-state (again) here how SYN and SYN/ACK data is to be
  treated wrt. the byte counters.


-- 
 i.