[tcpm] Re: Secdir review of draft-ietf-tcpm-tpc-ao-algs

Brian Weis <bew.stds@gmail.com> Fri, 25 September 2026 22:11 UTC

Received: from mail-yx2-x0c.google.com (mail-yx2-x0c.google.com [IPv6:2607:f8b0:4864:41::c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx.ietf.org (Postfix) with ESMTPS id 35DEC44 for <tcpm@ietf.org>; Fri, 25 Sep 2026 22:11:43 +0000 (UTC)
Authentication-Results: mx.ietf.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=WihDSNwN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx.ietf.org: domain of bew.stds@gmail.com designates 2607:f8b0:4864:41::c as permitted sender) smtp.mailfrom=bew.stds@gmail.com
Received: by mail-yx2-x0c.google.com with SMTP id 956f58d0204a3-6741b102537so100539d50.0 for <tcpm@ietf.org>; Fri, 25 Sep 2026 15:11:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790374302; x=1790979102; darn=ietf.org; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=m99ngleFclJ6nJT6wdXHgP5FSNek52UtZWCSWmtVB4g=; b=WihDSNwNE5uBFpgDzAJSFDnhrzcwFb88oCYUYRpZ2BIiuqlvLMYHcgFkGRTW79YLpC yCHp+vsyprPWQVNsDhWCq4re9dTOaFUXm/qTH3PsRr07UyAo5GwMS/MpnmyylzkBz3k/ UZjL5lGnCkhMumDDb+Sg+UZY+XC+yG8wMKiniTgDpdHWoq4/3ivR3q3caU/YzK5CHkrs /JQZ+xauEq3IWHOI0fb7n+Vjk46JYwcd+G2Dr11HYQ+lZjR/aIFxjT3djEHftAI4p4pc 11HnC4+elRmFN+9pHPr2OTfm9vDi1W1td6GqWP2vu3z83hNZezOUrfz9MJk6OU84iLFw wKyw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790374302; x=1790979102; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=m99ngleFclJ6nJT6wdXHgP5FSNek52UtZWCSWmtVB4g=; b=Isg42wyAKsRl58vUJhccFJ+2GlX3mmL6FuZjox8or1gXyPlWGzS5z09eIy2rw/GMC+ jbmx6q4keE8N8RhnDrgqgsXsJt+f/c6quigkpz7AYslaTry5YhxuAA/0BcWY2VF8WenD bvWrqor8kYqIW2ADRy/+XOAXm7XAPIOwTX30DW/91L04pDIv8YIGGcrOwbZNypmy1JKD rNFl4PLNIaz04+Pl9GDZlTzH8U7yFDLVPf10KELEKmrMgNEiAXUHaxsiEpOIvCG2Pa0E 5IWQR9R3eT7i+s4eOBB2PjUi5jKWhxm6vaHzpuXA5qgam9jqWbvixVuOZbbW63b8dckm kZiA==
X-Forwarded-Encrypted: i=1; AKwUvBxUeJ7NpFFYZdEyeV1B1ETchzwZak70WzuqMMp9BBzCBgUM/Gs97lN78vMuC04Z4QLzoOLf@ietf.org
X-Gm-Message-State: AFuF++nRjAc0e4+X+EEEtxg4GNZr7NgnMaV3DmUXnvJmAnT/IbegxXlv vAQ9QVC+epG+jSHG1mF+84sH9qchQcPUXhX3tK/dugZF8NeRJJ+gxBd7
X-Gm-Gg: AYBFou3Qo+eBR/oI4SgII42ijHhu1cRhM1fV8x9Xkc761zWUeqUZ7uIvcW8h+oo27bj CZN76721z18iGLSAOy0h5THxAm3Uy1DUEvR0hR9RznnWbv3Ytsdf6wLu9grAZ2UEY9TAG1ACmOQ 1D+YMhCHMzz2egx2GY4TEMUSlAFfPYMufwIkLik6cJkpO2lG1uGEjJ8Zqjew0q48k2ez8GFUfBw iXJzJG0KEHPHOFyjlNhk3T8xfMLq0Pfs3bKlYibFoYd+Py3YTyXhk3ZBtyOT9DE+MoBSGrN3QJg MCHHaNkX1zjKMKKXuX3ggN7M3SV2HVTj44MFlUA9Adxwt11U8OV8XdIz/rs/3UZHXaQAEoE7aDo 9xFEYRJo3FVuzvI9BxEuppkp4Lfk5beNE6YCHzA5heVylQGb8tIOa194/FdUfX86aEIT+78IVpz Fqty1ddLcFx09QIYUVhrPOQmeEtyEbi6WjLGrSJSmEukVUFYSlUr2POboolOV1NoFKvV+J1g4Pq dbw0Qy3mV8x3kSLFKP1kmvwxw==
X-Received: by 2002:a05:690e:5cb:b0:672:b932:48f6 with SMTP id 956f58d0204a3-672ed2502bemr3584530d50.1.1790374302471; Fri, 25 Sep 2026 15:11:42 -0700 (PDT)
Received: from smtpclient.apple ([2600:1700:65ab:5a00:d87a:5104:6162:5fec]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6740ef87db6sm1517411d50.17.2026.09.25.15.11.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Sep 2026 15:11:42 -0700 (PDT)
From: Brian Weis <bew.stds@gmail.com>
Message-Id: <72B2C9DC-A027-4F98-B8D0-DED8CFCE27CD@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_DC48224E-4826-449F-9806-9AA2DC99ADD4"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\))
Date: Fri, 25 Sep 2026 15:11:30 -0700
In-Reply-To: <DM4PR84MB231050F9B1A11AD1941A7A47F4842@DM4PR84MB2310.NAMPRD84.PROD.OUTLOOK.COM>
To: "Bonica, Ron" <ronald.bonica@hpe.com>
References: <DM4PR84MB231050F9B1A11AD1941A7A47F4842@DM4PR84MB2310.NAMPRD84.PROD.OUTLOOK.COM>
X-Mailer: Apple Mail (2.3826.700.81.1.4)
X-Spamd-Bar: /
Message-ID-Hash: GPPNASLLRNHSDKJE6GH2N5PDVQF44Z2Y
X-Message-ID-Hash: GPPNASLLRNHSDKJE6GH2N5PDVQF44Z2Y
X-MailFrom: bew.stds@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-tcpm.ietf.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "draft-ietf-tcpm-tcp-ao-algs.all@ietf.org" <draft-ietf-tcpm-tcp-ao-algs.all@ietf.org>, "tcpm@ietf.org Extensions" <tcpm@ietf.org>
X-Mailman-Version: 3.3.10
Precedence: list
Subject: [tcpm] Re: Secdir review of draft-ietf-tcpm-tpc-ao-algs
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/wjEQABdTQQ9ZwMxuJML9tXcn7WM>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Owner: <mailto:tcpm-owner@ietf.org>
List-Post: <mailto:tcpm@ietf.org>
List-Subscribe: <mailto:tcpm-join@ietf.org>
List-Unsubscribe: <mailto:tcpm-leave@ietf.org>

Hi Ron

The current version looks pretty good to me. I have some small suggestions/comments;

Section 3.1.1. Strictly speaking, RFC 5869 only specifies HKDF, not HKDF-SHA256. Probably this should be something like “ HKDF is specified in [RFC5869].” and then add a bullet under “where” to say
	* The Hash function is SHA-256 as defined in [RFC6234].

Section 3.1.2. The arguments for the KMAC256 definition originally defined in NIST SP 800-185 differ from the ones in NIST SP 8700-56Cr2, which is renamed to be KMAC#. Since you’re now referencing the KMAC# definition it would be very helpful to point out which definition of KMAC256 that you’re using. Otherwise it will be very confusing for implementers looking at the inputs to KMAC256 as defined in  [NIST.SP.800-185] to understand why the salt is being treated as a key. Maybe add something like, “It should be noted that this document conforms to the KMAC# variant of KMAC as defined in  Section 4.1 of [DOI.10.6028_NIST.SP.800-56Cr2], which re-defines the KMAC inputs of [NIST.SP.800-185].”

Section 3.1.2. In the interests of clarity it would be good to specify the purpose of the “counter” input to KMAC256. It is defined as the value “1" without any reason to increment it. I imagine you are planning for future updates to the protocol, and if so that’s would be a fine rationale worth saying.

Section 3.2.2 mentions a "default customization string for KMAC256-KDF, which I can’t seem to find mentioned in KMAC256-KDF. Can you clarify this?

Thanks,
Brian

> On Sep 21, 2026, at 5:54 AM, Bonica, Ron <ronald.bonica@hpe.com> wrote:
> 
> Hi Brian,
> 
> Does the current version of Cryptographic Algorithms That Produce 128-bit MACs For Use With TCP-AO <https://datatracker.ietf.org/doc/draft-ietf-tcpm-tcp-ao-algs/> address the concerns that you raised in your SECDIR review?
> 
> — 
> Pax et bonum
> Ron Bonica
>