Re: [tcpm] Review (Re: WGLC for draft-ietf-tcpm-rack-08)

[Theresa Enghardt <[e-mail]>]

Dear Yuchung,

Thank you for the reply and for posting a new draft.

I read the current version -09 and find that it has greatly improved 
clarity and readability.

This resolves most of my comments.

Just one reply and a few additional minor comments:

On 2020-07-13 15:06, Yuchung Cheng wrote:

> […] The new
> subsection 'RACK reordering window adaptation explicitly lists the
> rules of 3-dupacks and reordering window.
> When the reordering window is zero, RACK will mark the first unacked
> packet lost on the first DUPACK. The rule is to hold up until the
> third DUPACK (or 3 MSS worth of bytes been sacked).

This helps, thanks.

Reading the new Section 3.3.2, I'm wondering about the following though:

"If the sender has not observed any reordering since the
        connection was established, then the RACK reordering window
        SHOULD be zero in either of the following cases: […]

        1.  After learning that three segments have been delivered out of
            order (e.g. receiving 3 DUPACKs per [RFC5681]); in turn, this
            will cause the RACK loss detection logic to trigger fast
            recovery.

        2.  During fast recovery or RTO recovery."

Does this SHOULD mean that the implementation should set the reordering 
window to 0 under either of the listed conditions?
Because I fail to see how the two listed conditions mean that that "the 
sender has not observed any reordering".
Or SHOULD the sender set the reordering window to 0 if either it hasn't 
observed any reordering, or one of the listed conditions are true.

An alternative (and probably false) way of reading this would be that 
the SHOULD just means that the sender should expect the reordering 
window to be 0.
But it doesn't seem logical to me to use SHOULD in this way.

(This is probably clarified later in the detailed algorithm, but it 
would be nice to have this phrased clearly in this Section as well.)


In Section 3.3.2, I fail to understand or parse the following sentence:
             The RACK reordering window SHOULD leverage that to 
adaptively
             estimate the duration of reordering events, if the receiver 
uses
             Duplicate Selective Acknowledgement (DSACK) [RFC2883].

The RACK reordering window SHOULD leverage what? (If "that" refers to 
the sentence before, SRTT, then the connection to DSACK is not obvious 
to me. So I think it's good to substitute "that" here.)

Nits / Editorial comments:

In Section 2.2 and Section 3.3.2., the numbered list goes "1.", "1.", 
"2.", but should be "1.", "2.", "3.".

In Section 4, list item 2. might have an unnecessary "that":
"[…] timestamp whose granularity that is finer than 1/4 of the minimum 
RTT of the connection."


Best,
Theresa