Re: [tcpm] GF review of draft-ietf-tcpm-rto-consider-08

G Fairhurst <gorry@erg.abdn.ac.uk> Fri, 22 November 2019 04:12 UTC

Return-Path: <gorry@erg.abdn.ac.uk>
X-Original-To: tcpm@ietfa.amsl.com
Delivered-To: tcpm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 30FEC12003F for <tcpm@ietfa.amsl.com>; Thu, 21 Nov 2019 20:12:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w9CrHUblN19W for <tcpm@ietfa.amsl.com>; Thu, 21 Nov 2019 20:12:25 -0800 (PST)
Received: from pegasus.erg.abdn.ac.uk (pegasus.erg.abdn.ac.uk [137.50.19.135]) by ietfa.amsl.com (Postfix) with ESMTP id 050AF120025 for <tcpm@ietf.org>; Thu, 21 Nov 2019 20:12:24 -0800 (PST)
Received: from dhcp-9bdb.meeting.ietf.org (dhcp-9bdb.meeting.ietf.org [31.133.155.219]) by pegasus.erg.abdn.ac.uk (Postfix) with ESMTPSA id 80F7B1B001FC for <tcpm@ietf.org>; Fri, 22 Nov 2019 04:12:08 +0000 (GMT)
Message-ID: <5DD76011.9030701@erg.abdn.ac.uk>
Date: Fri, 22 Nov 2019 12:12:01 +0800
From: G Fairhurst <gorry@erg.abdn.ac.uk>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: tcpm@ietf.org
References: <CACpbDcfKnPzej_NC1TDauABg0k1Je=rJ-qi8AHMxMYQ169q5CQ@mail.gmail.com> <CACpbDceeNbWL-w2S_Z4NUCMCQGujByTLkkRJKH3bj_gGNrW8Bw@mail.gmail.com>
In-Reply-To: <CACpbDceeNbWL-w2S_Z4NUCMCQGujByTLkkRJKH3bj_gGNrW8Bw@mail.gmail.com>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/tcpm/xc3sh9sMPUUR_S1yYPZHk8gYcVQ>
Subject: Re: [tcpm] GF review of draft-ietf-tcpm-rto-consider-08
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tcpm/>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Nov 2019 04:12:27 -0000

I presented slides to motivate more review of RTO-consider, (as an 
invited reviewer providing individual comments), so it seemed useful to 
copy these comments in the TCPM list,
best wishes,

Gorry

---

I read draft-ietf-tcpm-rto-consider-08.

I found this *is* readable.
The basis seems correct to me.
It (mostly) comes to the same “conclusions” as CC Guidelines (an 
individual draft) and this can I think proceed in parallel - I don't see 
that any future CC Guidelines needs to proceed first.
---
(Comment 1)
This sets out to BCP status, which makes me note:
Current text: "The correct way to
view this document is as the default case and these other specifications 
as agreed upon deviations from the default."
- where as the abstract concludes:
Current text: "Within the requirements, implementations have latitude
to define particulars that best address each situation."
- My comment is ... Does this really update existing RFCs?

As also current text:
E.g., a protocol like SCTP (or DCCP) could leverage...

- Is that over-riding the RFCs that define these, or is this intended as 
something more like:
“E.g., a new protocol with a design like SCTP [RFC4960] could leverage”
---
(Comment 2)
Current text: "In steady state the RTO SHOULD be set based on recent
observations of both the FT and the variance of the FT."
- I don’t think these are wrong, but I think the advice of "recent" is 
not very crisp for a BCP - how recent? Can we set any upper bound or 
motivate how we would judge whether a protocol met the "SHOULD"?

---
(Comment 3)
Current text: "FT observations SHOULD be taken regularly ...
The notion of "regularly" SHOULD be defined as at least once
per RTT or as frequently as data is exchanged in cases where that 
happens less frequently than once per RTT."
- To me, this reads as impossible to read RFC2119 text, is this a 
definition or something else? or Designs are REQUIRED to define ... etc.

I hope this actually is intended to be:

I wonder if this proposed text below could be better "FT observations 
SHOULD be taken be at least once
per RTT or as frequently as data is exchanged in cases where that 
happens less frequently than once per RTT."
----
(Comment 4)
Current text: "Retransmissions triggered by the RTO mechanism MUST be 
taken as indications of network congestion and the sending rate adapted 
using a standard mechanism (e.g., TCP collapses the congestion window to 
one segment [RFC5681]).
- Is this the word intended to be /retransmissions/, or a time-out of 
the RTO?
(in CC guidelines this described as a lack of response that needs to be 
handled in this way).
---
(Comment 5)
Current text: "Finally, we note that while allowing implementations to 
be more aggressive may in fact increase the number of needless 
retransmissions"
- Textual NiT: I think it would be wiser to say /could/ rather than 
/may/ to be sure no-one seems readable as potentially permissive.

---