[Teas] RtgDir review: draft-ietf-teas-assoc-corouted-bidir-frr-04

Daniele Ceccarelli <daniele.ceccarelli@ericsson.com> Sat, 28 July 2018 14:28 UTC

Return-Path: <daniele.ceccarelli@ericsson.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D2163130DD7 for <teas@ietfa.amsl.com>; Sat, 28 Jul 2018 07:28:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.309
X-Spam-Level:
X-Spam-Status: No, score=-4.309 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com header.b=f9h4LT0O; dkim=pass (1024-bit key) header.d=ericsson.com header.b=hEJONscd
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PZ1qLX2QUmRc for <teas@ietfa.amsl.com>; Sat, 28 Jul 2018 07:28:19 -0700 (PDT)
Received: from sesbmg23.ericsson.net (sesbmg23.ericsson.net [193.180.251.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F40FD130DE1 for <teas@ietf.org>; Sat, 28 Jul 2018 07:28:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1532788097; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eVl3klIfxuovXF7zOBSzwS5TCdR9umPPWtYNLCra6f0=; b=f9h4LT0OHvgwMrRAKVuj3epYjW7xhsMOfNaz39JHh91jtpJR+AVCc0VbOaQbzCsu JENk6B8L4FmfkKP8ayi2JGQhmBq26aIGyhwCGYxBK4CTvIH5LNhZ0KHWY+c9xkNZ OlkrVKgAPLu6Nyijkxya0Cua9i5p+ZQoIruFgG5O8+Q=;
X-AuditID: c1b4fb25-b05ff70000006cb9-89-5b5c7d81d617
Received: from ESESBMB501.ericsson.se (Unknown_Domain [153.88.183.114]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id DD.A0.27833.18D7C5B5; Sat, 28 Jul 2018 16:28:17 +0200 (CEST)
Received: from ESESSMR505.ericsson.se (153.88.183.127) by ESESBMB501.ericsson.se (153.88.183.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Sat, 28 Jul 2018 16:28:16 +0200
Received: from ESESBMB505.ericsson.se (153.88.183.172) by ESESSMR505.ericsson.se (153.88.183.127) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Sat, 28 Jul 2018 16:28:16 +0200
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB505.ericsson.se (153.88.183.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Sat, 28 Jul 2018 16:28:16 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eVl3klIfxuovXF7zOBSzwS5TCdR9umPPWtYNLCra6f0=; b=hEJONscda+u+bsuNESQ+NKmpIgWjaIpR59VG5vK0vjcpQrHSN4sdV/xlcdyBTuhdcFZ2gdhDt6u1G/PWhp8qf4tWza3HjUycGFSAV0lolRPn1Uj/XJ+J9vHmzW7yzzg+kr9CcAyDRGybcNx/xTxGhIMv5ddS0+LTOKm8cmX96ek=
Received: from HE1PR07MB1675.eurprd07.prod.outlook.com (10.166.124.141) by HE1PR07MB4332.eurprd07.prod.outlook.com (20.176.167.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.5; Sat, 28 Jul 2018 14:28:15 +0000
Received: from HE1PR07MB1675.eurprd07.prod.outlook.com ([fe80::34bd:5cb6:7c10:ef65]) by HE1PR07MB1675.eurprd07.prod.outlook.com ([fe80::34bd:5cb6:7c10:ef65%7]) with mapi id 15.20.1017.010; Sat, 28 Jul 2018 14:28:15 +0000
From: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
To: "<rtg-ads@ietf.org> (rtg-ads@ietf.org)" <rtg-ads@ietf.org>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "TEAS WG (teas@ietf.org)" <teas@ietf.org>, "draft-ietf-teas-assoc-corouted-bidir-frr.all@ietf.org" <draft-ietf-teas-assoc-corouted-bidir-frr.all@ietf.org>
Thread-Topic: RtgDir review: draft-ietf-teas-assoc-corouted-bidir-frr-04
Thread-Index: AdQlm/SWFN83nAOVQmKg2miyrumEwA==
Date: Sat, 28 Jul 2018 14:28:15 +0000
Message-ID: <HE1PR07MB16756BF063D9275ADE82E1E4F0290@HE1PR07MB1675.eurprd07.prod.outlook.com>
Accept-Language: it-IT, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [93.38.67.165]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; HE1PR07MB4332; 6:W/PAnjFZlzTYOFNvJl7MNqZi55t/+sxTcQaRd0C/Jre6kaA5YSJj1gfAYsRdEt1CxNph65/IjYZx7ZdWRMI2n37atYgZhfhA6vCkhWehEoOmsu3x5JmKmWYYYLEpIPRfPUzayKzXSwahLu/o45DLU2UcZdJYE8GkgIXkyRqzy3GJBdqqvB24AewgKNMo+09zkX0EZvFo7ZacPE9rpr4skwuZiKo1J/XQwOO6o839LSmobyFjgzD6NNxf1AllfJtrtnGo5jihLal3y/jwGW82oizIJ/Bnk5YUfjY4Nxwu54gxTrFVKRZDohcFqODj4LW1Xhg5+inyFAD+iHMoDV8xt9TAwGNoHnKJXgdJ9aWMYnflLFVbpXx3D0qBgxiW7qvXMtWGmdH5PQzbkOnemDLJtu4+sldkDUm8CDCRxG9U7saNqKJ2PRGxeW1nx7lZO2Ohf75ReS3w1g4GLwNf3Mtnmg==; 5:DsBXiW3JH0w/ay6AcVtV6vt0xVuqbXGqRodnmsTsKVT2QN7V1f7bw4PV3RaQ3UqggkGKegsmu//7MnpfX5yMUryPebeBGxnVOvr5ev34oNnaoNv7p/MQwsqycnQXlymv9cZ6HGMdsFeEyWtxxfBpWN8zO7CahlkOmcfiTd/wTws=; 7:0OG00x57Eivr1Xj0ZPzcJ8Aeu1M+ERiR3VxrqJNfTXyLvcArKS9o9+juiKNiNs+GC82ccXMF3DC3W+aM3x2Ujv5DvUM0WPEIJDT/3Asxdwk+ptZyGBGdqaIklf6z4EMaUw9kvv4UPNf8dpwskmc4KfmWAgm8e8VROnCk4/mrq8YDKfFPlpqaMuoQxqhQaud37VmFwAPCj+YjlIYZjb5UZGFT6fhFn7X+ZQHOYwRVknXA3ljsCuIE5CAuybVVRMZv
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 6611ced7-e233-4a6e-cc66-08d5f4965b17
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:HE1PR07MB4332;
x-ms-traffictypediagnostic: HE1PR07MB4332:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=daniele.ceccarelli@ericsson.com;
x-microsoft-antispam-prvs: <HE1PR07MB4332009DB94961FE43FB5C6BF0290@HE1PR07MB4332.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(28532068793085)(21748063052155);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:HE1PR07MB4332; BCL:0; PCL:0; RULEID:; SRVR:HE1PR07MB4332;
x-forefront-prvs: 07473990A5
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(396003)(376002)(39860400002)(346002)(189003)(199004)(4326008)(3846002)(790700001)(6436002)(6116002)(68736007)(316002)(25786009)(54906003)(450100002)(97736004)(33656002)(8936002)(81156014)(81166006)(99286004)(74316002)(7736002)(8676002)(606006)(5660300001)(26005)(186003)(486006)(44832011)(105586002)(55016002)(106356001)(476003)(102836004)(6506007)(6306002)(236005)(9686003)(54896002)(66066001)(5250100002)(14454004)(478600001)(14444005)(256004)(2900100001)(86362001)(2906002)(7696005)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR07MB4332; H:HE1PR07MB1675.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: lbqV3jH8PHaqJLMBWZd7yRlzFS415O5RqoXWXwdSchf0qQz/sk0Dr5aio8sZVeCCzoWq6jObJ996xmuPgIO+fguy+yVezY5C7pffTf59ITYMvUK+tfJXBWgA68v3ogRy8xIbE0fTpQrLSlkECII+96e3YiNB91oRNcD0Kt6kCe40a7zquJfLBb+bHbyT0OoTuDMe1Y7nnbT00HeN+OIH6hLxkqEoU0+rTi8aU8ZULoWJqNDig346Scto7Z8V1lPafhW2QSfU0qftAhuXchXNI8ef4I58JVgwZzqRweRHB6+ZRdV14DTtDeSP2uj8b8dqAITOaDjxxaGL2zpOMOIiyk6WHsblFGfbyUGXOUOZXkE=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_HE1PR07MB16756BF063D9275ADE82E1E4F0290HE1PR07MB1675eurp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6611ced7-e233-4a6e-cc66-08d5f4965b17
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2018 14:28:15.1079 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB4332
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHec852zkbLl+n5oNi2EhagjOzaFSYJYR4AYkg0ZnNPKh4bVuS XcgMoSahlloOc7P2JROtVLyUShNbhiVpCzINL5tRLPJDeW3ZtrPCb7/3ff4v/98DL0OKW3mB TG6hhlUVKvMlfCHVkNKtCr96WZG2u9wglGuXpwn5SOMKKTe02mh5xUoPFUPFGY2rRDJKFR7K YvNzS1hVRPRpYU5/m5UuNk4T59eWu/llqPY9oUUCBvBe+NbxhnaxGA8jmLf4cryEYHhg639u +6TQIqGTjQR8d/QTrgOFq0n4cmcccZPbBDyxzPK4J3MImpd9tIhh+PgAWE2JLvTD0aB7F+6K k3jEWWB47bbwxbGwfreL72I/HAcGi57g8jJ463BLUDgUhoZs7rgIK6B50OFmhIOh+tl95GIS B8CkVe9ZDIPx+RjJsT98nf/D4zgEusbNFMfBMK6vdOsDHqChs3wIcYNwWKyrI10OgJPA3HGS y5gR2Jsa+FwmDKzVvYiTyIT2ih5PcR4sdNR7CuJhY7TKI7ENWm7OUp4yEm6MjtHVKEK3SZzj Irg2M0Pr3Iv6wEiDldI5PUi8C9r7PPHtUFs5S3MshYrGe/TmewOiW5C/mlVnFmTviZKxqtwz anVRoayQ1TxFzj/0onM9tAdN2I+YEGaQxEu0L0aRJuYpS9SlBSYEDCnxE4VtpKWJRVnK0gus qihDdS6fVZtQEENJAkSz+ztSxThbqWHzWLaYVf2bEowg0PmxdqzlfBiR/npcb3hkTzKUhSxc 0uSsZlSNefNlW2wRQWctIUtLt6Qtg5bEBTqyfqLJkPIzyuvV4SuO4eOCspoTdunUMeMc5ah8 YJsSIO8aRXLuj4O/PyaeSjf3mQQvS+Jxwk5F5NGHCTOLCio9VihPwt69F+f13aKpyc/XpbSE UucoI8NIlVr5FwJMs5I/AwAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/-9j-O7eNpgzwv07O769UUKsEXRQ>
Subject: [Teas] RtgDir review: draft-ietf-teas-assoc-corouted-bidir-frr-04
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Jul 2018 14:28:23 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir<http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir>

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-teas-assoc-corouted-bidir-frr-04
Reviewer: Daniele Ceccarelli
Review Date: 27/07/2018
IETF LC End Date: date-if-known
Intended Status: Standard track

Summary:


  *   I have some minor concerns about this document that I think should be resolved before publication.

Comments:

  *   The document is very well written and the problem clearly stated (even if called overview 😊 ). The second part is a bit harder to follow but I don’t see how to make the procedure section easier to read.
  *   It is not clear to me why there is an “example” of Extended Association ID in the appendix. RFC 6780 just says it “contains data that is additional information to support unique identification.” But doesn’t describe how it should be filled. Does this mean there is no standard format for it ?

Major Issues:

None

Minor Issues:

  *   Moving the terminology section before the introduction would improve readability, since the terms defined in the terminology section are frequently used in the introduction.
  *   When I read the title of section 3 (overview), I thought “why an overview is needed if there is an introduction?”. Actually the text in that section is very useful but more than an overview I would call it a problem statement (or something like that).
  *   The usage of RFC 2119 (or should we reference RFC 8174 ??) is not congruent all over the document. E.g. section 4.1

  o  The downstream PLR node always initiates the bypass tunnel

      assignment for the forward LSP.  The upstream PLR (forward

      direction LSP MP) node simply reflects the associated bypass

      tunnel assignment for the reverse direction LSP.  The upstream PLR

      node MUST NOT initiate the bypass tunnel assignment.

Nits:

  *   Section1: “(G)Multiprotocol Label Switching (MPLS) Traffic Engineering (TE) Label Switched Paths (LSPs)”. This formatting doesn’t make much sense. In the first instance the brackets are used to say MPLS or GMPLS while in the other ones to define the acronyms.
  *   Section 3.1 there is no need to repeat twice that Bypass tunnel N uses path B-H-I-C and Bypass tunnel S path B-F-G-C. The second time the bracket can be dropped.
  *   Section 4.1.1. -  s/SHOULD trigger the procedure/ SHOULD trigger procedure

BR
Daniele