Re: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03

tom petch <ietfa@btconnect.com> Tue, 05 February 2019 14:47 UTC

Return-Path: <ietfa@btconnect.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E1CE31310C1; Tue, 5 Feb 2019 06:47:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.106
X-Spam-Level:
X-Spam-Status: No, score=0.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.142, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RATWARE_MS_HASH=2.148, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fI5494o30Kxa; Tue, 5 Feb 2019 06:47:32 -0800 (PST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140100.outbound.protection.outlook.com [40.107.14.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7D8F512D4EF; Tue, 5 Feb 2019 06:47:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector1-btconnect-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fOTI4Ok6H/ropjJzNnBN9+uU/7VK1GCuUrFlGws4rdY=; b=gbb+dyfwtddCaLm+vtq4dasdBpdD5TpF06zg6vX+ueBtCzf5RH4Io80DYwp1vq20FNwx0vSBJeGT5rW9yEGB2sz1QrFcLflqVJYVlgUyCJaJVCkZbE076c0UUeMUwIOfJz/2DmyIlILYwSzRbN3bUtRrAtz65H6ghQuyUlX/oGk=
Received: from AM5PR0701MB2321.eurprd07.prod.outlook.com (10.169.152.20) by AM5PR0701MB2692.eurprd07.prod.outlook.com (10.173.93.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.14; Tue, 5 Feb 2019 14:47:28 +0000
Received: from AM5PR0701MB2321.eurprd07.prod.outlook.com ([fe80::9132:55d7:3900:9748]) by AM5PR0701MB2321.eurprd07.prod.outlook.com ([fe80::9132:55d7:3900:9748%4]) with mapi id 15.20.1601.016; Tue, 5 Feb 2019 14:47:28 +0000
From: tom petch <ietfa@btconnect.com>
To: "Tarek Saad (tsaad)" <tsaad@cisco.com>, Jan Lindblad <janl@tail-f.com>
CC: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "draft-ietf-teas-yang-te-types.all@ietf.org" <draft-ietf-teas-yang-te-types.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "teas@ietf.org" <teas@ietf.org>
Thread-Topic: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03
Thread-Index: AQHUsz7lJhclQK6K6kmMA6C0eS0JwA==
Date: Tue, 5 Feb 2019 14:47:28 +0000
Message-ID: <005f01d4bd61$8855f8c0$4001a8c0@gateway.2wire.net>
References: <154090780735.15255.3911131220920609603@ietfa.amsl.com> <973699DE-882E-4531-A7D5-32AFEF4359E7@cisco.com> <6CC3CA10-0768-4C99-9237-30A78E1EC3DA@tail-f.com> <BB36593B-0A4E-4F88-A088-3C35BBCAB902@cisco.com> <39E705F8-EE93-4F16-AD3A-39B2E6FCC37E@tail-f.com> <00bc01d4b33e$c42e4d20$4001a8c0@gateway.2wire.net> <B9068E7A-9D15-4F77-A9BF-3B25092DC1CC@cisco.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-clientproxiedby: LO2P265CA0270.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::18) To AM5PR0701MB2321.eurprd07.prod.outlook.com (2603:10a6:203:d::20)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfa@btconnect.com;
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: Microsoft Outlook Express 6.00.2800.1106
x-originating-ip: [86.139.215.184]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; AM5PR0701MB2692; 6:hCposSWgqYakKgwoOzDS0IHh5xrgjUNOGlvI7eU/FrYf/BV5/IoNlJ6rnXd1Qrv+Ze0p+0W5Ps0mYAFnDUcWVPQQ7bn7+H7apbWOFb0eqvGED2o53tNxIhMFfOd9wxIMzuO5kXemQrP1eAmpcu5gBtJnAqC3KJ6yEFed7ZAWq6ehU3vtIHymT4TJvp8h5d4aryIZpAAHJgfCUVKL9t8iW7vjH9NF91ivbKBciTUHz1OZYwYO2sY4Zq476wCkxknMlDSw904n55OnCGos5IUCr4QpHfGI3qTshVyzgwviAvTxFXrpW+ueZI400bRsGbNPs8X/i1w+dswjZLhR/UV4Dw/piYcCBqRXESWhIizTjSV4COZbecpuxm5IjqCp4IEUd/mNJ3EtDVI/+vLU2p9D7xXvJOu5d0YifHIRT1W7QqMoO0svERNiyGeZmihinozg799ne7iH3s4hwY8j0/JwQg==; 5:nb4rtIrEkNI2To20GGSviT2useCp3sH7iso3+MBs/9lwZVt/iQaQ9conyOsNTqmWxx8d/tjMETl6NEZoU7cTP7qKUuwz2wAvB6EA277MxvgqttHLZE/MC9Fa5PTTpRHcy3RN3LIsxx1JF6qqDDzPO9TWkWe5CjtZzfFO4wjId7nu6eUOZlu6Ou4l5PIsTykNhkWfvu8JbFllS2GHGeh23w==; 7:lOEAXyRPKJXHcWPMi+g78nwxDXsZIYLjB4inSvDHa5A4eqW+4mCECRb3bcP+pTkoTesEbkkdxCmM3DeVkDdmpWsDMZJnmxu5VgAPW+QVjXvLg84k9xD4KUmokW935lJTREcEUnXpujLcA3lAMT/bQw==
x-ms-office365-filtering-correlation-id: 9be1fba9-c57e-4130-0ad7-08d68b78d9c0
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7193020); SRVR:AM5PR0701MB2692;
x-ms-traffictypediagnostic: AM5PR0701MB2692:
x-microsoft-antispam-prvs: <AM5PR0701MB2692910C5F4C7EBAF1D11A8CA26E0@AM5PR0701MB2692.eurprd07.prod.outlook.com>
x-forefront-prvs: 0939529DE2
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(396003)(346002)(376002)(136003)(39860400002)(13464003)(199004)(189003)(3846002)(6116002)(81156014)(8676002)(50226002)(8936002)(86152003)(478600001)(81166006)(14454004)(102836004)(81686011)(81816011)(76176011)(52116002)(33896004)(53546011)(6506007)(386003)(305945005)(25786009)(2906002)(84392002)(61296003)(7736002)(14496001)(93886005)(6436002)(4326008)(4720700003)(229853002)(44736005)(6486002)(256004)(97736004)(6246003)(53936002)(1556002)(66066001)(105586002)(186003)(6512007)(9686003)(44716002)(62236002)(14444005)(71190400001)(71200400001)(54906003)(68736007)(486006)(26005)(316002)(446003)(110136005)(99286004)(86362001)(476003)(106356001)(74416001)(7726001); DIR:OUT; SFP:1102; SCL:1; SRVR:AM5PR0701MB2692; H:AM5PR0701MB2321.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: HG4oxoQELKRHWPb4v4dWJa2ssLshWlR/m9rhkq4OwzGYDm/qmn7L3WXWCT8sbNzEan2AjK0hXz7wHBx7dRNvezXaCnxPXUH4+/nwf9Cp1ToZ0U2AdOq+PD27PKh5lZB2d0a8lrMANUS4iIePP2k3DbnlZQ0mQzhHi8qFqeqPpCm29mwmvN5dLMm4wOuSMvgPa8aicZGdlpL7is4+u4jVb22RtTsQmQ1gtc/lAnUR//pPkmxjah7FguV3An4mwe5LUXfAJB6ngy0huVU4y9kSRntlIYP6XGXb87pM2K4Ty9uSJTcKS/ZOa2m1P5iJs/wofGkh9SxGc39FaBe2eLloYMntwysNfd5MB8BYYvisgy52yiTPWFav8RFQECtYINeiImBoSeBD/O+S33A9BcAb0UKgRcVSEA8W9lElSQxT3mE=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B771C3AA8D9B9A40B9DC4E9CC4EB08E1@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9be1fba9-c57e-4130-0ad7-08d68b78d9c0
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2019 14:47:28.0688 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0701MB2692
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/24WOFQ1A1b5_Q3Vx8Q-vgMM4L54>
Subject: Re: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Feb 2019 14:47:34 -0000

Tarek

Getting there .

You will need to have a reference to the new I-D references in the body
of the I-D else you will get unused references.  One way to do this is
to have a Section 4.1 This module references [RFC3272]. [....  I have
not gone through and seen how many this applies to but imagine it is
most of them.

Also you have G.8031 but G808.  Not wrong, but...

      import ietf-routing-types { prefix "rt-types";
now has the right RFC but the wrong title; should be
Common YANG Data Types for the Routing Area

Tom Petch

----- Original Message -----
From: "Tarek Saad (tsaad)" <tsaad@cisco.com>;
Sent: Thursday, January 31, 2019 2:10 PM

> Hi Tom,
>
> Thank again for your review comments below. We've uploaded version
04/-05 which attempts to address these comments.
> See inline [TS] for resolution.
>
> -----Original Message-----
> From: tom petch <ietfa@btconnect.com>;
> Date: Wednesday, January 23, 2019 at 12:13 PM
> To: Jan Lindblad <janl@tail-f.com>;, Tarek Saad <tsaad@cisco.com>;
> Cc: "yang-doctors@ietf.org"; <yang-doctors@ietf.org>;,
"draft-ietf-teas-yang-te-types.all@ietf.org";
<draft-ietf-teas-yang-te-types.all@ietf.org>;, "ietf@ietf.org";
<ietf@ietf.org>;, "teas@ietf.org"; <teas@ietf.org>;
> Subject: [Teas] not a Yangdoctor review of
draft-ietf-teas-yang-te-types-03
>
>     Tarek
>
>     The YANG modules have lots of references - good - but they are not
in
>     the I-D references - not good.
>
>     My list is
>
>     3272
>     4202
>     4328
>     4657
>     5817
>     6004
>     6205
>     6511
>     7139
>     7308
>     7551
>     7571
>     7579
>     7951
>     G.808
>     G.8031
>     G.8131
>     G.873.1
>
> [TS]: thanks. I've added the missing references and they should show
in the I-D references now.
>
>     s.3.1 I would find more usable if the types were in an order I
could
>     recognise, such as alphabetical
>
> [TS]: OK, I tried an attempt to sort the typedefs alphabetically.
>
>       import ietf-routing-types { prefix "rt-types";
>     reference "RFC6991: Common YANG Data Types";
>     perhaps RFC8294 is intended
>
> [TS]: corrected to RFC8294
>
>     "   defined in ietf-network.yang, to help user to understand ""
>     might benefit from a reference - is this
>     draft-ietf-i2rs-yang-network-topo?
>
> [TS]: added reference RFC8345.
>
>     /"Then index of the label/ "The index of the label /
>
> [TS]: fixed typo.
>
>               container tiebreakers {
>                 description
>                   "The list of tiebreaker criterion to apply
>                    on an equally favored set of paths to pick best";
>                 list tiebreaker {
>                   description
>                   "The list of tiebreaker criterion to apply
>                      on an equally favored set of paths to pick best";
>     One description is perhaps enough
>
> [TS]: removed/updated redundant description.
>
>     uses path-objective-function_config;
>     using _ is not wrong but is discouraged, mixing _ with - in a
label more
>     so
>
> [TS]: OK, we have moved away from using "_" in the naming.
>
>     /This document registers a YANG module/
>     This document registers two YANG modules/
>
> [TS]: fixed typo.
>
>        name: ietf-te-types namespace:
urn:ietf:params:xml:ns:yang:ietf-te-
>        types prefix: ietf-te-types reference: RFC3209
>        name: ietf-te-packet-types namespace:
>        urn:ietf:params:xml:ns:yang:ietf-te-packet-types prefix:
ietf-te-
>        packet-types reference: RFC3209
>
>     Perhaps /3209/XXXX/
>
> [TS]: fixed.
>
> Regards,
> Tarek
>
>     Tom Petch
>
>     ----- Original Message -----
>     From: "Jan Lindblad" <janl@tail-f.com>;
>     To: "Tarek Saad (tsaad)" <tsaad@cisco.com>;
>     Cc: <yang-doctors@ietf.org>;;
>     <draft-ietf-teas-yang-te-types.all@ietf.org>;; <ietf@ietf.org>;;
>     <teas@ietf.org>;
>     Sent: Monday, January 21, 2019 10:10 AM
>     Subject: Re: [Teas] Yangdoctors early review of
>     draft-ietf-teas-yang-te-types-03 (was -01)
>
>
>     >
>
>
>
>