[Teas] Re: Genart last call review of draft-ietf-teas-actn-vn-yang-25

Dhruv Dhody <dhruv.ietf@gmail.com> Tue, 04 June 2024 16:42 UTC

Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6D9A9C169424; Tue, 4 Jun 2024 09:42:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.095
X-Spam-Level:
X-Spam-Status: No, score=-2.095 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gBQHtpHz5ByD; Tue, 4 Jun 2024 09:42:23 -0700 (PDT)
Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 930ACC16941F; Tue, 4 Jun 2024 09:42:23 -0700 (PDT)
Received: by mail-ua1-x934.google.com with SMTP id a1e0cc1a2514c-80acf1bca86so413071241.3; Tue, 04 Jun 2024 09:42:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717519342; x=1718124142; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nqwDeG0Y2ywnXjLelZ+0kTexXRw48xeM1vuiUr4VoGM=; b=XuUs+RvJi6TfDBnvXSA3lUh7qaj7KhFbcBY6L4hQGdKikP4MxS+grhsBR6+/ODZgIe adrWwiYXo01o/j196tPjWD7IVilrKQA0hnJikHkwPqvssBGRPxSupbJKgFf0YzDPEOXv sL06TYuWmzGaMAiLKcEj1w+9uLwQJS6G0lhF2qBNSVM8i+GNrmgTpmr84DTp6bArrDfz I9Zg8JpcnKTuXJVLuXmOEcGL7LJdQ/X6tSsJHFGp3w6/RJxzqY76XbmdSp+6k7g84huj KrIKNWexvJ297X+ZQys+JzKD1jvlJJdAtrfUGEpqJzVb7esPbqEIYOKYsA5hSP/IX51l x/vg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717519342; x=1718124142; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nqwDeG0Y2ywnXjLelZ+0kTexXRw48xeM1vuiUr4VoGM=; b=RqMTurNaH8kDyc58s0XwjCHPdZfAfjHlnRxS7qiiLSYS87orhuJdMBmDaOzoe7BX1j UPXAbBfPj4fXP0egHRQ858+6UDXsrGH3aW5XImBtNTC4I1ekEvw0sZ1XRTq3N1/I/CzE lLQrG5JZqxjfpGbVYgyezwd7Talx4T/OpcQhe9/lZG2pxkaPd9YI6fiQsY+aprgt2LcD NecL+2qLM8YXHkIg0mQbX+RIS5OspUQ4mZPJ3oSqKP7sfhkyu+gogasZl23hfdDMtv1i w+KeddLBZOIYuLghWHCqr7MtWCx3GVGFPPwxwY+swCeiM8RPzr/dkXfExqd07mSPRcAp x3fg==
X-Forwarded-Encrypted: i=1; AJvYcCUFMiVZ2QFa9uWJ+tCqutNMxfDazXb3uEGfXJNEqWp5aFLpIqSCGPlUPgVLgRwAzpffA8gZHjQLbnSUBgPC5N/Qnbzw8hFcrUXqTSeuaxAeLifZOXo5bBwOwKyrGN2u/YfcaZvigZJvuURm/1T1tmrTxpapioFjs0xW9U/W
X-Gm-Message-State: AOJu0YwuFEFRyxu62zZPtZhWdUbRU1f0FXegGJ5jN8LtRmchRc3TYg/H USEert2fgkuf7v+5vsIzmRQ6JePkCQzvjJXrDwsGOjUwf8f6MhWWb3ey13aX3ubzVorLmiYXvhr QAF5N0EqNW98gSOpwOXLH4VgSgik=
X-Google-Smtp-Source: AGHT+IGc5sGkD4VNUyiISQkcT3X+S1PeeRuS/05ZdcMS694R5yaUbE2EQf8fJv+qr53QMEJm3JrX/dU1PZuN/GlZU2A=
X-Received: by 2002:a05:6102:160b:b0:48b:8a5e:a9c4 with SMTP id ada2fe7eead31-48c04aac3fcmr80344137.24.1717519342025; Tue, 04 Jun 2024 09:42:22 -0700 (PDT)
MIME-Version: 1.0
References: <171682964935.25746.14413673081054476548@ietfa.amsl.com>
In-Reply-To: <171682964935.25746.14413673081054476548@ietfa.amsl.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Tue, 04 Jun 2024 17:41:44 +0100
Message-ID: <CAB75xn6rdcbN0BjCO1qhKHtudycjZQgrDZyj+VbnDgBwQsfZjA@mail.gmail.com>
To: Behcet Sarikaya <sarikaya@ieee.org>
Content-Type: multipart/alternative; boundary="00000000000046c61a061a13229d"
Message-ID-Hash: 24XPEE2UVAS3DV7MHZ3IVG34EIRUB6JN
X-Message-ID-Hash: 24XPEE2UVAS3DV7MHZ3IVG34EIRUB6JN
X-MailFrom: dhruv.ietf@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-teas.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: gen-art@ietf.org, draft-ietf-teas-actn-vn-yang.all@ietf.org, last-call@ietf.org, teas@ietf.org
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Teas] Re: Genart last call review of draft-ietf-teas-actn-vn-yang-25
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/8sU2kW_IwKvNsxkEWo7JgDwlbvI>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Owner: <mailto:teas-owner@ietf.org>
List-Post: <mailto:teas@ietf.org>
List-Subscribe: <mailto:teas-join@ietf.org>
List-Unsubscribe: <mailto:teas-leave@ietf.org>

Hi Behcet,

Thanks for your review....

On Mon, May 27, 2024 at 6:07 PM Behcet Sarikaya via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Behcet Sarikaya
> Review result: Ready with Nits
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://wiki.ietf.org/en/group/gen/GenArtFAQ>.
>
> Document: draft-ietf-teas-actn-vn-yang-??
> Reviewer: Behcet Sarikaya
> Review Date: 2024-05-27
> IETF LC End Date: 2024-05-30
> IESG Telechat date: Not scheduled for a telechat
>
> Summary:This document presents a YANG data model generally applicable to
> any
>
> mode of Virtual Network operations. The effort that went into the document
> is appreciated.
>
> The document is well written and understandable.
>
>
> Major issues:None
>
> Minor issues:None
>
> Nits/editorial comments:
> The YANG model has been checked by YANGDOCTORS and the issues found have
> been cleared by Rev. 25.
>
> I list here the nits I found:
>
> Section 1. MDSC <- MSDC (only one occurrence)
>
> Section 1.2
>
> this this document. (only one this is OK)
>
>
> The document has 3 figures with the last one in Section 2.2
>
> afterwards the figure notation is dropped and illustration notation is
> used.
>
> Note. This is just a comment no action needed.
>
>
These have been updated -
https://datatracker.ietf.org/doc/draft-ietf-teas-actn-vn-yang/

Thanks,
Dhruv