Re: [Teas] Yangdoctors early review of draft-ietf-teas-actn-vn-yang-10

tom petch <ietfa@btconnect.com> Fri, 26 February 2021 16:52 UTC

Return-Path: <ietfa@btconnect.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CE9DD3A1205; Fri, 26 Feb 2021 08:52:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3wNEeyK-G9qj; Fri, 26 Feb 2021 08:52:35 -0800 (PST)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140119.outbound.protection.outlook.com [40.107.14.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E5E133A1203; Fri, 26 Feb 2021 08:52:34 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ygy5WM1ZFF2Vk6KTcROGUL1b/fdH1aw9TCWqoWunWK6gyuTT4Dxd8BOTYEXBOB9n7q+xFkNJtzum0QhGKR+qRJzOjqqUP9r6i82hw6Gt3bHPWUniPaFDb02Bqt/gK4dZf60XBC0kDJnakcz2kq9VT1AAqgFAQEjxiW6AgXrgLCQLwy23TvuQwSL7Udpg8zctKj3O/ztr9+EIAgSmwoQPZ08nERKR6DF6s1fv+E47C6rbQa8RK8+De2jJ3jzEdQV/5ykH3XNIR30DgeVx6orMtKcFbrB4dHS8wTH6V1PXMiq3Er6ysgbsixe6IhSqzgWgTmzBBkb1l7rRuVGEa0FQtQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nQ6g8OuEFocicUWlC6MsVCaECwHqDjwWdUHvMM1pOLA=; b=ZHtTWno430gkIN8B+906h18yWzH7Z84n81doDdA/F0PbPS3BOn9Mf07SDCtUiUaljO8UnEY4fNpQ7HZrG3bseyLs4pbQupPYFO16oJ+skHNHVEDHLaLtwvKltSXH3pkrvf3uOrno/4L241vn2GAtAfAuOEeSOw1/84PU3L5l/p+XEL2/EBZKwGjsttr/62sYJIDRK+/ZLq8Ib8y2sh+mfqh2AGwY/tz+26YL2Lq/u6cinmztbNdzTWGdop91BRzzHmpbczqXu+ZvayvYMsrPKrrcIkHRwls78HVraZDwdtYCcD79C+zO4LFzv8md2aegGfoEibcDzl3t+pwko1aqbQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nQ6g8OuEFocicUWlC6MsVCaECwHqDjwWdUHvMM1pOLA=; b=OuelFKMsDFqfvjJVEEOod8lsriJeGYcPXi8s4B3D5Khp3oRKmY80+2sdDOMTxKOkPXCmeC3GPw2SuixDgmHlCshGqWotGbBv8mAbloie0R0tQ9t8WUjj4HiHjrl6rBpHzf+tnVe4i0PqwtHkwWsV/pcUCIJOyMaMj84uUxJxgEk=
Received: from DB7PR07MB5546.eurprd07.prod.outlook.com (2603:10a6:10:73::23) by DBAPR07MB6822.eurprd07.prod.outlook.com (2603:10a6:10:191::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.9; Fri, 26 Feb 2021 16:52:32 +0000
Received: from DB7PR07MB5546.eurprd07.prod.outlook.com ([fe80::e079:baec:373c:824f]) by DB7PR07MB5546.eurprd07.prod.outlook.com ([fe80::e079:baec:373c:824f%7]) with mapi id 15.20.3912.009; Fri, 26 Feb 2021 16:52:31 +0000
From: tom petch <ietfa@btconnect.com>
To: Andy Bierman <andy@yumaworks.com>
CC: Dhruv Dhody <dhruv.ietf@gmail.com>, "draft-ietf-teas-actn-vn-yang.all@ietf.org" <draft-ietf-teas-actn-vn-yang.all@ietf.org>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "TEAS WG (teas@ietf.org)" <teas@ietf.org>
Thread-Topic: [Teas] Yangdoctors early review of draft-ietf-teas-actn-vn-yang-10
Thread-Index: AQHW1udOqtJn9w9suEmwFEi0PtRngaphaeEAgAlTXvaAAD8igIAAEha/
Date: Fri, 26 Feb 2021 16:52:31 +0000
Message-ID: <DB7PR07MB5546DD696D1184814FCFE849A29D9@DB7PR07MB5546.eurprd07.prod.outlook.com>
References: <160847918971.3738.423965928103853275@ietfa.amsl.com> <CAB75xn7KxxgNT++hLcNKbRAVuQ7zMbkGcfZMtB0JJARPYmaR5w@mail.gmail.com> <DB7PR07MB5546393B71017CB63D734A7BA29D9@DB7PR07MB5546.eurprd07.prod.outlook.com>, <CABCOCHQUPtuHHzgSVfZZEEKy7Avt=wA1zma_BQVHMCpRgzQj_A@mail.gmail.com>
In-Reply-To: <CABCOCHQUPtuHHzgSVfZZEEKy7Avt=wA1zma_BQVHMCpRgzQj_A@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: yumaworks.com; dkim=none (message not signed) header.d=none;yumaworks.com; dmarc=none action=none header.from=btconnect.com;
x-originating-ip: [86.146.121.140]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ba357a16-208f-4771-84cd-08d8da76e8c0
x-ms-traffictypediagnostic: DBAPR07MB6822:
x-ms-exchange-minimumurldomainage: ietf.org#9484
x-microsoft-antispam-prvs: <DBAPR07MB6822136AF19F5999C766FED6A29D9@DBAPR07MB6822.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4941;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 1/dZvEiYTC78ZCK5ZzbUb5bDhxJk9DlUnwYXencgq/yg9wHwwZU2DhUqED4xwaXbmjD7/7UBEos92uVkru8qOxFy4BriQBDU/WtenBISfr+frMHpHn+2bOxwmqnKjZh/zd9tWXdIMnQk+sBLXB2EUYktaUgJlUZiiHI+yeIrhpTQMK8eWsf3TfCGD+lFNziw7lVJ7PJqh1/eEHj6Bb1fYCIt1wz7gQrUrWQfd7bt05EJnknWLx+ibmpv4G87eAoTIXUM1XLOrbFSGgWSZMdAtPkHL/W+HIRBY9NZ1bLpzNKZ8Z1sZLnpD8cqIDDlSiA1KyeAT1tlq85nrNuoMNibEgN8mtoWYoPsi68QRAVDZbMQ4E2AxwdzIMjPW6EWbqIrOF/lSX8obBvq2AC4Gix28MQaL58WZXaO8ugn0DVjiUDUZw9VjNFjlKmzeLZbq9YojATmN2HqIREPpQJwNDVFXTxz5uEjuN4T3uUuDyfya7WJ+grv90RERI34FXOXoDAyYfDToqgk5na5/Vo941uma6xghRcwMwmjSG5qwXC3YigHaB/vHDmPQ7Q0B9A8FuFjs6Bv6CLjMdwILwchptNbn8ClJn0tmLffEkcNdS1kZZo=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR07MB5546.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(346002)(136003)(376002)(366004)(39860400002)(2906002)(83380400001)(5660300002)(7696005)(6506007)(8936002)(478600001)(33656002)(8676002)(53546011)(966005)(52536014)(71200400001)(26005)(66556008)(86362001)(4326008)(66476007)(66446008)(76116006)(66946007)(91956017)(54906003)(64756008)(316002)(55016002)(6916009)(186003)(9686003); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?SM3PKVniEu2bHqOx9qim/eyjjSIuzDqDp0nbZVqmFeZ2Ud1zqajyQRvYig?= =?iso-8859-1?Q?t6YGWaNz7oEu6RPfBPfSWKWb/UtFH3ljvEtRllUdc+USsJgGLkYMul3s3l?= =?iso-8859-1?Q?qnzOmny6XYPJO1qNbDpjOT5LV3a+kP+TbDdWdcOzjV3cpKhxZs+26O3nRD?= =?iso-8859-1?Q?RFvNQ1lDjWIOFIMUc5jtg0R2RAS+dbaq7N0JWc7atCRwYQRhlts/kMqMFs?= =?iso-8859-1?Q?nqBymJnED/tHoCQDVWJ/LQqLpC10ZMRQ9r/gI0hZvMwoNkyEDJWqrDLpSq?= =?iso-8859-1?Q?nsv4SmYF5qOd9YNbHchJ97lmqybteDRoR0strRjue6rX5ji35C3LQRX/aW?= =?iso-8859-1?Q?e6qkx9ZL/asUCiF9hIX7598oWDlMFZcZmrNUrHV3Weuwzqah9AIZ7s6fgv?= =?iso-8859-1?Q?kx0O+5CkDIwdDNarIVVZjxDyfKXRWgHXHT0W/LQEuZrvuN7g8wZddK6kSu?= =?iso-8859-1?Q?IE/dXzlBydzOWY6NMvoiSix8Ng30B96ZLO1ik8eJHsJDC+dorEdBaCSNxM?= =?iso-8859-1?Q?xXKFw7dxl4AO8yxziz5huvDnKIBdQcRNUWU/B27cIyAT6Tm7WFSJ0XSWTx?= =?iso-8859-1?Q?ecgCgD7TWFcpEiUpF6KS/1x5W37hOV3w1jdlFaBc9tEd5BwM9D1A4k0HQd?= =?iso-8859-1?Q?q3r7mFJbmY0+hkruRP09DqzSss7cYOXiuQBggiZrmQbvuzHTSLy4VxtNWx?= =?iso-8859-1?Q?Pih/AxKZdI0dzKWeiPqPfgO2UuUxOnaj0hnDFpx1zU+GsHWuuSYkIN99c0?= =?iso-8859-1?Q?qgTuRyILY3K2a4L9bugM+hL78LI0GTFtoWn/KMy3FFKAxz488rWY80OErn?= =?iso-8859-1?Q?oKzdiNL9avZGFGojh33+Z/svT7fp3Q5GXhC5Z33xS/AwHXErYvXToGPF98?= =?iso-8859-1?Q?7BcW2pqtv0u+E3Yz7K7bx8MLLO0kobxxc5NZVCuP/PeQ0XCTZGOItSf9mw?= =?iso-8859-1?Q?aGxaAhxTRqCJoiM2ElNBbp4eKlObDF77savidut0ePagIO8n05kj/YX4W9?= =?iso-8859-1?Q?E1OkOZlEbUeSXNsanz7jQZVfe2ehhNqYOSpCkgMGj3B/GOXvE5ZWB6U16F?= =?iso-8859-1?Q?GLdjj4EeeJVANAv01Dlv93DK4/Rbx6VDWwOy0UOFyyjqWPVOcZZaxcxOiw?= =?iso-8859-1?Q?J0L6JdHDfuztIgEfHHyI4aap+flfiNj5MQY+if6WyI4h1FCZdwPsslOSZY?= =?iso-8859-1?Q?rQPeBVmB28DW6YkxR0Kht2KV3ymgT+0bBrpWdSFcuvcohwCdVqd0QXbuRG?= =?iso-8859-1?Q?W5PBlnzrxixrrSkbM1UqWQhZEpBSqQajeuU20YVEdawzpa6EI5y9Jrss7k?= =?iso-8859-1?Q?bPJBxJT+s0fyfBe+ec16ZxmQjCjoozS8bIBqHFXCqHErsShShEzyvaShGJ?= =?iso-8859-1?Q?kWje7+hV17?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB7PR07MB5546.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba357a16-208f-4771-84cd-08d8da76e8c0
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2021 16:52:31.7922 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z7CjNiLAS6bHtN2gOeu23dRS3vTDqjYsD4dnwbF7sOXSMyEK1uM84bnU0oGfFzR9wIwMT0fmCoDzHq0ZPRdh2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR07MB6822
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/nBtw1q1hFb2w11w9M-0fALW8oNc>
Subject: Re: [Teas] Yangdoctors early review of draft-ietf-teas-actn-vn-yang-10
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Feb 2021 16:52:38 -0000

From: Andy Bierman <andy@yumaworks.com>
Sent: 26 February 2021 15:36
On Fri, Feb 26, 2021 at 4:07 AM tom petch <ietfa@btconnect.com<mailto:ietfa@btconnect.com>> wrote:
From: Teas <teas-bounces@ietf.org<mailto:teas-bounces@ietf.org>> on behalf of Dhruv Dhody <dhruv.ietf@gmail.com<mailto:dhruv.ietf@gmail.com>>
Sent: 20 February 2021 13:25

Hi Andy,


I agree with your comments.
Perhaps we should not be using 2 letter node names since they are likely to be ambiguous over time.

<tp>
TEAS is rather rich in them.

ap, as, id, ip, nt, nw, pw, te, tp, vn

and the augment paths go ten deep so a few extra characters can turn a four line path statement into something even harder to use:-(

Tom Petch

Andy

Thanks for your review. The new -11 version is out which takes your comments into consideration.

https://datatracker.ietf.org/doc/draft-ietf-teas-actn-vn-yang/
A diff from the previous version is available at:
https://www.ietf.org/rfcdiff?url2=draft-ietf-teas-actn-vn-yang-11

<tp>
I liked most of Andy's comments but not the one that leads to/vn/vn/vn-id or/ap/ap/ap-id or /ap/ap/vn-ap/vn-ap-id.  I agree that the original was not good but am not sure that repeated 'ap'  or 'vn' add clarity.

However, a more substantial comment relates to vn-compute where the compute status uses te-common-status which allows for up, down, testing, maintenance; mmmm.  This is not the only I-D to compute and they seem to be heading in different directions where success/failure and reasons therefore are concerned..

Ditto error-info which here is RYO while others import from  yang-te.

YANG is bad at having a list which users only want to use a part of (e.g. Hash algorithms) but the identifiers could be coordinated at least within one IETF WG..

Tom Petch



Thanks!
Dhruv

On Sun, Dec 20, 2020 at 9:16 PM Andy Bierman via Datatracker <noreply@ietf.org<mailto:noreply@ietf.org><mailto:noreply@ietf.org<mailto:noreply@ietf.org>>> wrote:
Reviewer: Andy Bierman
Review result: Ready with Issues


Major Issues:

  None

Moderate Issues:

1)
   leaf /ap/access-point-list/access-point-id
   leaf /vn/vn-list/vn-id
   leaf /vn/vn-list/vn-member-list/vn-member-id

   These list keys use type inet:uri.
   You should consider the implementation complexity here.
   Will servers all correctly convert any arbitrary URI to its canonical
   representation? The draft should address this issue.

2)
  leaf /vn/vn-list/oper-status
  leaf /vn/vn-list/admin-status

  These objects use vn-status-type, vn-admin-state-type
  The use of identities for even simple "up/down" status types
  seems extreme. The conformance for an enumeration is clear
  (mandatory), but not for an identityref type.
    - E.g., Is is mandatory for a vendor to support vn-state-up,down?
      A vendor could write their own identities and ignore the standard
      identities.


3)
  rpc /vn-compute
  The procedure for this operation is not explained here.
  A full description or reference to normative test is needed.
   - what does the server do with the input?
   - what output is expected? Any variants based on the inputs
     should be explained.
   - any interoperability considerations wrt/ use of these
     common groupings in this RPC context?
   - what errors can occur? Specify any error-tags, etc. that
     the server MUST/SHOULD include in the response


Minor Issues:

4)
 - naming inconsistent within /ap and /vn
   access-point is spelled out and vn is not
   Suggest: shorten access-point to ap

5)
 - naming a list entry with the the suffix -list is redundant.
   YANG lists do not have any conceptual container or way to
   reference all the entries (if that what this naming intends)
   Suggest:
     s/access-point-list/ap/
     s/vn-list/vn/
     s/vn-member-list/vn-member/

6)
  - leaf /vn/vn-list/vn-member-list/src/multi-src
  - leaf /vn/vn-list/vn-member-list/dest/multi-dest
    Looks like these leafs should each have a default-stmt.
    What does it mean if the multi-src-dest feature is supported
    but these leafs are missing from the config?