Re: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03

"Tarek Saad (tsaad)" <tsaad@cisco.com> Tue, 05 February 2019 20:12 UTC

Return-Path: <tsaad@cisco.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 89002131227; Tue, 5 Feb 2019 12:12:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -19.195
X-Spam-Level:
X-Spam-Status: No, score=-19.195 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIMWL_WL_MED=-0.142, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=cSKS+Z1Q; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=WWjUB9nE
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id McRdaVrT1Vhb; Tue, 5 Feb 2019 12:12:05 -0800 (PST)
Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DD33613121D; Tue, 5 Feb 2019 12:12:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=7878; q=dns/txt; s=iport; t=1549397525; x=1550607125; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=KYjw4cUyCAlnqi72LWpswxbW8iSLLQgelrO2AXnxX6Y=; b=cSKS+Z1QBaIpkZfMLK196LFDf5u8XRZMi7AOENOpSsGd+mlFC4mi/02h vksdiN3I+8hcbzb5WtGhLyU/ni58/mGqgYzXYVkWa5Zdz+PjebAKf7U9o QMjAahtTcbqgvnLpbTTbzbGVj7ew9Er1NOY0ULOt1tlJjG0DyzYl6eJt2 w=;
IronPort-PHdr: =?us-ascii?q?9a23=3AIAMRuhW4vWxLEPYcLkuSwS11UkTV8LGuZFwc94?= =?us-ascii?q?YnhrRSc6+q45XlOgnF6O5wiEPSANWJ8OpK3uzRta2oGXcN55qMqjgjSNRNTF?= =?us-ascii?q?dE7KdehAk8GIiAAEz/IuTtankmB81LWHdu/mqwNg5eH8OtL1A=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ANAABx7Vlc/4QNJK1lGwEBAQEDAQE?= =?us-ascii?q?BBwMBAQGBUQYBAQELAYEwUAOBWwQLJ4QDg0cDhFCLLEqCDZgQFIEQA1QLAQE?= =?us-ascii?q?shEACF4J7IjQJDQEDAQECAQECbRwMhUoBAQEBAgEjEQwBATcBCwQCAQgRAwE?= =?us-ascii?q?BAQMCJgICAjAVCAgCBAENBYMigWoDDQgBoU0CihRxgS+CeAEBBYUMGIILCIE?= =?us-ascii?q?LizgXgUA/gREnH4IeLoRpGBeCcjGCBCKQNIZpiwxXCQKLFYcoGYFshUOLGIo?= =?us-ascii?q?qgQyQMAIEAgQFAg0BAQWBRjiBVnAVGiEqAYJBghyDbopTcoEojVIBAQ?=
X-IronPort-AV: E=Sophos;i="5.58,336,1544486400"; d="scan'208";a="235484257"
Received: from alln-core-10.cisco.com ([173.36.13.132]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2019 20:12:03 +0000
Received: from XCH-RCD-004.cisco.com (xch-rcd-004.cisco.com [173.37.102.14]) by alln-core-10.cisco.com (8.15.2/8.15.2) with ESMTPS id x15KC3l1000959 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 5 Feb 2019 20:12:03 GMT
Received: from xhs-rtp-001.cisco.com (64.101.210.228) by XCH-RCD-004.cisco.com (173.37.102.14) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 5 Feb 2019 14:12:02 -0600
Received: from xhs-rcd-001.cisco.com (173.37.227.246) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 5 Feb 2019 15:12:01 -0500
Received: from NAM03-DM3-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-001.cisco.com (173.37.227.246) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Tue, 5 Feb 2019 14:12:01 -0600
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector1-cisco-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KYjw4cUyCAlnqi72LWpswxbW8iSLLQgelrO2AXnxX6Y=; b=WWjUB9nEw2jZB2LdNKAuHsUMAgXTOUSUHBLf3AgIGDkvsSUnZz5ybbQ+3sUqBY/cI6+lqMuajKTy0/R1KqiI7MAcTp4o/on/wnCfTU1Y3eElCw3wLA8A5JXQ8HapQv66tFkPpHhfYzJJfqeeFLtuUJYrF+Vb2Hv7HgNO+KIue0Y=
Received: from BN6PR11MB1794.namprd11.prod.outlook.com (10.175.100.8) by BN6PR11MB1780.namprd11.prod.outlook.com (10.175.99.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1580.17; Tue, 5 Feb 2019 20:12:00 +0000
Received: from BN6PR11MB1794.namprd11.prod.outlook.com ([fe80::f850:65c4:46eb:7e66]) by BN6PR11MB1794.namprd11.prod.outlook.com ([fe80::f850:65c4:46eb:7e66%9]) with mapi id 15.20.1580.019; Tue, 5 Feb 2019 20:11:59 +0000
From: "Tarek Saad (tsaad)" <tsaad@cisco.com>
To: tom petch <ietfa@btconnect.com>, Jan Lindblad <janl@tail-f.com>
CC: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "draft-ietf-teas-yang-te-types.all@ietf.org" <draft-ietf-teas-yang-te-types.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "teas@ietf.org" <teas@ietf.org>
Thread-Topic: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03
Thread-Index: AQHUsz7qhRxUpP0qbkyLe9M1xeeg7qXRY8eA
Date: Tue, 5 Feb 2019 20:11:59 +0000
Message-ID: <8009797C-AAFD-46A9-860F-04059D44F6D1@cisco.com>
References: <154090780735.15255.3911131220920609603@ietfa.amsl.com> <973699DE-882E-4531-A7D5-32AFEF4359E7@cisco.com> <6CC3CA10-0768-4C99-9237-30A78E1EC3DA@tail-f.com> <BB36593B-0A4E-4F88-A088-3C35BBCAB902@cisco.com> <39E705F8-EE93-4F16-AD3A-39B2E6FCC37E@tail-f.com> <00bc01d4b33e$c42e4d20$4001a8c0@gateway.2wire.net> <B9068E7A-9D15-4F77-A9BF-3B25092DC1CC@cisco.com> <005f01d4bd61$8855f8c0$4001a8c0@gateway.2wire.net>
In-Reply-To: <005f01d4bd61$8855f8c0$4001a8c0@gateway.2wire.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.14.0.181208
authentication-results: spf=none (sender IP is ) smtp.mailfrom=tsaad@cisco.com;
x-originating-ip: [2001:420:c0c0:1004::223]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BN6PR11MB1780; 6:G8Md9UnqH8onC/UqU6J1oGmHWQNefzxyIjqQYsVaSR+YlYC0IiaKrel8pgQoj5GKsmacQ8XKjBTqzfn2z0ziXm5XMOmgbo5KHUJR+2AKr6mNrzeeYdhwNRQ6qFNy0u6VZujDHv0YGLBIDQDCFs4ydLHFUMT4NaYFANZEVUDHST6DEv/S6nTvSWo/8FI4OF61z29AKaKO7+/L9eKnlobz9vPPI9qCru5gwPZAP6S7UuhWJuH8RoRvNgDNhPXiRJ5UqWuG2bfgRpXZy8xIivHssLkNrR+VBmNk25QTHct5lE9FN4ABfGm2YZOIynUFY5te5Qa/7dgc/yUPAY+Tz08maeHH1OAbGXvmEIXKPU4NjuWM/q9PNSUIirmMFSNPD5Ox3pHbZQL4A6ivQLM0c0EoKKm4Rry6iVwSXsRQ51PvZsp7WBBYMZ+pTgnZfKMqQ/GeTOpBd1yxr7TZYodJUVHqLQ==; 5:nXcba46T/sjpO5y8CrPUz4qkP0u9oLXYYZVHB1M/n6K2YM/OdsngRqsc8EVfadeGBjPWPNQCkvlHuF1yw0NdNQsWkWR99BKXFKE/4+h0elyHcRfJXZtidB40Ckhtq5ZUAyqqsYkq/yW2bqfY9chjkNFISZtGdMX9D7CLUXYyre1QftQSVXMWL6Z6y/9BTH36/HUMDv4QGlhdx43WIm+j8Q==; 7:WYxvhW0PVcRDbEwTyQ2HqwG5ICp7ZMNrHbfWJS2KB1hmArM9V2UyuxPpJuit4Cwl2zbG9CBk4RzmlijSDC+yDXowB5EyovRGL2IJGahTysIwBTBkLaLWXnjWtf3hTkCCWL95U8X6exkTiTzFhMNvcQ==
x-ms-office365-filtering-correlation-id: a7ea6a42-e7c2-4020-4979-08d68ba62fa8
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7153060)(7193020); SRVR:BN6PR11MB1780;
x-ms-traffictypediagnostic: BN6PR11MB1780:
x-microsoft-antispam-prvs: <BN6PR11MB178054E049D39D0278F2F42FA36E0@BN6PR11MB1780.namprd11.prod.outlook.com>
x-forefront-prvs: 0939529DE2
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(136003)(366004)(396003)(376002)(13464003)(43544003)(189003)(199004)(99286004)(102836004)(105586002)(106356001)(36756003)(11346002)(446003)(478600001)(97736004)(4326008)(58126008)(476003)(33656002)(229853002)(316002)(53936002)(296002)(7736002)(8936002)(86362001)(76176011)(82746002)(2906002)(81156014)(71200400001)(6512007)(8676002)(25786009)(6116002)(71190400001)(486006)(83716004)(81166006)(68736007)(6486002)(14454004)(53546011)(305945005)(93886005)(110136005)(14444005)(54906003)(256004)(6246003)(2616005)(46003)(6506007)(186003)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR11MB1780; H:BN6PR11MB1794.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: SzSqPqjxuZ9GvrG1rNflWEr/xVdSK4YoZKSi9G9AUk4d3EQmOkj3mMvUnIXjUoDbfOdwayVdbniWnYE00mfQMRExOMfU1kj3uiaXbuRY1P8LqZ7eRTrEDs+8rCIhvqBFRI0jdjXyRkDQYI+R6R0emHKacqkFe7HzEmheBY25462NHs+v6yE1rIUglAIKQtJA8matQtMk1mJF+ljTuTLlC6BcBQ0qx70V5Is224T3v1s3IbaLJwYmPU2L6nCyn8gz9aG/nHkr84V1RMsjbkQtVqA5+tB8EQB9gdzQCUrxvQlTyKL8qiZLhseoUpPURq/Nt5gqmww8yv2FqMKtiS+KbBqwsjakcZoJDrpKjSnThSVa4a+2ph7hj+eHwz5DdIt9x3PLi5XGMEonN+qzuRqi3xAayghp6sUyPPIzzw8Ts+s=
Content-Type: text/plain; charset="utf-8"
Content-ID: <07FA0F22B41E7D41A9AEFE183A53CB41@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a7ea6a42-e7c2-4020-4979-08d68ba62fa8
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2019 20:11:59.8072 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1780
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.14, xch-rcd-004.cisco.com
X-Outbound-Node: alln-core-10.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/C9Q4bRVz98Yfiw-8syzze08JA4o>
Subject: Re: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Feb 2019 20:12:08 -0000

Thanks, Tom. Please see inline below.

-----Original Message-----
From: tom petch <ietfa@btconnect.com>;
Date: Tuesday, February 5, 2019 at 9:47 AM
To: Tarek Saad <tsaad@cisco.com>;, Jan Lindblad <janl@tail-f.com>;
Cc: "yang-doctors@ietf.org"; <yang-doctors@ietf.org>;, "draft-ietf-teas-yang-te-types.all@ietf.org"; <draft-ietf-teas-yang-te-types.all@ietf.org>;, "ietf@ietf.org"; <ietf@ietf.org>;, "teas@ietf.org"; <teas@ietf.org>;
Subject: Re: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03

    Tarek
    
    Getting there .
    
    You will need to have a reference to the new I-D references in the body
    of the I-D else you will get unused references.  One way to do this is
    to have a Section 4.1 This module references [RFC3272]. [....  I have
    not gone through and seen how many this applies to but imagine it is
    most of them.
[TS]: unfortunate that the tool will flag those as warning as the I-D YANG module clearly references them.. I am wondering if there is a chance or a plan to enhance the IETF idnit tool to parse the YANG module for references and silence such warnings?

    
    Also you have G.8031 but G808.  Not wrong, but...
[TS]: G.8031 is already listed in references. G808 is still relevant. I've moved both to informative references as per other recommendations.
    
          import ietf-routing-types { prefix "rt-types";
    now has the right RFC but the wrong title; should be
    Common YANG Data Types for the Routing Area

[TS]: thank you. I'll take care of this one in the next update.

Regards,
Tarek

    
    Tom Petch
    
    ----- Original Message -----
    From: "Tarek Saad (tsaad)" <tsaad@cisco.com>;
    Sent: Thursday, January 31, 2019 2:10 PM
    
    > Hi Tom,
    >
    > Thank again for your review comments below. We've uploaded version
    04/-05 which attempts to address these comments.
    > See inline [TS] for resolution.
    >
    > -----Original Message-----
    > From: tom petch <ietfa@btconnect.com>;
    > Date: Wednesday, January 23, 2019 at 12:13 PM
    > To: Jan Lindblad <janl@tail-f.com>;, Tarek Saad <tsaad@cisco.com>;
    > Cc: "yang-doctors@ietf.org"; <yang-doctors@ietf.org>;,
    "draft-ietf-teas-yang-te-types.all@ietf.org";
    <draft-ietf-teas-yang-te-types.all@ietf.org>;, "ietf@ietf.org";
    <ietf@ietf.org>;, "teas@ietf.org"; <teas@ietf.org>;
    > Subject: [Teas] not a Yangdoctor review of
    draft-ietf-teas-yang-te-types-03
    >
    >     Tarek
    >
    >     The YANG modules have lots of references - good - but they are not
    in
    >     the I-D references - not good.
    >
    >     My list is
    >
    >     3272
    >     4202
    >     4328
    >     4657
    >     5817
    >     6004
    >     6205
    >     6511
    >     7139
    >     7308
    >     7551
    >     7571
    >     7579
    >     7951
    >     G.808
    >     G.8031
    >     G.8131
    >     G.873.1
    >
    > [TS]: thanks. I've added the missing references and they should show
    in the I-D references now.
    >
    >     s.3.1 I would find more usable if the types were in an order I
    could
    >     recognise, such as alphabetical
    >
    > [TS]: OK, I tried an attempt to sort the typedefs alphabetically.
    >
    >       import ietf-routing-types { prefix "rt-types";
    >     reference "RFC6991: Common YANG Data Types";
    >     perhaps RFC8294 is intended
    >
    > [TS]: corrected to RFC8294
    >
    >     "   defined in ietf-network.yang, to help user to understand ""
    >     might benefit from a reference - is this
    >     draft-ietf-i2rs-yang-network-topo?
    >
    > [TS]: added reference RFC8345.
    >
    >     /"Then index of the label/ "The index of the label /
    >
    > [TS]: fixed typo.
    >
    >               container tiebreakers {
    >                 description
    >                   "The list of tiebreaker criterion to apply
    >                    on an equally favored set of paths to pick best";
    >                 list tiebreaker {
    >                   description
    >                   "The list of tiebreaker criterion to apply
    >                      on an equally favored set of paths to pick best";
    >     One description is perhaps enough
    >
    > [TS]: removed/updated redundant description.
    >
    >     uses path-objective-function_config;
    >     using _ is not wrong but is discouraged, mixing _ with - in a
    label more
    >     so
    >
    > [TS]: OK, we have moved away from using "_" in the naming.
    >
    >     /This document registers a YANG module/
    >     This document registers two YANG modules/
    >
    > [TS]: fixed typo.
    >
    >        name: ietf-te-types namespace:
    urn:ietf:params:xml:ns:yang:ietf-te-
    >        types prefix: ietf-te-types reference: RFC3209
    >        name: ietf-te-packet-types namespace:
    >        urn:ietf:params:xml:ns:yang:ietf-te-packet-types prefix:
    ietf-te-
    >        packet-types reference: RFC3209
    >
    >     Perhaps /3209/XXXX/
    >
    > [TS]: fixed.
    >
    > Regards,
    > Tarek
    >
    >     Tom Petch
    >
    >     ----- Original Message -----
    >     From: "Jan Lindblad" <janl@tail-f.com>;
    >     To: "Tarek Saad (tsaad)" <tsaad@cisco.com>;
    >     Cc: <yang-doctors@ietf.org>;;
    >     <draft-ietf-teas-yang-te-types.all@ietf.org>;; <ietf@ietf.org>;;
    >     <teas@ietf.org>;
    >     Sent: Monday, January 21, 2019 10:10 AM
    >     Subject: Re: [Teas] Yangdoctors early review of
    >     draft-ietf-teas-yang-te-types-03 (was -01)
    >
    >
    >     >
    >
    >
    >
    >