Re: [Teas] I-D Action: draft-ietf-teas-yang-te-26.txt

t petch <ietfa@btconnect.com> Tue, 06 April 2021 09:34 UTC

Return-Path: <ietfa@btconnect.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C860A3A18F8 for <teas@ietfa.amsl.com>; Tue, 6 Apr 2021 02:34:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.1
X-Spam-Level: *
X-Spam-Status: No, score=1.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FAKE_REPLY_A1=2.999, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oulWeKzWmWbR for <teas@ietfa.amsl.com>; Tue, 6 Apr 2021 02:34:39 -0700 (PDT)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20097.outbound.protection.outlook.com [40.107.2.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 805403A18F4 for <teas@ietf.org>; Tue, 6 Apr 2021 02:34:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q0oJ9Q+uwOZ5O0FOHTpAWOVSpuCJuVHXaWMEn6WjaDsZmuElO9WJ7+lT8Lh0LeYeuAoN3a3yYfK2tOcPTag5/rutoI34pxRUgMi3M8kWeUO373jJJtvlsBH4aIy9xnP5KgsdoSKYBdhgVrt7p7tSdPWEPvcor3MUVpmTLOt0bqV81Ku6VmN9U3oKVAw0ndsaHCZN2bOkncrgwln42k1sg/2yKj7NtZ9fmgQpseWeD62SIdaGmGNki/aCqgDvMM9FPkrdcM6BNinh0MLkgTkQ0bbmRLlEjJPynwGnWSkXg9VtqGbATPb2oX8zrMN/BqrMioJCoWCvaOZxloE/nxmmPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SRdZkQ8HqDzQ22hnjo10pstmw9YpMRzWi6Ek+1T7tR8=; b=Zc7lVgmxaaYbgQk1ojYcf4YOfN054eID4KWrxjl4YblA+U3IoRZ0fs4AGDnuVPG2bcZqjd1YhDf2COXRu+51VAcKDTeodaMAspt3ZZDmgmwciCYyPiiJxiHAIfUeRcOf3dW+n/uqenfakM6hYQNf3AFWfoujANEX2LvRdyu1P7ttQXtFKjZ5ii71KQfzyIAmdXm3u+dxFkoHrFwlxItWGHorR+ntLF3WfHDchYnaQt/8Y1T95juuE+Cae2fB4YsF6PsiB/Yz5KSOlrtTiAT+eCoCeJ+BzheOuUBtwg7/XLp+L/m2SfoMx9z9bTUyqGD7taTqp16niU8XibhQ9j7OnA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SRdZkQ8HqDzQ22hnjo10pstmw9YpMRzWi6Ek+1T7tR8=; b=pSBDhTroqilnInXCUE/q3Dw5LkUFjpEL1UlYQKmNzk2F4CUe41xScHZVFWwBRcqWb9GDrqdiIENMqbjmT8SaTucRv6cG+TF5RviUlcI2vIOVsEFAVtruNBQ/5SGRdDLAg3US3/LhzzUgu7ch+xKQTsR8CDgfDyfMi3A1zEWDoY4=
Authentication-Results: ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=btconnect.com;
Received: from DB7PR07MB5546.eurprd07.prod.outlook.com (2603:10a6:10:73::23) by DB6PR07MB3079.eurprd07.prod.outlook.com (2603:10a6:6:22::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.13; Tue, 6 Apr 2021 09:34:36 +0000
Received: from DB7PR07MB5546.eurprd07.prod.outlook.com ([fe80::e5d9:cd75:1ebc:a236]) by DB7PR07MB5546.eurprd07.prod.outlook.com ([fe80::e5d9:cd75:1ebc:a236%4]) with mapi id 15.20.4020.015; Tue, 6 Apr 2021 09:34:36 +0000
To: Tarek Saad <tsaad@juniper.net>, teas@ietf.org
From: t petch <ietfa@btconnect.com>
Message-ID: <606C2B1F.3080803@btconnect.com>
Date: Tue, 6 Apr 2021 10:34:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [86.146.121.140]
X-ClientProxiedBy: LO4P123CA0154.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::15) To DB7PR07MB5546.eurprd07.prod.outlook.com (2603:10a6:10:73::23)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.65] (86.146.121.140) by LO4P123CA0154.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3999.32 via Frontend Transport; Tue, 6 Apr 2021 09:34:36 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7d1d16b5-f6ed-4eda-3110-08d8f8df3175
X-MS-TrafficTypeDiagnostic: DB6PR07MB3079:
X-Microsoft-Antispam-PRVS: <DB6PR07MB307938EF9EF5626C08D894EBA2769@DB6PR07MB3079.eurprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: CGGx9vBJWBgqyPBNtKqH7EdeoM4gYwURRxyzh1hl+7rI8DqZ8Z8eXRyQt7bk9lbuSAOBNXAIJn77jEkAMmLzonLuSgmxME1oXdaf9xoyqsRIE7OV+je5N4dW4dkHosWSZXbKdVz9VdZQ4oAuxRhj4k2eY2YYTEBUYfmSuAVbWJALRXZsWFVD1pgBwxAmXvWyoWKLIFv0iOa/iZf2rNnpPE2sqDPh+mQNlJgVmutT21H1JV4MD2gbD4Gk4P0rRfD7NWkP+zfZCkvoTkLA9CjDMCipFdha8ueXEkq2kAja0l5LNPu0LGs2FwMo+i2Lt+2x2KJpt/v6uGCiG9p3zk2mBTfklQLXfJaVqZ7C+uCfe/Pkga2B9/U73trZ9Idx/vCycJM1nBpg9dr4y2An4ODJ6jcKhw8yFKxfYSfurUvXo0kv+mp/Dhdzow+SXKpDDEzFg/JKks01u4RvAeP03HH2XET5GtFeic5YD/ccqbd80KY1SM6TNYhYoaSHzctNmanZ7UTJFQpA70c+Xal1ykhfR9YOtl/9NWe9wEvlurbCkrXEAYoRchTJVVLh0BGRC9Qzq5LAfjxBCcBYv6YM2t39Fc+mNMKuRG8jyhWz4kZXUMNCyEVmsksnCSfIyNSTuc7qdlh9q5F7/yIv9JfQM4DNO55IBkSPhsQhE4b+KfKUfhZKURrpqf5eS1uO+5noaWBM
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR07MB5546.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(136003)(39860400002)(346002)(396003)(366004)(83730400007)(26005)(52116002)(186003)(38100700001)(8676002)(16526019)(36756003)(316002)(16576012)(6486002)(8936002)(38350700001)(478600001)(33656002)(6666004)(66574015)(66946007)(66556008)(5660300002)(83380400001)(66476007)(2616005)(956004)(86362001)(53546011)(2906002)(87266011); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: 5NsRT7VMJLAMeV7cuDbx4xhEN+Fo1Sg6pMxaUKwLdvW8zVhQEsUyqFwBgVbwbSwJLm/ih6rPnf9UE4GGx3Dde8kgFdOIppbI2bIz4hfk+qy/jyA+94HGYKEmYfOeThuFymhfgiyZUJ0R3Jo2v7vm9Bxk7BKkSmogz67q9Zb0Cm6h73Shv6f9H2RpcvBlL7q8ET/rDxNux8LP6IViVb56c+3Reopkzqz/hfLFNLSPRKA7WSVM7ZNBY5B5cCzjA2BlUFYlQcVVRmednMKYEOjkgdwsZGZ8zys9jOg9Q+THERgXZii5iwez7alcKtg7tlqOQSXZ01DJmnrr9M/eLv/LxfeHmtKSLmNL4EROFc7TQsyovfokIvNGxgpkM+AILMCeIgozcpm6BzJdaWfITGKkk/NPGmmFma163NSmiVSJ+VYzp4eCvl08BlXbTaJCldKRlWK3zq+kxi2hHJg+M3VKULVJwjLZNr46a9WYdfvfs7mYrFJ/7uLgsJBhjc4JjdcsSZ4Bo2/IjyYzYzXDiMuSQZlekt1sAWC2q58DkosNtUFAK1jrGDioWE/NWaugY/0XYi/O1rMulaCW+WZO/TbDoR0PR1zwfzKQYVE3KgBcF2SglC9nRj7uZgJl+J0xy3F1+KKRK/GTjxqgONaHdoA+OtIlMx9qx1PPUwF9iuCVsaYO+8PHvGu28EqapHXKB9YNGvv7eVK/hgUq+IgVOWkY4LZ2FXWWyHidiuTnUaZUT2Rl2D463vI8HaF2bQwqTJIC
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d1d16b5-f6ed-4eda-3110-08d8f8df3175
X-MS-Exchange-CrossTenant-AuthSource: DB7PR07MB5546.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2021 09:34:36.7442 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HvLmhmNLLS75h7d1JbHdHIDcG+XypMecvUbGZmuO2W2q74YKgXCWC6IRoWbOZ65VfqpWyaXXOGwMrF7t5e4utg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR07MB3079
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/G3_e0h1WADg5L3ILq3BDxXgl1XM>
Subject: Re: [Teas] I-D Action: draft-ietf-teas-yang-te-26.txt
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2021 09:34:44 -0000

On 24/02/2021 15:47, Tarek Saad wrote:
> Hi Tom and WG,
>
> The latest version contains the following changes:
> - editorial nits
> - new identity for metric "path-metric-loss"
> - rearranging headend LSP attributes
> - addressing issue in reference groupings from external modules (using absolute leafref path, and prefix'ing module prefix in XPath)
> - added 'controller' container to indicate the controller-id and 'protocol-origin' for externally created tunnels
> - added JSON example of the instance tree when using the YANG model to create and query state for a TE tunnel
> - new co-author joined

Tarek

Thanks for that; I think that -26 could do with a  few editorial tweaks

s.2.2
    o  Suitable defaults are specified for all configurable elements.
I think that this overstates the case; many elements but by no means all


s.5
    The detailed tree structure is provided in Figure 2.
Figure 7 I think


Since you have both RPC and action, I suggest a section in 5.1
summarising what these can do for you, when to use RPC, when to use
'action'

s.5.2
line length is ok but splitting the identifiers mid-word perhaps not;
doubtless there is a pyang option to fix this; -25 did not have this
problem

s.5.3
lots of references - good- but they must appear in I-D References.  I do
not see
RFC5440 -
RFC5441 -
RFC5520 -
RFC5557 -
RFC8306 -
RFC8685 -

   revision 2021-02-20 {
...
     reference
       "RFCXXXX: A YANG Data Model for Traffic Engineering Tunnels
        and Interfaces.";
This is not (quite) the title of the I-D

I see many unexpanded abbreviations; BRPC, PKS, APS, LoP, SF, MS, WTR,
MS, SD


     leaf lsp-protection-role {
       ...
         enum protecting {
           description
             "A secondary LSP is an LSP that has been provisioned
              in the control plane only; e.g. resource allocation
should that be i.e. ??

         leaf protection-group-ingress-node-id {
...
              By default, if neither ingress nor egress node-id
              is set, the action applies to ingress node only.";
this could be in the YANG but is not!

         leaf protection-group-egress-node-id {
ditto


   /* TE Tunnel RPCs/execution Data */
Security Considerations mention the use of NACM but the YANG modules do
not use it.  Common practice is to put a
nacm:default-deny-all
at least on any RPC/action that might do harm


s.6.3

    prefix te-dev;
This is not what IANA Considerations says!

   revision 2021-02-20 {
...
     reference
       "RFCXXXX: A YANG Data Model for Traffic Engineering Tunnels
        and Interfaces.";
Again, this is not (quite) the title of the I-D

            leaf value {
              type uint32 {
                range "0..4294967295";
If this is the maximum value then it can be expressed as "0..max"

      leaf threshold-type {
might benefit from a reference

rpc
again , could use NACM

s.10
"unnels-actions":
perhaps   "tunnels-actions":

13.  Appendix A: Examples
these do not match the YANG modules e.g.
          "p2p-primary-paths": [
disappeared several versions ago

Tom Petch

> Tarek
>
>
> Regards,
> Tarek (for the co-authors)
>
> ?On 2/23/21, 7:27 AM, "Teas on behalf of tom petch" <teas-bounces@ietf.org on behalf of ietfa@btconnect.com> wrote:
>
>
>
>      ________________________________________
>      From: Teas <teas-bounces@ietf.org> on behalf of internet-drafts@ietf.org <internet-drafts@ietf.org>
>      Sent: 22 February 2021 18:31
>