Re: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03

Italo Busi <Italo.Busi@huawei.com> Thu, 07 February 2019 15:24 UTC

Return-Path: <Italo.Busi@huawei.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 82A6F124C04; Thu, 7 Feb 2019 07:24:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.3
X-Spam-Level:
X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id unNgQjtRkuLh; Thu, 7 Feb 2019 07:24:31 -0800 (PST)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1BC3812008F; Thu, 7 Feb 2019 07:24:31 -0800 (PST)
Received: from LHREML710-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 04DF16FECC23A6390A9B; Thu, 7 Feb 2019 15:24:29 +0000 (GMT)
Received: from LHREML504-MBS.china.huawei.com ([10.201.109.59]) by LHREML710-CAH.china.huawei.com ([10.201.108.33]) with mapi id 14.03.0415.000; Thu, 7 Feb 2019 15:24:28 +0000
From: Italo Busi <Italo.Busi@huawei.com>
To: tom petch <ietfa@btconnect.com>, "Tarek Saad (tsaad)" <tsaad@cisco.com>, Jan Lindblad <janl@tail-f.com>
CC: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "draft-ietf-teas-yang-te-types.all@ietf.org" <draft-ietf-teas-yang-te-types.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "teas@ietf.org" <teas@ietf.org>
Thread-Topic: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03
Thread-Index: AQHUvvaegdG1N3lGS0uhQK8y6r5qpKXUcjGA
Date: Thu, 7 Feb 2019 15:24:27 +0000
Message-ID: <91E3A1BD737FDF4FA14118387FF6766B276B7F7C@lhreml504-mbs>
References: <154090780735.15255.3911131220920609603@ietfa.amsl.com> <973699DE-882E-4531-A7D5-32AFEF4359E7@cisco.com> <6CC3CA10-0768-4C99-9237-30A78E1EC3DA@tail-f.com> <BB36593B-0A4E-4F88-A088-3C35BBCAB902@cisco.com> <39E705F8-EE93-4F16-AD3A-39B2E6FCC37E@tail-f.com> <00bc01d4b33e$c42e4d20$4001a8c0@gateway.2wire.net> <B9068E7A-9D15-4F77-A9BF-3B25092DC1CC@cisco.com> <005f01d4bd61$8855f8c0$4001a8c0@gateway.2wire.net> <8009797C-AAFD-46A9-860F-04059D44F6D1@cisco.com> <00c901d4bed9$fdf8aae0$4001a8c0@gateway.2wire.net>
In-Reply-To: <00c901d4bed9$fdf8aae0$4001a8c0@gateway.2wire.net>
Accept-Language: it-IT, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.203.246.251]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/N5VpCr66p98PbgGrD18gd956usk>
Subject: Re: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2019 15:24:34 -0000

Hi  Tom,

Regarding your comment:

"I was unclear about my comment on G808; having the reference is find but I would prefer G.808; I note that Deborah's e-mail used G.808 even when referring to the 'G808' in the I-D so I think G.808 is to be preferred."

The draft references G.808 whenever it is possible

However, there are a couple of items which are common across multiple technologies but missing in G.808:
- signal-fail-of-protection which has higher priority than the FS command
- failure-of-protocol

In this case, the set of technology-specific Recommendations (G.8031, G.8131 and G.873.1) has been referenced instead of G.808

@Tarek: I have just noted the following nit in G.873.1 reference which can be easily fixed when you publish the next draft update:

OLD
   [G.873.1]  "G.8131 : Linear protection switching for MPLS transport
              profile", July 2014,

NEW
   [G.873.1]  "G.873.1 : Optical transport network (OTN):
             Linear protection", October 2017,

Italo

-----Original Message-----
From: tom petch [mailto:ietfa@btconnect.com] 
Sent: giovedì 7 febbraio 2019 12:42
To: Tarek Saad (tsaad) <tsaad@cisco.com>;; Jan Lindblad <janl@tail-f.com>;
Cc: yang-doctors@ietf.org; draft-ietf-teas-yang-te-types.all@ietf.org; ietf@ietf.org; teas@ietf.org
Subject: Re: [Teas] not a Yangdoctor review of draft-ietf-teas-yang-te-types-03


----- Original Message -----
From: "Tarek Saad (tsaad)" <tsaad@cisco.com>;
Sent: Tuesday, February 05, 2019 8:11 PM

> Thanks, Tom. Please see inline below.
>
> -----Original Message-----
> From: tom petch <ietfa@btconnect.com>;
> Date: Tuesday, February 5, 2019 at 9:47 AM
>     Tarek
>
>     Getting there .
>
>     You will need to have a reference to the new I-D references in the
body
>     of the I-D else you will get unused references.  One way to do
this is
>     to have a Section 4.1 This module references [RFC3272]. [....  I
have
>     not gone through and seen how many this applies to but imagine it
is
>     most of them.
> [TS]: unfortunate that the tool will flag those as warning as the I-D
YANG module clearly references them.. I am wondering if there is a chance or a plan to enhance the IETF idnit tool to parse the YANG module for references and silence such warnings?
>

Well no, that would be wrong.

A YANG module needs references, for import statements and to tell the user where to go for more information on the objects, their use and so on.

A YANG module must be plain text so cannot contain the usual HTML/XML style anchors that an I-D/RFC has.

Documents referenced from within an RFC must appear in the References of that RFC.

Hence
 - anything referenced in the YANG module must be in the References of the RFC
- anything referenced in the YANG module must have a HTML/XML style reference somewhere in the RFC outside the YANG module.

Where such references do not crop up in the existing text of the memo outside the YANG module, then the practice is to add a Section X.1 before the YANG module saying words to the effect that this YANG module imports from [. and references [....

So the tool wants enhancing to generate more warnings, not less, when the contents of a a YANG reference clause do not appear in the Reference section of the I-D.

HTH

I was unclear about my comment on G808; having the reference is find but I would prefer G.808; I note that Deborah's e-mail used G.808 even when referring to the 'G808' in the I-D so I think G.808 is to be preferred.

Tom Petch


>     Also you have G.8031 but G808.  Not wrong, but...
> [TS]: G.8031 is already listed in references. G808 is still relevant.
I've moved both to informative references as per other recommendations.
>
>           import ietf-routing-types { prefix "rt-types";
>     now has the right RFC but the wrong title; should be
>     Common YANG Data Types for the Routing Area
>
> [TS]: thank you. I'll take care of this one in the next update.
>
> Regards,
> Tarek
>
>
>     Tom Petch
>
>     ----- Original Message -----
>     From: "Tarek Saad (tsaad)" <tsaad@cisco.com>;
>     Sent: Thursday, January 31, 2019 2:10 PM
>
>     > Hi Tom,
>     >
>     > Thank again for your review comments below. We've uploaded
version
>     04/-05 which attempts to address these comments.
>     > See inline [TS] for resolution.
>     >
>     > -----Original Message-----
>     > From: tom petch <ietfa@btconnect.com>;
>     > Date: Wednesday, January 23, 2019 at 12:13 PM
>     > To: Jan Lindblad <janl@tail-f.com>;, Tarek Saad <tsaad@cisco.com>;
>     > Cc: "yang-doctors@ietf.org"; <yang-doctors@ietf.org>;,
>     "draft-ietf-teas-yang-te-types.all@ietf.org";
>     <draft-ietf-teas-yang-te-types.all@ietf.org>;, "ietf@ietf.org";
>     <ietf@ietf.org>;, "teas@ietf.org"; <teas@ietf.org>;
>     > Subject: [Teas] not a Yangdoctor review of
>     draft-ietf-teas-yang-te-types-03
>     >
>     >     Tarek
>     >
>     >     The YANG modules have lots of references - good - but they
are not
>     in
>     >     the I-D references - not good.
>     >
>     >     My list is
>     >
>     >     3272
>     >     4202
>     >     4328
>     >     4657
>     >     5817
>     >     6004
>     >     6205
>     >     6511
>     >     7139
>     >     7308
>     >     7551
>     >     7571
>     >     7579
>     >     7951
>     >     G.808
>     >     G.8031
>     >     G.8131
>     >     G.873.1
>     >
>     > [TS]: thanks. I've added the missing references and they should
show
>     in the I-D references now.
>     >
>     >     s.3.1 I would find more usable if the types were in an order
I
>     could
>     >     recognise, such as alphabetical
>     >
>     > [TS]: OK, I tried an attempt to sort the typedefs
alphabetically.
>     >
>     >       import ietf-routing-types { prefix "rt-types";
>     >     reference "RFC6991: Common YANG Data Types";
>     >     perhaps RFC8294 is intended
>     >
>     > [TS]: corrected to RFC8294
>     >
>     >     "   defined in ietf-network.yang, to help user to understand
""
>     >     might benefit from a reference - is this
>     >     draft-ietf-i2rs-yang-network-topo?
>     >
>     > [TS]: added reference RFC8345.
>     >
>     >     /"Then index of the label/ "The index of the label /
>     >
>     > [TS]: fixed typo.
>     >
>     >               container tiebreakers {
>     >                 description
>     >                   "The list of tiebreaker criterion to apply
>     >                    on an equally favored set of paths to pick
best";
>     >                 list tiebreaker {
>     >                   description
>     >                   "The list of tiebreaker criterion to apply
>     >                      on an equally favored set of paths to pick
best";
>     >     One description is perhaps enough
>     >
>     > [TS]: removed/updated redundant description.
>     >
>     >     uses path-objective-function_config;
>     >     using _ is not wrong but is discouraged, mixing _ with - in
a
>     label more
>     >     so
>     >
>     > [TS]: OK, we have moved away from using "_" in the naming.
>     >
>     >     /This document registers a YANG module/
>     >     This document registers two YANG modules/
>     >
>     > [TS]: fixed typo.
>     >
>     >        name: ietf-te-types namespace:
>     urn:ietf:params:xml:ns:yang:ietf-te-
>     >        types prefix: ietf-te-types reference: RFC3209
>     >        name: ietf-te-packet-types namespace:
>     >        urn:ietf:params:xml:ns:yang:ietf-te-packet-types prefix:
>     ietf-te-
>     >        packet-types reference: RFC3209
>     >
>     >     Perhaps /3209/XXXX/
>     >
>     > [TS]: fixed.
>     >
>     > Regards,
>     > Tarek
>     >
>     >     Tom Petch
>     >
>     >     ----- Original Message -----
>     >     From: "Jan Lindblad" <janl@tail-f.com>;
>     >     To: "Tarek Saad (tsaad)" <tsaad@cisco.com>;
>     >     Cc: <yang-doctors@ietf.org>;;
>     >     <draft-ietf-teas-yang-te-types.all@ietf.org>;;
<ietf@ietf.org>;;
>     >     <teas@ietf.org>;
>     >     Sent: Monday, January 21, 2019 10:10 AM
>     >     Subject: Re: [Teas] Yangdoctors early review of
>     >     draft-ietf-teas-yang-te-types-03 (was -01)
>     >
>     >
>     >     >
>     >
>     >
>     >
>     >
>
>
>
>