Re: [Teas] FW: I-D Action: draft-ietf-teas-actn-vn-yang-05.txt

[tom petch <[e-mail]>]

----- Original Message -----
From: "Young Lee" <[e-mail]>
To: <[e-mail]>
Sent: Friday, June 14, 2019 7:44 PM

> Hi WG,
>
> The changes for this revision are as follows:
>
> - Added in Introduction Section on how the VN model can support 5G
transport context.
> - in Section 3.2: case 2 --- clarified how VN model is used along with
TE-topo Connectivity matrices construct and added a paragraph to
introduce the JSON example of the models (in Section 7)
> - For YANG model: converted "ltp" from configurable parameter to
leafref type; added references for imported modules.
> - Editorial: affiliation changes for a co-author; Compliant with five
front page authors' list.

As I said of -03, rather short on references and some that are seem
wrong.
Look, for example, at
draft-ietf-pim-igmp-mld-yang-15.
to see the sort of level of reference that a YANG module benefits from.

Several of the existing references should be Normative, according to
YANG Guidelines.

You have
       import ietf-te-types { prefix "te-types";
           reference"I-D.ietf-teas-yang-te-types: Traffic Engineering

but in the list of prefixes, always a good thing to have, is
      | te-types| ietf-te-types  | [TE-Tunnel]     |

while the I-D References has
   [TE-tunnel] T. Saad, et al., "A YANG Data Model for Traffic
             Engineering Tunnels and Interfaces", work in progress:
             draft-ietf-teas-yang-te.
which looks like a mismatch.

VN is expanded in the text but I think needs expanding in the Title of
the I-D and in the YANG module; others need expanding on first use;
L3SM,  L2SM  and L1CSM

And I think you should provide a reference for VN up front, something
along the lines of
"For more information on Virtual Networks, see [RFC8453]"
in the Introduction, first paragraph. (I don't think that RFC8453 is a
brilliant reference for VN but I cannot find a better one).

Tom Petch

> Thanks.
> Young & Dhruv
>
> -----Original Message-----
> From: Teas [mailto:[e-mail]] On Behalf Of
[e-mail]
> Sent: Friday, June 14, 2019 1:28 PM
> To: [e-mail]
> Cc: [e-mail]
> Subject: [Teas] I-D Action: draft-ietf-teas-actn-vn-yang-05.txt
>
>
> A New Internet-Draft is available from the on-line Internet-Drafts
directories.
> This draft is a work item of the Traffic Engineering Architecture and
Signaling WG of the IETF.
>
>         Title           : A Yang Data Model for VN Operation
>         Authors         : Young Lee
>                           Dhruv Dhody
>                           Daniele Ceccarelli
>                           Igor Bryskin
>                           Bin Yeong Yoon
> Filename        : draft-ietf-teas-actn-vn-yang-05.txt
> Pages           : 56
> Date            : 2019-06-14
>
> Abstract:
>    This document provides a YANG data model generally applicable to
any
>    mode of Virtual Network (VN) operation.
>