Re: [Teas] WG Last Call on draft-ietf-teas-rsvp-te-srlg-collect-05

"Matt Hartley (mhartley)" <mhartley@cisco.com> Wed, 04 May 2016 15:57 UTC

Return-Path: <mhartley@cisco.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F255412DA6F for <teas@ietfa.amsl.com>; Wed, 4 May 2016 08:57:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.516
X-Spam-Level:
X-Spam-Status: No, score=-15.516 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.996, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q5qFweQiZvwH for <teas@ietfa.amsl.com>; Wed, 4 May 2016 08:57:04 -0700 (PDT)
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BF0CC12D766 for <teas@ietf.org>; Wed, 4 May 2016 08:50:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=25086; q=dns/txt; s=iport; t=1462377044; x=1463586644; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=f+aBi9eb13uWEnbhsYRE8J08tSjHmzdyzE9t/qp27oo=; b=E9LDAuo0tLjubxd5f7bxproFvENl2FdPr8Mj3RgTUhuUH13oW7XWcJEu fqBIbdNVabXIj8nnLvu0bhk1SIU/oG512RKTqWlkgW8jNDNXRz3GWsnV7 nJrYknG+GwwE+QGOXa4GwYTmOLrUwfNEPzb2TugDM8IMJH8UZIUIyiLdw 0=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CwAgCGGSpX/4QNJK1egmxMU30GgnW2bQENgXWGEAIcgRk4FAEBAQEBAQFlJ4RBAQEBBAwXCkELEAIBBgIRBAEBKAMCAgIwFAkIAgQOBQiIIo8ZnR2RAwEBAQEBAQEBAQEBAQEBAQEBAQEBARWGIINKgQOEdYJKglkFmBkBjhCBb4RNgymFNY8zAR4BAUKDa2yHPQF+AQEB
X-IronPort-AV: E=Sophos;i="5.24,577,1454976000"; d="scan'208,217";a="100808444"
Received: from alln-core-10.cisco.com ([173.36.13.132]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 May 2016 15:50:43 +0000
Received: from XCH-ALN-004.cisco.com (xch-aln-004.cisco.com [173.36.7.14]) by alln-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id u44Foh7b013129 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 4 May 2016 15:50:43 GMT
Received: from xch-rcd-001.cisco.com (173.37.102.11) by XCH-ALN-004.cisco.com (173.36.7.14) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Wed, 4 May 2016 10:50:43 -0500
Received: from xch-rcd-001.cisco.com ([173.37.102.11]) by XCH-RCD-001.cisco.com ([173.37.102.11]) with mapi id 15.00.1104.009; Wed, 4 May 2016 10:50:43 -0500
From: "Matt Hartley (mhartley)" <mhartley@cisco.com>
To: "Zhangxian (Xian)" <zhang.xian@huawei.com>
Thread-Topic: [Teas] WG Last Call on draft-ietf-teas-rsvp-te-srlg-collect-05
Thread-Index: AQHRoY5hFf7aW4q4tU+wo+eHX2JTR5+mesmQgADdSbCAANJjAIAAy7wQ
Date: Wed, 04 May 2016 15:50:42 +0000
Message-ID: <360e911befe44c9d92608d70f6418be9@XCH-RCD-001.cisco.com>
References: <CA+YzgTsv1mZZhmeb_nDBZVQcopjb6AtizCy6McgNQwgYB42xhQ@mail.gmail.com> <C636AF2FA540124E9B9ACB5A6BECCE6B7DEA6AAC@SZXEMA512-MBS.china.huawei.com> <0ae55833714244719342e83bce5abe78@XCH-RCD-001.cisco.com> <C636AF2FA540124E9B9ACB5A6BECCE6B7DEA6D57@SZXEMA512-MBS.china.huawei.com>
In-Reply-To: <C636AF2FA540124E9B9ACB5A6BECCE6B7DEA6D57@SZXEMA512-MBS.china.huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [161.44.213.152]
Content-Type: multipart/alternative; boundary="_000_360e911befe44c9d92608d70f6418be9XCHRCD001ciscocom_"
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/teas/NSJeVMe-_OCzz-mTZR7lFu76qes>
Cc: "Matt Hartley (mhartley)" <mhartley@cisco.com>, Vishnu Pavan Beeram <vishnupavan@gmail.com>, "teas@ietf.org" <teas@ietf.org>
Subject: Re: [Teas] WG Last Call on draft-ietf-teas-rsvp-te-srlg-collect-05
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 May 2016 15:57:11 -0000

Xian,

OK – I understand what you mean now. I’ll do that too.

Cheers

Matt


Hi, Matt,

    Great; just one clarification inline:

   From: Matt Hartley (mhartley) [mailto:mhartley@cisco.com]
Sent: 2016年5月3日 23:12
To: Zhangxian (Xian); Vishnu Pavan Beeram; teas@ietf.org<mailto:teas@ietf.org>
Cc: Matt Hartley (mhartley)
Subject: RE: [Teas] WG Last Call on draft-ietf-teas-rsvp-te-srlg-collect-05

Thanks for the comments, Xian!

On the encoding section: the feedback I’ve received in the past is that it’s better not to do add the bit numbers to the encoding section as you have to mark them as provisional/TBD, and that’s then more work for the RFC Editor to clean up when IANA does the assignment… but I agree, the doc would read better if you didn’t have to go to another section to see the values. Chairs, Deborah – any comment on this?

Just to make sure I get my point through, I am not talking about the code point allocation, but just how many bits each field takes (for example: Is length field 8-bit or 7-bit? A bad example, just to illustrate the point). AFAIK, IANA section does not cover this information. If it is not provided, the reader/implementer may need to do a manual count.  But the encoding in this draft is so simple that you may not see the necessity, so up to you/the draft editor.

Regards,
Xian

Thanks for the nits – I’ll sort those out when LC is done.

Cheers

Matt

Hi, all,

I've reviewed this document and believe it is ready for publication.

I have one suggestion on the encoding section: could we add the bit number for each field explanation? It may be a bit redundant, but I find it usually clearer if we have such information in the text.

Others are just some nits:
1: s/Note that specification of the the use of the collected SRLGs is outside the scope of this document./Note that specification of the use of the collected SRLGs is outside the scope of this document.
2:s/SRLG information is for each hop is added to the Path RRO during Path message processing./SRLG information is added by each hop to the Path RRO during Path message processing.(?)
3: consider relocating the following sentence to the very beginning of this section(5.1), maybe?
A node SHOULD NOT add SRLG information without an explicit request for it being made by the ingress node in the Path message.
4: The points listed in Section 6.1 started with “o” are squeezed together in one paragraph; please rectify.

Regards,
Xian

From: Teas [mailto:teas-bounces@ietf.org] On Behalf Of Vishnu Pavan Beeram
Sent: 2016年4月29日 4:42
To: teas@ietf.org<mailto:teas@ietf.org>
Subject: [Teas] WG Last Call on draft-ietf-teas-rsvp-te-srlg-collect-05

All,
This starts a two week working group last call on
draft-ietf-teas-rsvp-te-srlg-collect-05.

The working group last call ends on Thursday, May 12th. Please
send your comments to the TEAS mailing list.

As is always the case, positive comments, e.g., "I've reviewed this
document and believe it is ready for publication", are welcome!
This is useful and important, even from authors.
Note, IPR has been disclosed on this draft.

Thanks,
Pavan (and Lou)