Re: [Teas] [Lsr] WG Last Call for draft-ietf-lsr-isis-rfc5316bis

Dhruv Dhody <dhruv.ietf@gmail.com> Thu, 04 March 2021 06:34 UTC

Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1D6EC3A13BC; Wed, 3 Mar 2021 22:34:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.087
X-Spam-Level:
X-Spam-Status: No, score=-2.087 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PDe6_BREU4VV; Wed, 3 Mar 2021 22:34:42 -0800 (PST)
Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DB9FB3A13B7; Wed, 3 Mar 2021 22:34:41 -0800 (PST)
Received: by mail-io1-xd32.google.com with SMTP id z13so28559538iox.8; Wed, 03 Mar 2021 22:34:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p3z8LXi25SJVMezrvh7kzHnlzEzImnGb6xzypUzHDGg=; b=PoerrmvVNzqP/5sMIpPPpgs2Yr6BOT5vAbqCum2rVpQkVVG2VIm5nBZocPNAK3mjbx ULPKJPVfWeOebfbsbORkX9H0Z2r2B2lbT8vgmSt1rbbO502JADt5B1sm4mW6H4YXCEG2 H8HP5dmyLJK8dYH4+W4PtrO62aFFpz6+IHX7mSMxX2PrG5ihrvxmTO30hJvWnVs+fhsB B5aFVKs86PDa/DsgWMr9WEUfm+u9hVMdu8t89Jp56xGQiYnt8V/oHK8UxpF9vcG8MHA+ Gnza6UKrDA1y8AbaZYd7sGB5R9kG5BN05xqDWSgN8dcV3C9EJw6Q78NP5v7aj0prtxZE Ra0Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p3z8LXi25SJVMezrvh7kzHnlzEzImnGb6xzypUzHDGg=; b=GzJgCeZ7SNWLCTdahwzm+40EeAfK29CgqVsRuQkvZUlAGZFE/MLLHV6fa2hP4GuBra 4SCr6zMXRFsDPJkc3YZizF4qAkKEwVntWRnhrvwiEvH/M4bXwF4on2pgNoZKpmwxzYAV A71kGR0Wg1GBhcUkdRzsWInjLK2niFcjNGh33HNo8fuhQD7/bvFRk+Iahv64lrYEKWGm ZOlyHmXd1UWl21Tm3lZ48v6beDqHEGV4SsDFghL0+3YW5/UZE/vzH8SFmd8W5vqrADKK XJKkELux3MU9Y4xmYDN6kUcXCgRqPAQZ9BqzWLRzVn6NY2zZaAfmzWb+zk+Akspmjt3c hqbw==
X-Gm-Message-State: AOAM532ReLYZ5LQM8JFcLcMNc1jb3yz1VyJHzanZ/6qLDUytRdSyqZQs zomQHa9CR5zJpp/muf/dsZnfdCyxdbrj7ziyJwM=
X-Google-Smtp-Source: ABdhPJwMicIFypBiMtDlmCrPnpYKvGcZMkTL5hbjxTkkpwfvWhRcp6y0LIdROk2+aEjVxWPqbw4BTXCxEGVEa/I8ecA=
X-Received: by 2002:a5d:9e09:: with SMTP id h9mr2546769ioh.178.1614839680186; Wed, 03 Mar 2021 22:34:40 -0800 (PST)
MIME-Version: 1.0
References: <A31F6308-B1A4-4CD7-AC71-BB6722CAC1A7@chopps.org> <CAB75xn6DydowRwgu6PsXFcPM9_ctx7Gvdmcu1CFrFQ5_Q3BJEg@mail.gmail.com> <BY5PR11MB4337222EFA921DBDF1DADBFFC1989@BY5PR11MB4337.namprd11.prod.outlook.com>
In-Reply-To: <BY5PR11MB4337222EFA921DBDF1DADBFFC1989@BY5PR11MB4337.namprd11.prod.outlook.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Thu, 4 Mar 2021 12:04:03 +0530
Message-ID: <CAB75xn7bq18G-hT4sL98Wwq7dDxXn53SmsDdKKU1ycFNAUMk0g@mail.gmail.com>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
Cc: Christian Hopps <chopps@chopps.org>, TEAS WG Chairs <teas-chairs@ietf.org>, "teas-ads@ietf.org" <teas-ads@ietf.org>, "TEAS WG (teas@ietf.org)" <teas@ietf.org>, "lsr-chairs@ietf.org" <lsr-chairs@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>, "lsr-ads@ietf.org" <lsr-ads@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000081bc4f05bcb02910"
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/OvymYlliZlGtpiLqe0YPyQ8ZL5I>
Subject: Re: [Teas] [Lsr] WG Last Call for draft-ietf-lsr-isis-rfc5316bis
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Mar 2021 06:34:44 -0000

Hi Les,
On Thu, Mar 4, 2021 at 1:17 AM Les Ginsberg (ginsberg) <ginsberg@cisco.com>
wrote:

> Dhruv -
>
>
>
> Thanx for reviewing/supporting the draft.
>
> Please see inline.
>
>
>
> > -----Original Message-----
>
> > From: Lsr <lsr-bounces@ietf.org> On Behalf Of Dhruv Dhody
>
> > Sent: Wednesday, March 03, 2021 2:09 AM
>
> > To: Christian Hopps <chopps@chopps.org>
>
> > Cc: TEAS WG Chairs <teas-chairs@ietf.org>rg>; teas-ads@ietf.org; TEAS WG
>
> > (teas@ietf.org) <teas@ietf.org>rg>; lsr-chairs@ietf.org; lsr@ietf.org; lsr-
>
> > ads@ietf.org
>
> > Subject: Re: [Lsr] [Teas] WG Last Call for draft-ietf-lsr-isis-rfc5316bis
>
> >
>
> > Hi,
>
> >
>
> > I went through the diff with RFC5316. The changes look good. Some
>
> > minor comments -
>
> >
>
> > (1) Is it wise to use normative keywords MUST and SHOULD in the
>
> > appendix? The text is from section 3.1 but can it be reworded in the
>
> > appendix? Also wondering if other changes (IANA, nits) could be listed
>
> > or we could call it "major change" :)
>
>
>
> [Les:] I personally do not have an issue using the normative keywords in
> the Appendix. Not doing so I think might trigger someone to ask if there is
> some inconsistency between the Appendix text and the text in the body of
> the draft. 😊
>
> If you know of some prohibition against using such keywords in an Appendix
> please provide the reference.
>
>
>
[Dhruv]: To me, the usefulness of this appendix is to find out what has
changed in this bis. Very useful for any reviewer or implementor. The other
option is to do rfcdiff :(

So in this context, I provided the above comments suggesting rewording the
text as a list of changes with rewording. Adding a reference to the
relevant section could be useful too. Feel free to ignore, if you think
this adds no value!

> The IANA change is a consequence of the introduction pf new  IPv6 Local
> ASBR identifier sub-TLV. I do not see the need to mention it in the
> Appendix.
>
>
>
> I do not understand your comment about "major change". Could you explain?
>
> [Dhruv]: The current text says -

Appendix A.  Changes to RFC 5316

   This document makes the following changes to RFC 5316.


This gives an impression (to me) that *all* changes made are listed here.
Since that is not what is happening here, I suggested calling it -
Important or Major or Motivation to update RFC 5316, whatever you like....


>
>
> >
>
> > (2) IPv6 Local ASBR ID and IPv6 Router ID is used interchangeably i.e.
>
> > table in IANA section 6.2 does not use the same name as the table in
>
> > section 3.1
>
> >
>
>
>
> [Les:] The use of " IPv6 Router ID" in Section 3.1 is inconsistent. I
> will fix that.
>
> Thanx for pointing that out.
>
>
>

Thanks!
Dhruv


>    Les
>
>
>
> > Hope this helps!
>
> >
>
> > Thanks!
>
> >
>
> > Dhruv
>
> >
>
> >
>
> >
>
> > On Wed, Feb 17, 2021 at 9:00 PM Christian Hopps <chopps@chopps.org>
>
> > wrote:
>
> > >
>
> > > Hi LSR and TEAS,
>
> > >
>
> > > This begins a joint WG last call for:
>
> > >
>
> > >   https://datatracker.ietf.org/doc/draft-ietf-lsr-isis-rfc5316bis/
>
> > >
>
> > > Please discuss any issues on the LSR mailing list. The WGLC will end
> March
>
> > 3, 2021.
>
> > >
>
> > > Authors, please indicate wether you are aware of any IPR related to
> this
>
> > document to the list.
>
> > >
>
> > > Thanks,
>
> > > Chris, Acee, (Lou and Pavan).
>
> > > _______________________________________________
>
> > > Teas mailing list
>
> > > Teas@ietf.org
>
> > > https://www.ietf.org/mailman/listinfo/teas
>
> >
>
> > _______________________________________________
>
> > Lsr mailing list
>
> > Lsr@ietf.org
>
> > https://www.ietf.org/mailman/listinfo/lsr
>