Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
	by ietfa.amsl.com (Postfix) with ESMTP id 4448AC18DBAB;
	Thu,  6 Jun 2024 23:58:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.094
X-Spam-Level: 
X-Spam-Status: No, score=-2.094 tagged_above=-999 required=5
	tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
	DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
	HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001,
	SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001,
	URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001]
	autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key)
	header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194])
	by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 6GVjKagufpkg; Thu,  6 Jun 2024 23:58:52 -0700 (PDT)
Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com
 [IPv6:2607:f8b0:4864:20::933])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest
 SHA256)
	(No client certificate requested)
	by ietfa.amsl.com (Postfix) with ESMTPS id 5B233C18DB8D;
	Thu,  6 Jun 2024 23:58:52 -0700 (PDT)
Received: by mail-ua1-x933.google.com with SMTP id
 a1e0cc1a2514c-80ae09dce70so1252445241.1;
        Thu, 06 Jun 2024 23:58:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1717743531; x=1718348331; darn=ietf.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=wyPi7tjaThp3vv1wpF2kuMu6034VP7RyqoibaNgR/CA=;
        b=hTnkT9yZeTsRP77Xie09nlOCT5eJRQgVTauqkZnNUCMpxAIAAS0vBAbUotXerIXBHj
         bIYK345y/mDAhn0/3ppjZ4o0tHLDfngJ/3BqOlDBET80bci8J7o+9gmuCwPENSXW4jY7
         oDuq7enxl5oEFPzNwamnI0Fl/tERhcUStGhCQTluIPsHdAvj3KK524jMOPPtxENBUYJk
         ktzwNQCAvQu5T7hwGarAfuax6VYAepyIzu8ISIaKbw6ev4p7QTv5opt/xHNEEiRdwVxc
         hX8OxUcsTtfy/xJndZQqQhuGPRDkkUUDq4qu3mEfwTLZCeoR09I67z2AI8ANALdyydKO
         68vQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1717743531; x=1718348331;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=wyPi7tjaThp3vv1wpF2kuMu6034VP7RyqoibaNgR/CA=;
        b=kZwZTYNLn32o9clK1wG1dn/NV8nZcjmCSdsTy8f5tteeoEk2Bd018fUMjl6PDLaJji
         P5weeSV9iKJ3Zr+V3qLbYVKItqFOAuLCaLSYqAYFBWR4actsIIywIMxe3Xs4CpMQpLV2
         XvAzdtxDBia/TxkUZ0k/dqb6Vx8a80H0b2lhNYJbiN7VZERta2gWyFxYzKc1F3jri6QP
         MhlXkC+S6Fkeu5MSifltam38iNXtcVwmrsDhDhtbq35m8pJOZO58YhcuabZEWtk/HADe
         WyhJYWn0YtSoq1ryVhOb/yOz0P/iU9p2OiuNKZcZh45RR9ACZszPhl+15xkixQJ7Hwfr
         avJQ==
X-Forwarded-Encrypted: i=1;
 AJvYcCV12BapeiVBCdbLulroE2PkTB1Go+l5V3AVGc7JnnD+2bh863SgxGEwDMvsw3to2fBGFyOy3JgyWbuhCAE6qu7z+Rfp81d0AXdbIPVnpkQi/zlTa8QgLjrY7sy+/3mRB+jeF+AaFL1Y0mYb8XBZhIz65TMs3SLhPbCAo55z
X-Gm-Message-State: AOJu0YywI5902hhK1X/rkl6YyLrsQsgkvM4ORGzhe5gsB6Bv/Ko573bF
	lC+LsjVWudRLMDJsVpab0HPZVtH88QliOVyzNygLmAG9d2XXCIh1/4AkSWOUG+Xj8WxdQ/7rXHn
	oajGafmjuJsAybxb6m1Z6Jo2hKmjACYpHZLdTsQ==
X-Google-Smtp-Source: 
 AGHT+IFncVRiyL5JKiP6nqhN4Q0imrR2sdf66kmmGA9PEgq2A0OsVL4dcLOet901O7YjZBGSMThtkx0zgSelXF/Bc9A=
X-Received: by 2002:a67:bb06:0:b0:48b:dc86:6154 with SMTP id
 ada2fe7eead31-48c16eebc9bmr5003904137.4.1717743531065; Thu, 06 Jun 2024
 23:58:51 -0700 (PDT)
MIME-Version: 1.0
References: <171773385108.61448.2237900893031611266@ietfa.amsl.com>
In-Reply-To: <171773385108.61448.2237900893031611266@ietfa.amsl.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Fri, 7 Jun 2024 07:58:14 +0100
Message-ID: 
 <CAB75xn79fAaR17+38criZ+ZrHXg_fMw8bd_B4MN9MusLD_-aOQ@mail.gmail.com>
To: Shivan Sahib <shivankaulsahib@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000fc094d061a475458"
Message-ID-Hash: OBZO5KD3DOD4LKGWP5ZUCZY7I4R2VIFS
X-Message-ID-Hash: OBZO5KD3DOD4LKGWP5ZUCZY7I4R2VIFS
X-MailFrom: dhruv.ietf@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency;
 loop; banned-address; member-moderation; header-match-teas.ietf.org-0;
 nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size;
 news-moderation; no-subject; digests; suspicious-header
CC: secdir@ietf.org, draft-ietf-teas-actn-vn-yang.all@ietf.org,
 last-call@ietf.org, teas@ietf.org
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: =?utf-8?q?=5BTeas=5D_Re=3A_Secdir_last_call_review_of_draft-ietf-teas-actn-v?=
	=?utf-8?q?n-yang-26?=
List-Id: Traffic Engineering Architecture and Signaling working group
 discussion list <teas.ietf.org>
Archived-At: 
 <https://mailarchive.ietf.org/arch/msg/teas/YtEFTvcrPdoRlMqZzBNH05O2yKU>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Owner: <mailto:teas-owner@ietf.org>
List-Post: <mailto:teas@ietf.org>
List-Subscribe: <mailto:teas-join@ietf.org>
List-Unsubscribe: <mailto:teas-leave@ietf.org>

--000000000000fc094d061a475458
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Shivan,

On Fri, Jun 7, 2024 at 5:17=E2=80=AFAM Shivan Sahib via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Shivan Sahib
> Review result: Ready
>
> I found the descriptions of sensitive data nodes in Security Consideratio=
ns
> useful. I'm sure they'll be helpful to implementers.
>
> nit: In Security Considerations, "Therefore, many security risks such as
> malicious attack and rogue elements attempting to connect to various ACTN
> components." is incomplete.
>
>
Dhruv: Ack, updated.



> nit: in Introduction, "Abstraction and Control of Traffic Engineered
> Networks
> (ACTN) describes a set of management and control functions used to operat=
e
> one
> or more TE networks to construct Virtual Network (VN) that can be
> represented
> to customers and that are built from abstractions of the underlying TE
> networks
> [RFC8453]" reads awkwardly. Also "TE" is not defined before being used
> (it's
> defined in the reference).
>
>
Dhruv: Ack, updated.

Diff:
https://author-tools.ietf.org/iddiff?url1=3Ddraft-ietf-teas-actn-vn-yang-26=
&url2=3Ddraft-ietf-teas-actn-vn-yang-27&difftype=3D--html

Thanks!
Dhruv

--000000000000fc094d061a475458
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:&quot;trebuchet ms&quot;,sans-serif;font-size:small;color:rgb(7,55=
,99)">Hi Shivan,</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr"=
 class=3D"gmail_attr">On Fri, Jun 7, 2024 at 5:17=E2=80=AFAM Shivan Sahib v=
ia Datatracker &lt;<a href=3D"mailto:noreply@ietf.org">noreply@ietf.org</a>=
&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Revi=
ewer: Shivan Sahib<br>
Review result: Ready<br>
<br>
I found the descriptions of sensitive data nodes in Security Considerations=
<br>
useful. I&#39;m sure they&#39;ll be helpful to implementers.<br>
<br>
nit: In Security Considerations, &quot;Therefore, many security risks such =
as<br>
malicious attack and rogue elements attempting to connect to various ACTN<b=
r>
components.&quot; is incomplete.<br>
<br></blockquote><div><br></div><div><div class=3D"gmail_default" style=3D"=
font-family:&quot;trebuchet ms&quot;,sans-serif;font-size:small;color:rgb(7=
,55,99)">Dhruv: Ack, updated.</div><br></div><div>=C2=A0</div><blockquote c=
lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli=
d rgb(204,204,204);padding-left:1ex">
nit: in Introduction, &quot;Abstraction and Control of Traffic Engineered N=
etworks<br>
(ACTN) describes a set of management and control functions used to operate =
one<br>
or more TE networks to construct Virtual Network (VN) that can be represent=
ed<br>
to customers and that are built from abstractions of the underlying TE netw=
orks<br>
[RFC8453]&quot; reads awkwardly. Also &quot;TE&quot; is not defined before =
being used (it&#39;s<br>
defined in the reference).<br>
<br></blockquote><div><br></div><div class=3D"gmail_default" style=3D"font-=
family:&quot;trebuchet ms&quot;,sans-serif;font-size:small;color:rgb(7,55,9=
9)">Dhruv: Ack, updated.=C2=A0</div><div class=3D"gmail_default" style=3D"f=
ont-family:&quot;trebuchet ms&quot;,sans-serif;font-size:small;color:rgb(7,=
55,99)"><br></div><div class=3D"gmail_default" style=3D"font-family:&quot;t=
rebuchet ms&quot;,sans-serif;font-size:small;color:rgb(7,55,99)">Diff:=C2=
=A0<a href=3D"https://author-tools.ietf.org/iddiff?url1=3Ddraft-ietf-teas-a=
ctn-vn-yang-26&amp;url2=3Ddraft-ietf-teas-actn-vn-yang-27&amp;difftype=3D--=
html">https://author-tools.ietf.org/iddiff?url1=3Ddraft-ietf-teas-actn-vn-y=
ang-26&amp;url2=3Ddraft-ietf-teas-actn-vn-yang-27&amp;difftype=3D--html</a>=
</div><div class=3D"gmail_default" style=3D"font-family:&quot;trebuchet ms&=
quot;,sans-serif;font-size:small;color:rgb(7,55,99)"><br></div><div class=
=3D"gmail_default" style=3D"font-family:&quot;trebuchet ms&quot;,sans-serif=
;font-size:small;color:rgb(7,55,99)">Thanks!</div><div class=3D"gmail_defau=
lt" style=3D"font-family:&quot;trebuchet ms&quot;,sans-serif;font-size:smal=
l;color:rgb(7,55,99)">Dhruv</div></div></div>

--000000000000fc094d061a475458--

