[Teas] Re: Mahesh Jethanandani's No Objection on draft-ietf-teas-actn-vn-yang-26: (with COMMENT)

Dhruv Dhody <dhruv.ietf@gmail.com> Fri, 07 June 2024 06:58 UTC

Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 38B42C1CAF38; Thu, 6 Jun 2024 23:58:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.094
X-Spam-Level:
X-Spam-Status: No, score=-2.094 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tAChgnUwaxPa; Thu, 6 Jun 2024 23:58:42 -0700 (PDT)
Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [IPv6:2607:f8b0:4864:20::92f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 15DFBC18DB8F; Thu, 6 Jun 2024 23:58:42 -0700 (PDT)
Received: by mail-ua1-x92f.google.com with SMTP id a1e0cc1a2514c-80ac32af232so507611241.2; Thu, 06 Jun 2024 23:58:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717743521; x=1718348321; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6yS8fwnIiH4aclOokTlBnbV7hTItOxOfKHXaervJaeM=; b=LqnU5hPk7kJcY6VAjcBIKIo6ud9qGERv6SrJ5ARtFDQ8tgbm76pSZj0r5CQDcqEfHa FCYiXtMWfKxdPsC+u6JQdSVvi5GUMqjnu1WGq8JxsdhtN+z8Bl5qvE4MxTFUp9a8SfpT Zikex1MLvTLtl0zDFC2aZslSgQ1HnqswiZ8jmLXNiT8bFgHVTl2+/LUq8oahhEx1AWQ5 QBn11KbxPUDXC+kT+pW7MwkVH+1d2hwmb7aHm2VbXwKUAEDWtZN9Embdetn6Nzps7qCg Yi6v/uHnGeB2MXqOYrR92rARmuXbLYFBg6PVN9w3N5WuFTVUXVRi2IWmXdF05CK7WmB2 ijrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717743521; x=1718348321; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6yS8fwnIiH4aclOokTlBnbV7hTItOxOfKHXaervJaeM=; b=XBPqoeU8yWFLzhRTufZqXQANunbxtV2lNuzJJwcILDc36OeoXqaXfh/ywuXhlO+bfY 7mYy2Qvv/xkEOuTZaiA72ghKBxYd+kKrp1tLluUglwsjIK47eyqPcdaHHyRvE2WOkmRy +q78FHVjwsjUdyaC+soYGATBXqaRKEFNzsPKkvnVrEBjHzOcS+T3h0cmG2RLnTghFw5Q 4Qd4O4pf+AWczYtTcPbp060QzFEsOi1RrrpvDeIBlpvZ0oa197nRiJCtOY97e5QVjblo s+qBbhWLAhphjRNoeoH4QbPJHPkYmRAi+o/PTYVbSqd0wCnWHfGz4XOa1wF9YD76BWF1 Y2Cg==
X-Forwarded-Encrypted: i=1; AJvYcCWatMfXLbWDbkKnscM9kPJIqnBpRiuijOErtHmyc9gKsUFOFBv9BUr42gtCmv+f15uMBWaf6PKjU6hi63S3BUsSLdHX49ejD0mU+4vIvL+7UqqSR9QiS4DHYmgPZZ3oaeZyxZWpl2Sol2Ipt0Q+3Xg54rtq7WHZw0U3Wg==
X-Gm-Message-State: AOJu0YzOPkKn3OPzxQtDFv5bCYWevNebTOU4NH65HAYuGviMHYcFb4Nz ACe7mV7k3fVTYxLkqAtheg/FUc83J9pQ1QzYJka/dtwVACzwI89Mq4vNC86JDYwwIetu4i97A4d bqzYEre9DAfjZGqtzyqcgAPv711w=
X-Google-Smtp-Source: AGHT+IEfF7w5VqWeifISeE+imAhAjw9ldUOHgyU+n9ZmcOXQvciSUmKyt18AgyPLxh8iYpQ5gNKvJMu1laJ8Nmyqqr0=
X-Received: by 2002:a05:6102:d1:b0:47c:3045:21de with SMTP id ada2fe7eead31-48c2730fd42mr1665640137.11.1717743520995; Thu, 06 Jun 2024 23:58:40 -0700 (PDT)
MIME-Version: 1.0
References: <171763724944.20645.7859164476586035283@ietfa.amsl.com>
In-Reply-To: <171763724944.20645.7859164476586035283@ietfa.amsl.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Fri, 07 Jun 2024 07:58:04 +0100
Message-ID: <CAB75xn5MOvjbi5i_5Emz6=AWOfDPSXFkT_ZmrV3S3DgFVm337g@mail.gmail.com>
To: Mahesh Jethanandani <mjethanandani@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000625fd8061a4754f1"
Message-ID-Hash: AKHUITGVPGNGZ7GTCBKNYJQ2VTBIVJJ4
X-Message-ID-Hash: AKHUITGVPGNGZ7GTCBKNYJQ2VTBIVJJ4
X-MailFrom: dhruv.ietf@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-teas.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: The IESG <iesg@ietf.org>, draft-ietf-teas-actn-vn-yang@ietf.org, teas-chairs@ietf.org, teas@ietf.org, vbeeram@juniper.net
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Teas] Re: Mahesh Jethanandani's No Objection on draft-ietf-teas-actn-vn-yang-26: (with COMMENT)
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/b2ub2PRd2xLkvdXFsdVoW2xD5r0>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Owner: <mailto:teas-owner@ietf.org>
List-Post: <mailto:teas@ietf.org>
List-Subscribe: <mailto:teas-join@ietf.org>
List-Unsubscribe: <mailto:teas-leave@ietf.org>

Hi Mahesh,

Thanks for your review.

On Thu, Jun 6, 2024 at 2:27 AM Mahesh Jethanandani via Datatracker <
noreply@ietf.org> wrote:

> Mahesh Jethanandani has entered the following ballot position for
> draft-ietf-teas-actn-vn-yang-26: No Objection
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to
> https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/
> for more information about how to handle DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-teas-actn-vn-yang/
>
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Section 1, paragraph 11
> >    The VN operational state is included in the same tree as the
> >    configuration consistent with Network Management Datastore
> >    Architecture (NMDA) [RFC8342].  The origin of the data is indicated
> >    as per the origin metadata annotation.
>
> The last statement is not clear to me. What "data" is being referred to?
> What
> is "origin metadata annotation"?
>
>
Dhruv: It was referring to
https://datatracker.ietf.org/doc/html/rfc8342#section-5.3.4, but I can
remove that sentence as there is no need for this document to highlight it.



> Section 1.1, paragraph 1
> >    Refer to [RFC8453], [RFC7926], and [RFC8309] for the key terms used
> >    in this document.
>
> I support Francesca's comment here. In addition, I expect the document to
> highlight which key terms in this document are being "imported" from the
> other
> documents. More than that, what would be helpful would be have a table that
> contains a list of acronyms used in the document.
>
>
Dhruv: added.



> Section 4.3.3, paragraph 3
> >    Note that the YANG model is tightly coupled with the TE Topology
> >    model [RFC8795].  Any underlay technology not supported by [RFC8795]
> >    is also not supported by this model.  The model does include an empty
> >    container called "underlay" that can be augmented.  For example the
> >    SR-policy information can be augmented for the SR underlay by a
> >    future model.
>
> Based on the first sentence, it is clear that this is not a generic Virtual
> Network YANG model. Why then call it that? Why not call it a TE Virtual
> Network
> YANG model, and leave room for someone to define a generic VN model?
>
>
Dhruv: With the use of the 'underlay' container we hope that this model
could be used for non-TE cases. There is also work in TEAS to allow the TE
topology model to be more generic with profiles.



> Section 6, paragraph 30
> >      grouping vn-ap {
>
> I see a single uses statement for this grouping. Is this grouping expected
> to
> be used by other modules? If not, why not inline the grouping where it is
> being
> used?
>
> Section 6, paragraph 30
> >      grouping access-point {
>
> Similar comment here. I see a single uses statement for this grouping. If
> this
> grouping is not expected to be used by other modules, why not inline the
> grouping where it is being used?
>
>
Dhruv: I have collapsed both of these.



> Section 6, paragraph 30
> >          leaf multi-src {
> >            if-feature "multi-src-dest";
> >            type boolean;
> >            default "false";
> >            description
> >              "Is the source part of multi-source, where
> >               only one of the source is enabled";
> >          }
>
> Is there no requirement to know what are the other sources? As structured,
> if
> this boolean is true, only one source can be stored as part of the module.
> Which of the multiple 'src' will be stored in 'leaf src'? In other words
> should
> 'container src' not contain a 'list src' with 'src', 'src-vn-ap-id' as
> members
> of the list?
>
>
Dhruv: A VN member is one src and one dest and there is a list of VN
members. A subset of VN members are enabled with multi-src and in that case
only 1 of them is finally selected which is identified by if-selected leaf.

To answer your question, one can find out other sources by looking through
the VN member list.



>
> -------------------------------------------------------------------------------
> NIT
>
> -------------------------------------------------------------------------------
>
> All comments below are about very minor potential issues that you may
> choose to
> address in some way - or ignore - as you see fit. Some were flagged by
> automated tools (via https://github.com/larseggert/ietf-reviewtool) so
> there
> will likely be some false positives. There is no need to let me know what
> you
> did with these suggestions.
>
> Section 1, paragraph 10
> >  that, what would be helpful would be have a table that contains a list
> of ac
> >                                    ^^^^^^^
> Consider using only "have" or the present participle "be having".
>
> Section 1.3, paragraph 4
> > inks, intra-domain | paths, and inter- domain links. If we were to
> create a V
> >                                 ^^^^^^^^^^^^^
> This word seems to be formatted incorrectly. Consider fixing the spacing or
> removing the hyphen completely.
>
> Section 2.1, paragraph 7
> > ogies (a single node topology AN1 and a underlay topology (with nodes S1
> to S
> >                                       ^
> Use "an" instead of "a" if the following word starts with a vowel sound,
> e.g.
> "an article", "an hour".
>
> Section 3.2, paragraph 12
> >  in the [RFC8454]. It also allows to group the set of edge-to-edge links
> (i.e
> >                                   ^^^^^^^^
> Did you mean "grouping"? Or maybe you should add a pronoun? In active
> voice,
> "allow" + "to" takes an object, usually a pronoun.
>
> Section 4.3.1, paragraph 2
> > y is used to convey the result of the each VN member as a reference to
> the c
> >                                   ^^^^^^^^
> Two determiners in a row. Choose either "the" or "each".
>
> Section 4.3.1, paragraph 15
> > set by customer, making for a simplified operations for the customer. -
> VN Ty
> >                             ^^^^^^^^^^^^^^^^^^^^^^^
> The plural noun "operations" cannot be used with the article "a". Did you
> mean
> "a simplified operation" or "simplified operations"?
>
>
Dhruv: Ack.

Diff:
https://author-tools.ietf.org/iddiff?url1=draft-ietf-teas-actn-vn-yang-26&url2=draft-ietf-teas-actn-vn-yang-27&difftype=--html

Thanks,
Dhruv