Re: [Teas] WG Last Call: draft-ietf-teas-pce-native-ip-06

Aijun Wang <wangaijun@tsinghua.org.cn> Fri, 29 May 2020 15:09 UTC

Return-Path: <wangaijun@tsinghua.org.cn>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F40D73A0B09 for <teas@ietfa.amsl.com>; Fri, 29 May 2020 08:09:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DynwXkoSuSVN for <teas@ietfa.amsl.com>; Fri, 29 May 2020 08:09:16 -0700 (PDT)
Received: from m176115.mail.qiye.163.com (m176115.mail.qiye.163.com [59.111.176.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ECBC73A0B11 for <teas@ietf.org>; Fri, 29 May 2020 08:09:13 -0700 (PDT)
Received: from [100.24.3.61] (unknown [106.121.152.2]) by m176115.mail.qiye.163.com (Hmail) with ESMTPA id 604A2665004; Fri, 29 May 2020 23:09:04 +0800 (CST)
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: Aijun Wang <wangaijun@tsinghua.org.cn>
Mime-Version: 1.0 (1.0)
Date: Fri, 29 May 2020 23:09:03 +0800
Message-Id: <E1ED4696-966B-46A7-AB0D-B8BAE5EACA6E@tsinghua.org.cn>
References: <CAB75xn5ht3QVVdpV_R8FHQWwjMKAUB=MLEOrGHb-5kSo8oKLow@mail.gmail.com>
Cc: Lou Berger <lberger@labn.net>, TEAS WG <teas@ietf.org>
In-Reply-To: <CAB75xn5ht3QVVdpV_R8FHQWwjMKAUB=MLEOrGHb-5kSo8oKLow@mail.gmail.com>
To: Dhruv Dhody <dhruv.ietf@gmail.com>
X-Mailer: iPhone Mail (17E262)
X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZSFVKTkJCQkJDT0xPSklKSllXWShZQU pMS0tKN1dZLVlBSVdZDwkaFQgSH1lBWQ9OKzI4HD8jTUI8KjEfPR4BGCIaOjpWVlVJQk1LKElZV1 kJDhceCFlBWTU0KTY6NyQpLjc#WVdZFhoPEhUdFFlBWTQwWQY+
X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PjI6MBw4EzgyKxoPQh4XGgwj IU0aFD5VSlVKTkJLTE1PQk9CQktLVTMWGhIXVQwaFRwaEhEOFTsPCBIVHBMOGlUUCRxVGBVFWVdZ EgtZQVlKS01VSklKVUpOSVVJWVdZCAFZQU1MT0w3Bg++
X-HM-Tid: 0a7260fabc0b9373kuws604a2665004
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/clMifuuedDkIuqRVbnVO2b42rb0>
Subject: Re: [Teas] WG Last Call: draft-ietf-teas-pce-native-ip-06
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 May 2020 15:09:19 -0000

Hi, Dhruv:
Thanks for your comments.
We will update the draft in next week to reflect/resolve your comments. The details responses will come along at the same time.

Any other comments are all welcome.

Aijun Wang
China Telecom

> On May 29, 2020, at 20:47, Dhruv Dhody <dhruv.ietf@gmail.com> wrote:
> 
> Hi WG, Authors,
> 
> As an experimental framework based on RFC 8735, I am fine with
> publication of this document. But I do have comments and thoughts on
> what is missing in this I-D. Request authors and shepherd to consider
> them before we ship this out of the WG.
> 
> (1) I find the term "Dual/Multi-" used throughout in this document to
> be bit weird. Well 'multi-' includes 'dual-' :)
> 
> (2) We need to add some text that describes the experimental nature of
> this work. Something in line with
> 
>   The procedures described in this document are experimental.  The
>   experiment is intended to enable research for the usage of PCE in
>   native IP scenarios.  For this purpose, this document describe the
>   CCDR framework and the PCEP extension is specified in
>   [I-D.ietf-pce-pcep-extension-native-ip].
> 
> (3) Section 1
> 
> We should be clear on where are these requirements coming from. Can we
> say that they are based on the scenarios listed in RFC 8735(?), so it
> does not read out of place. More importantly, the list is a mix of
> technology choices, deployment limitations, and abstract philosophy;
> calling them requirement may be a stretch. Further,
> 
>   o  No complex Multiprotocol Label Switching (MPLS) signaling
>      procedures.
> 
>    Why signaling alone? Isn't data-plane as native IP, one of the key
>    requirements?
> 
>   o  End to End traffic assurance, determined Quality of Service (QoS)
>      behavior.
> 
>    Should we specify that this in the control plane?
> 
>    o  Flexible deployment and automation control.
> 
>    IMHO too generic (and marketing).
> 
> Also, please describe CCDR in the Introduction. Jumping directly into
> example in section 4 is not right.
> 
> (4) If you don't use RFC 2119 keywords, then remove section 2.
> 
> (5) Section 4,
> 
> - you should be explicit that IP11, IP12 are IP prefix.
> - you need to describe the term "explicit peer routes"? How is it
>  different from a static route?
> - I think we should say that section 4 is only for illustrative
>  purpose
> - I am not sure why the description is in terms of address pairs
>  (IP11, IP21) and (IP12, IP22) - what happens if one sends traffic
>  from IP11 to IP22? I guess the forwarding would be based on
>  destination IP22 and the traffic would be sent to the link
>  associated with it? Doesn't it make more sense to describe things in
>  terms of IP prefix?
> 
> (6) Section 6, you have -
> 
>   It is almost impossible to provide an End-to-End (E2E) path with
>   latency, jitter, packet loss constraints to meet the above
>   requirements in large scale IP-based network via the distributed
>   routing protocol...
> 
> Well flex-algo to some extent could do this. So maybe reword this...
> Also, consider avoiding using term flow and focus on just prefix.
> 
> (7) Section 7, Add some text on -
> 
> - the loopback address used for the multi-BGP session. Do they exist
>  at edge routers/RR already and PCE selects them?
> - how does PCE learn the prefix and QoS requirement
> 
> (8) Section 9.2,
> 
>   If one node on the optimal path is failed, the priority traffic will
>   fall over to the best-effort forwarding path.  One can even design
>   several assurance paths to load balance/hot-standby the priority
>   traffic to meet the path failure situation, as done in MPLS Fast
>   Reroute (FRR).
> 
> Not sure how MPLS FRR is applicable here (perhaps IP FRR for static
> routes)?
> 
> (9) Section 10,
> 
>   The PCE should have the capability to calculate the loop-free E2E
>   path upon the status of network condition and the service
>   requirements in real time.
> 
> This is true for any PCE, don't think it belongs in Security
> consideration. This section needs to be improved as one can use PCEP
> to create bogus BGP sessions and we need to consider what would be
> impact on that. Further what would be the impact of incorrect prefix,
> can this be used to misdirect traffic.
> 
> (10) Other considerations - Few things that are missing -
> 
> - PCE and PCEP considerations - Stateful nature of PCE, path state at
>  the PCE, synchronization of the state etc
> - Multi-domain case - as that is listed as a key benefit of CCDR.
> - Impact of dynamic BGP session created based on CCDR.
> - Impact of "explicit peer routes" and their interaction with other
>  routes.
> - Document does not mention removal and modification at all
> - Comparison to other techniques is distributed in various section,
>  maybe collect them in appendix
> 
> 
> (11) Nits
> - I suggest following the abbreviation guideline as per
>  https://www.rfc-editor.org/materials/abbrev.expansion.txt; I see
>  some well-known terms (BGP, PCE) expanded. Look for (*) in the link.
> - Remove "Draft" in section 1 - "Draft [RFC8735] describes..."
> - Section 1, s/differentiation/different/
> - Not a good idea to have Lo0, Lo1 on both R1 and R2 - perhaps Lo11,
>  Lo12 and Lo21, Lo22?
> - Add reference for BGP stuff like RR
> 
> Thanks!
> Dhruv
> 
> _______________________________________________
> Teas mailing list
> Teas@ietf.org
> https://www.ietf.org/mailman/listinfo/teas