Re: [Teas] RtgDir review: draft-ietf-teas-assoc-corouted-bidir-frr-04

"Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com> Mon, 30 July 2018 15:22 UTC

Return-Path: <rgandhi@cisco.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8A1FD1310F9; Mon, 30 Jul 2018 08:22:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.499
X-Spam-Level:
X-Spam-Status: No, score=-14.499 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01, T_HTML_ATTACH=0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S3HDKgG_QaHH; Mon, 30 Jul 2018 08:22:28 -0700 (PDT)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E88691310F8; Mon, 30 Jul 2018 08:22:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=111703; q=dns/txt; s=iport; t=1532964147; x=1534173747; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=4hSwiVaCQVcsyLYhPp1oupts3wlyANPB8r2OQym5HwA=; b=NLG/DRNkJB3fFJ4TaPq6oDDU6SHNUD4MDgkEorbMoMjjHG6XbC8Hv6eq yvk5YRCKH56/tbS5tq1QwfbxuZ/ecrhxyLQ7RW6g+wG6UEEtj0alBK9PE FBEsg4bRoahQgN8hCEUGO0CO8pOTQguKDj/6a1QhnL9zuRJfRkkZE2h2E g=;
X-Files: Diff draft-ietf-teas-assoc-corouted-bidir-frr-04.txt - draft-ietf-teas-assoc-corouted-bidir-frr-05.txt.html : 51735
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CfAADoD19b/4gNJK1bGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAYJXSS5jfygKg3SBX4YnjDyBaCWHLoEUjQ8UgWYLJYMQgTc?= =?us-ascii?q?CF4J8ITQYAQIBAQIBAQJtHAyFNgEBAQEDGgkEBjkTEAIBBgIRAQIBAiEBCQI?= =?us-ascii?q?CAh8RFwYIAQEEAQ0FDoMSAYFnAxUPj1GbR3szH4ZzDYMbD4kCF4FBP4ERASc?= =?us-ascii?q?ME4JMghFFOgsBAQIBF4EUARIBJgcSBhKCSTGCJAKHfYkHgxmFSCsJAoNlgjC?= =?us-ascii?q?CZoMugwyBSEWDVYJxhTaKUFOGbQIRFIEkDRA4YXFwFRpLAYI+CYFsMBeIWYU?= =?us-ascii?q?+bwGNAwcIF4EIgRsBAQ?=
X-IronPort-AV: E=Sophos;i="5.51,422,1526342400"; d="html'217?scan'217,208,217";a="430855372"
Received: from alln-core-3.cisco.com ([173.36.13.136]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2018 15:22:24 +0000
Received: from XCH-RCD-016.cisco.com (xch-rcd-016.cisco.com [173.37.102.26]) by alln-core-3.cisco.com (8.15.2/8.15.2) with ESMTPS id w6UFMOsD010524 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 30 Jul 2018 15:22:24 GMT
Received: from xch-aln-018.cisco.com (173.36.7.28) by XCH-RCD-016.cisco.com (173.37.102.26) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 30 Jul 2018 10:22:23 -0500
Received: from xch-aln-018.cisco.com ([173.36.7.28]) by XCH-ALN-018.cisco.com ([173.36.7.28]) with mapi id 15.00.1320.000; Mon, 30 Jul 2018 10:22:23 -0500
From: "Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com>
To: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>, "<rtg-ads@ietf.org> (rtg-ads@ietf.org)" <rtg-ads@ietf.org>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "TEAS WG (teas@ietf.org)" <teas@ietf.org>, "draft-ietf-teas-assoc-corouted-bidir-frr.all@ietf.org" <draft-ietf-teas-assoc-corouted-bidir-frr.all@ietf.org>
Thread-Topic: RtgDir review: draft-ietf-teas-assoc-corouted-bidir-frr-04
Thread-Index: AdQlm/SWFN83nAOVQmKg2miyrumEwAChYgCA
Date: Mon, 30 Jul 2018 15:22:23 +0000
Message-ID: <5A4119B4-94E1-4AD9-8300-39F27AE195F8@cisco.com>
References: <HE1PR07MB16756BF063D9275ADE82E1E4F0290@HE1PR07MB1675.eurprd07.prod.outlook.com>
In-Reply-To: <HE1PR07MB16756BF063D9275ADE82E1E4F0290@HE1PR07MB1675.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.1d.0.161209
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.82.253.233]
Content-Type: multipart/mixed; boundary="_004_5A4119B494E14AD9830039F27AE195F8ciscocom_"
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.37.102.26, xch-rcd-016.cisco.com
X-Outbound-Node: alln-core-3.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/fRu5wtK808-Kfhs6TAGUgwdzJyc>
Subject: Re: [Teas] RtgDir review: draft-ietf-teas-assoc-corouted-bidir-frr-04
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jul 2018 15:22:34 -0000

Hi Daniele,

Many thanks for the review of the document and your suggestions.
Diff file is for the updated document is attached.
Please see inline <RG>…

From: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
Date: Saturday, July 28, 2018 at 10:28 AM
To: "<rtg-ads@ietf.org> (rtg-ads@ietf.org)" <rtg-ads@ietf.org>
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>rg>, "TEAS WG (teas@ietf.org)" <teas@ietf.org>rg>, "draft-ietf-teas-assoc-corouted-bidir-frr.all@ietf.org" <draft-ietf-teas-assoc-corouted-bidir-frr.all@ietf.org>
Subject: RtgDir review: draft-ietf-teas-assoc-corouted-bidir-frr-04
Resent-From: <alias-bounces@ietf.org>
Resent-To: "=SMTP:rgandhi@cisco. com" <rgandhi@cisco.com>om>, <hshah@ciena.com>om>, <jeremy.whittaker@verizon.com>om>, Lou Berger <lberger@labn.net>et>, <mhartley.ietf@gmail.com>om>, <vbeeram@juniper.net>et>, <martin.vigoureux@nokia.com>om>, DEBORAH BRUNGARD <db3546@att.com>om>, <aretana.ietf@gmail.com>om>, Vishnu Beeram <vishnupavan@gmail.com>om>, <vishnupavan@gmail.com>
Resent-Date: Saturday, July 28, 2018 at 10:28 AM


Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir<http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir>

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-teas-assoc-corouted-bidir-frr-04
Reviewer: Daniele Ceccarelli
Review Date: 27/07/2018
IETF LC End Date: date-if-known
Intended Status: Standard track

Summary:



  *   I have some minor concerns about this document that I think should be resolved before publication.

Comments:

  *   The document is very well written and the problem clearly stated (even if called overview 😊 ). The second part is a bit harder to follow but I don’t see how to make the procedure section easier to read.
<RG> Ok, thanks.

  *   It is not clear to me why there is an “example” of Extended Association ID in the appendix. RFC 6780 just says it “contains data that is additional information to support unique identification.” But doesn’t describe how it should be filled. Does this mean there is no standard format for it?
<RG> Right. Example shown in the Appendix is one un-ambiguous way to populate it for associated bidirectional LSPs.

Major Issues:

None

Minor Issues:

  *   Moving the terminology section before the introduction would improve readability, since the terms defined in the terminology section are frequently used in the introduction.
<RG> I am not familiar with an RFC where terminology is the first section. I am fine either way, please let me know if you prefer this way.

  *   When I read the title of section 3 (overview), I thought “why an overview is needed if there is an introduction?”. Actually the text in that section is very useful but more than an overview I would call it a problem statement (or something like that).
<RG> Corrected.

  *   The usage of RFC 2119 (or should we reference RFC 8174 ??) is not congruent all over the document. E.g. section 4.1

  o  The downstream PLR node always initiates the bypass tunnel

      assignment for the forward LSP.  The upstream PLR (forward

      direction LSP MP) node simply reflects the associated bypass

      tunnel assignment for the reverse direction LSP.  The upstream PLR

      node MUST NOT initiate the bypass tunnel assignment.



<RG> Corrected.

Nits:

  *   Section1: “(G)Multiprotocol Label Switching (MPLS) Traffic Engineering (TE) Label Switched Paths (LSPs)”. This formatting doesn’t make much sense. In the first instance the brackets are used to say MPLS or GMPLS while in the other ones to define the acronyms.
<RG> Corrected.

  *   Section 3.1 there is no need to repeat twice that Bypass tunnel N uses path B-H-I-C and Bypass tunnel S path B-F-G-C. The second time the bracket can be dropped.
<RG> Corrected.

  *   Section 4.1.1. -  s/SHOULD trigger the procedure/ SHOULD trigger procedure
<RG> Corrected.
Thanks,
Rakesh (for authors)


BR
Daniele