Re: [Teas] WG Last Call: draft-ietf-teas-yang-path-computation-18

t petch <ietfa@btconnect.com> Mon, 20 June 2022 11:17 UTC

Return-Path: <ietfa@btconnect.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 87757C14F73E; Mon, 20 Jun 2022 04:17:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.786
X-Spam-Level:
X-Spam-Status: No, score=-3.786 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, NICE_REPLY_A=-1.876, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O6_6T3QPkqMM; Mon, 20 Jun 2022 04:17:20 -0700 (PDT)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60134.outbound.protection.outlook.com [40.107.6.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D0554C14F743; Mon, 20 Jun 2022 04:17:19 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DzRpzISP8iiDi0v1l3wTdxodZBYYwkM91osXZMgqFtC6MVRFFpZsiYREjMLUGWSWvsDtjgk8fSx41wDmiElanaBu2R47b7qtzH2+/VQPL7PQ8dZ/F+LH2J/iWbq+DR7VTqgeV2V7SVZTYMhJQCMBbfJeB6Pu1YxSGV0FwkBWOWNXZ0GATn6imX02ukYNe0fxtmH8I9Im22M6Xl0SdqfBqMIlOC0ptERnAvXH5BRDgwntn2DwOQMeQLf3S4y09ywO7hFeI4VEedWptYRW6SMyxP9zfpM3qPhuBuTVLGqT44Dr9bV5EBdRgJ1bH9gvySsnkDYdbSuoxLdKbwDQc5M4nw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vf0OATTlmY7K9a3qNtPN0My09hgodoJubPI0l2Nkkxg=; b=YEsT0lxDFxr1MEo+gboKr0I9TOCMI6iClGxRKZ55XllfOoERY1qM41tnyV498Py30M339PGVpQeJQuayOy/GdRsW5N91Te9xZJHGSl11oafy0KNbn5VPOClFbArD+EpN6LpVNEc4tU5EvB6oe+iABkj/84FgRZNQPRBhaGeZP3eQuT2K1WBaNrbi83p3Lold9AmfssDnMF5/ok9QcWT439WA8DBZv1rWnHxE+Qw34Vi4EaUQCjmRTnGO5gyistMkbZWB9z2DqL7IwgUYfc/qLpvbOBCXXEyWp71C/u6Ml3NIh/d6ttCundOBXNNS2dvhcyVpPhnUA5zaCBSARXGQWA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vf0OATTlmY7K9a3qNtPN0My09hgodoJubPI0l2Nkkxg=; b=fAn1CdC2oj4yU1zM6Kh3JHVJze0yg7qFfJ6cf1pwimr3eitgue/Ok7uGKJEaPjxdakjbDC4NEybZmagea370UQrOJ3eHdRVJ/cJ4iqwnjhMfpE33R56yJE/55m2Pru97H4CU8mKxw0VFcEeTjFatu5ON83+aJRLtGr8fpVWK9tw=
Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=btconnect.com;
Received: from AM6PR07MB5544.eurprd07.prod.outlook.com (2603:10a6:20b:8a::30) by DB6PR07MB4391.eurprd07.prod.outlook.com (2603:10a6:6:52::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.13; Mon, 20 Jun 2022 11:17:15 +0000
Received: from AM6PR07MB5544.eurprd07.prod.outlook.com ([fe80::2d4c:2ce5:9a46:f423]) by AM6PR07MB5544.eurprd07.prod.outlook.com ([fe80::2d4c:2ce5:9a46:f423%6]) with mapi id 15.20.5373.013; Mon, 20 Jun 2022 11:17:15 +0000
To: Vishnu Pavan Beeram <vishnupavan@gmail.com>, TEAS WG <teas@ietf.org>
References: <CA+YzgTthabrS5jga0ANoTxxxyLsx-9ixHg6jQocL_pkbrmbiig@mail.gmail.com> <CA+YzgTuQRkQiTbsKi4W25+E6R-Y9h0EYjV_Lhw7TL3YwnP_47Q@mail.gmail.com>
Cc: TEAS WG Chairs <teas-chairs@ietf.org>
From: t petch <ietfa@btconnect.com>
Message-ID: <62B05736.3060608@btconnect.com>
Date: Mon, 20 Jun 2022 12:17:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
In-Reply-To: <CA+YzgTuQRkQiTbsKi4W25+E6R-Y9h0EYjV_Lhw7TL3YwnP_47Q@mail.gmail.com>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO4P123CA0072.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::23) To AM6PR07MB5544.eurprd07.prod.outlook.com (2603:10a6:20b:8a::30)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 78f87bcf-b295-423d-aa6d-08da52ae6dbd
X-MS-TrafficTypeDiagnostic: DB6PR07MB4391:EE_
X-Microsoft-Antispam-PRVS: <DB6PR07MB43917866087DD89768CFC94CA2B09@DB6PR07MB4391.eurprd07.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: EyHysASJG8feDIWqF39VBATx+bND2+rdARYB1ejLFqi3XZSI7V8KSUitlnsEI4sMmYriqz86fpYYd4+Qd+LbfyMjmWlcxGxIwLpTkAfObS/eOipCjPO932J8NXkNIAj+9/Ikgir1Oz2x9ZxuLqZXqcZ7ag+XMxk70J6jBuR5x5SzbxFAj5r9aV6vl2H/wnD05TwIeWSMZVdeKiJshnXhwJfm4Mxhf5RzvDMm2k7CltApUvKBpRY+Me7lixolZHyaBQnu6AFavyR5fEKR5Nx6/jNUSuVb95pr2mZCzlKRFhNFftRRNdFEp4dqx93zpoIwQYTV0P/dcpFxpzXPBSjAgXhvhVe40wA2LorSQdlLrn1mwTkzRiKRBqFEZa1I+/7VmwTPiGNWx5/BilIVkemaYaNb1uyzW8i4QOrn61TsbPMTYtWi+MBHPFcdbpxWSaFjya20RZNl3aMU5zHHVBhKDurgZtsaYnTKIzTWC+Sq0cffd8hdT8rg9NbWlSszSDFFE5cp06zRldR8z5RPFN7dZ3hLu111xwy3fKovIDwcJaSAIgik9jChkOZcS0lCGuNF+CNyJN1+7NYz76ICCsCA5xXVT7HW6q+YbfL33fJ3lXoNTTRe+57OTNWpHj6kJT9R/jwo5Bh4L/TuIsyu/8bqa9A6BZi+Peh8M0sLlmQeMCJVLbc/nufFZU+Dn6E4xNmItZaswCoXekCqVeDTM7gh3ZCgQbwFXfAtVajqvikS4l281ySNHAUCQFmoWbfjLgNNFifcPWM6Tzpoh03szsH/oKqB5dZ6s5X75phwnSMy7BgTL2wd+tG7g9AXWP6s1Bmj
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR07MB5544.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(376002)(39860400002)(366004)(396003)(136003)(6486002)(66556008)(110136005)(4326008)(8936002)(82960400001)(478600001)(6506007)(5660300002)(66476007)(86362001)(66946007)(8676002)(966005)(316002)(41300700001)(87266011)(53546011)(33656002)(186003)(2616005)(38350700002)(6666004)(2906002)(52116002)(38100700002)(83380400001)(26005)(6512007)(36756003); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: VMj3Gvjvw48eB4aGueFQvQBxPAZD1sINvqwEYOMnIWfmXUL2wCRWzR61KSWZa3+ScV6VwWW+86FhUCGOTLkb/C8C//DiEL/rh9nW2AHtxB6GEOnMlmN05DrHFhuTzXq0H0zDevQSGnc6HYlQ4wvZO39uhNR0kIb8nTod23+y/6w2g2XTleNVQNu4bq6yXlAY2jo6DbeD5jv+9MvU6nBpCpS16MLGwcELAAvxYSNhSg/sgGN4z99jTWT5+Vb9RTw8vJ5fOOHZu60/Dbki9olf92+9qckWbm1r+Al58olnOb9DG1/+0Y8yDov4ReJux6CXn134q2va+ZI8s4MjwusP+JXzASAO8cX2tyg/NOKCvFgdcqdR0jai6rv7TuWqqSjku13shx3kFjGY6iZbP2r1Fw24apnjVYtM01v8dIWVMuQuk4f9CY+J7gXQJIQMZhYT6lLFGUKvYV5x1MGiS8JgL+AhXkgl3MSqcy6NMq2MA4Tm+V438KcuYC4xfxnFLOzYGKc8rdqoAraYWey8zadLX8vIFC9Np+fFuf+RJavjjXX0BZUYIYmrkw/PySIGuSEoZOeC/m1AEggyyFTmXFN+2Bxi3TCTMjxP+xZOo/RM4Trh4PLkEwhwZnpBTnwBTea9jBJM0+rWfJbuLSHyCVcSAOza0BZSr+KReY6gpCnISZdtMrfxFiljn8v296l7j6to0aKCjMV3sBwag7nLPsA7bDnmqhBbexY7FuuQBztJVBjXY1/BXKDzbfmVgHb/9z9OuafuAkGBs/N4N54iVbXDPWpC3IDmH2dB3ofaJk7RtF4OgEFEMkmOzvGAJiwuJCcQkgyJtGBfGeqMGiVOUAwSesDSzJCymC0Yz1SP28r4FjbKX1ytLthhzJiVyy7R5+7LIyMIh3Xwvv+usUYUpE71r0yMVcLcY4EZJ65h2KrjD9VXXTrmSExXT+69zdworviLVpWT+y8erNXhbdn7GfilMjfdb4H+UQZW55vYO3TRLCGvoaOwjihG+rtqiWFJQBtWYFAr1dwkR0J/B76hLXllkdtFejCawn8ZO7kWMnyfsqUJIi0+0S+Z41tz+J+nVqa/eqUazO26mclNOhp4ZcsLdGdF79gU0TCmBMDbOEfJimgOR6EN/TLsOAzVwOVmOh02vzIalNcP9lFREAQNSufMNLsmG+VMUDhPPEnNGDSsEbvhDAQlacioFS+/bcd5QW42w0dqqsRGg33awLHMLOnqvFJrBZrH8saXUZaK1l4u+ols1CNfXrXrJ3GqG39cPjkHc2b/Qw88DZCIUjHD8+fQxF5qsztmtS0BHqqTp1Eh7y1oIpxDebwG+L6An++MQRrMU8oVBZ1oappjfMcKuQOL0bs4cLKoosfWNZRJGf9JXAK9dWVhYT049xmBKEmjCaOCQti01AUdDPk9pYST432eGY/j0HgB9Z0lEUZ2CkG81PtPP7LJeI5R+xJbmnZYxBqA85s2+TtSeMYLSP0tjj6x/t+P3w9LRP9tj84Z2mEUj1FythiQrF66kIIgzt6cjndYpAg6y5ZDyjMkf8jxtAtl5zEiywpC6WEvgD7C3XWLHBYcr7zyFHzRw8zGk/RJsiNWU1uihUtKaRv4MVEQKjUbLI9+nOYVqyhmyXv0DzQWkqIdX9UV/yPqPKsDOR2IoNHIpEtNFK07/farC6aFgUtZ9SP9UvbQrvP0fl2zPBerTYXKA5+Oq6qCFnktT29PztM8YxU83nZdWDMFoXyanx+FOg==
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78f87bcf-b295-423d-aa6d-08da52ae6dbd
X-MS-Exchange-CrossTenant-AuthSource: AM6PR07MB5544.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 11:17:14.9342 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GvP4MAP2M6Fkv9P3EAkPnZFwVFKjhgn2DIra4wLrVifWeEF9aiLCIdp8E4C6ORoftn5r+1zsybXSGCzegd4ZCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR07MB4391
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/hedXPTjg74N_MgLkCi8DSbNRmpI>
Subject: Re: [Teas] WG Last Call: draft-ietf-teas-yang-path-computation-18
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jun 2022 11:17:22 -0000

On 16/06/2022 13:48, Vishnu Pavan Beeram wrote:
> We are extending the last call to June 24th to allow for a few more reviews.
>

The examples should use documentation IP addresses and not 10/8.

The YANG module has a lot of 'must'.  Should they be MUST with a 
suitable reference to the BCP at the start of the module?  I expect that 
an AD will raise this:-(

I note the wide use of i.e. and e.g. which makes me think the authors 
are comfortable with those abbreviations but I wonder about the two 
'e.g.' in the YANG  module 'requested-info' and 'requested-state'.  Are 
they really e.g.?  No need to change if they are.

'requested-info' is a bit awkward. 'information' singular, 'metrics' 
plural', 'is' singular.  Perhaps
'This grouping defines the information that is requested (e.g. metrics)

'returning path srlgs'
probably worth expanding srlg here in the YANG module

'if also the tunnel name is reported'
perhaps
'if the tunnel name is also reported'

What is the difference between
request-id uint32
and
request-id-number uint32
Seems confusing?

In a number of places, thie I-D says that it contains RPC but it does 
not!  It augments the RPC in yang-te which I think a distinction worth 
making e.g. with
'This document provides a mechanism to [request path computation etc] by 
augmenting the RPC in RFC YYYY'

Tom Petch


> -Pavan and Lou
>
> On Tue, May 24, 2022 at 11:14 PM Vishnu Pavan Beeram <vishnupavan@gmail.com>
> wrote:
>
>> All,
>>
>> This starts working group last call on
>> https://datatracker.ietf.org/doc/draft-ietf-teas-yang-path-computation/
>>
>> Given the size of the document, this will be an extended
>> LC (3 weeks). The working group last call ends on June 14th.
>> Please send your comments to the working group mailing list.
>>
>> Positive comments, e.g., "I've reviewed this document
>> and believe it is ready for publication", are welcome!
>> This is useful and important, even from authors.
>>
>> Thank you,
>> Pavan and Lou
>>
>
>
>
> _______________________________________________
> Teas mailing list
> Teas@ietf.org
> https://www.ietf.org/mailman/listinfo/teas
>