Re: [Teas] WG Last Call: draft-ietf-teas-yang-te-29

Tarek Saad <tsaad.net@gmail.com> Thu, 21 July 2022 15:59 UTC

Return-Path: <tsaad.net@gmail.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C8EA0C13D086; Thu, 21 Jul 2022 08:59:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.104
X-Spam-Level:
X-Spam-Status: No, score=-7.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ANJKS0TnyZC7; Thu, 21 Jul 2022 08:59:22 -0700 (PDT)
Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 71191C16ECA3; Thu, 21 Jul 2022 08:59:22 -0700 (PDT)
Received: by mail-il1-x130.google.com with SMTP id q2so433423ilv.4; Thu, 21 Jul 2022 08:59:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:thread-topic:thread-index:date:message-id :references:in-reply-to:accept-language:content-language :mime-version; bh=0EAf2XzSdFUhGGOro35a+ad1PjObWqSrQFwflKKdbSE=; b=ljj7/MnQ/+FJsnCjZvDnzTqiYPtyD50Ovo/FxCfDU8LMtUGKZJZRo8prZxbMoVgJqK Tye9XFYmBOcYpvW3YW9UD/7GXJoBjKP4FJjIwY2vnzStpGLcI/ba1hY5yanDBPCmVJ96 g339PJAgIu8kq/s89f/fsOJONJzmutqTAcsCy/jfRDnRZyxMuotfo8Jx61JyBHff+Hpw ikPAT28RmSQBo3RwFyvEwbkGHdXYfcxnaD1aORoRNW2L8qv9vejmRdIfIVou2GsWfiYj M++kL7uj6p2Ap+frEsULypTuYSb5Q8UFB1v+1rKF9qk4IEk0MEr8WDocfBQuj9TRpMqV v1vA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:thread-topic:thread-index :date:message-id:references:in-reply-to:accept-language :content-language:mime-version; bh=0EAf2XzSdFUhGGOro35a+ad1PjObWqSrQFwflKKdbSE=; b=S9GNoPKjImKBcKeO+BypPl28SnJa0feRwS8XllU7lRL3NS+8H3r7w1eeA07lhMYUrm CrbdqBY7ab9ZDj1HsKp5MuX1rNEUu0Oc9zb3yWJ6HQzW5njWJMODoZQZ3cngYixlQSIh L3o4xlRVoeP911BaoZwpyzlT/K3LOpqSVyyKtlKUpqBKQSyjpIXBPzeohhxem0pTSdUV m5vljGe7NQCPqVzEDM+LjUln4mK1+a06+Wts9eYsUYTCKWvQOb5j2ZtCSNZpeZGbNu9h WzpAG27tJzPD9pwLIBC3uGsOvzbcteU1503PFkF2RQRnHN05kieQ5OpinFHBgyF1XdkI 5IqA==
X-Gm-Message-State: AJIora8H/a7bQ+NTNCvT0uOkatmrVWlwv/1WWL/ikatjlJ1RsCPFaUhV nDFlGLROZoAJTxfMXbv+989NnoZ+Ysc=
X-Google-Smtp-Source: AGRyM1sRsvSWzSt00nWf427BxtBXcquHDhqKZHoaczNjFkltTi/saxyIr8FmRn7tKqWyR4Qv9t5dEA==
X-Received: by 2002:a05:6e02:1689:b0:2dc:6742:ca1e with SMTP id f9-20020a056e02168900b002dc6742ca1emr21002019ila.285.1658419160936; Thu, 21 Jul 2022 08:59:20 -0700 (PDT)
Received: from DS0PR19MB6501.namprd19.prod.outlook.com ([2603:1036:5:f::5]) by smtp.gmail.com with ESMTPSA id y3-20020a056638228300b00339d5108b60sm963047jas.17.2022.07.21.08.59.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jul 2022 08:59:20 -0700 (PDT)
From: Tarek Saad <tsaad.net@gmail.com>
To: t petch <ietfa@btconnect.com>
CC: TEAS WG Chairs <teas-chairs@ietf.org>, Lou Berger <lberger@labn.net>, TEAS WG <teas@ietf.org>
Thread-Topic: [Teas] WG Last Call: draft-ietf-teas-yang-te-29
Thread-Index: ATBiOTc40hBzor0AyuAb8o440099MzMwMzY0ztw/K58=
X-MS-Exchange-MessageSentRepresentingType: 1
Date: Thu, 21 Jul 2022 15:59:19 +0000
Message-ID: <DS0PR19MB65017C496EC3DA8B146A78D3FC919@DS0PR19MB6501.namprd19.prod.outlook.com>
References: <409bd958-008c-76df-1692-221ab8dfbab0@labn.net> <62540E64.3060403@btconnect.com>
In-Reply-To: <62540E64.3060403@btconnect.com>
Accept-Language: en-US
Content-Language: en-CA
X-MS-Has-Attach:
X-MS-Exchange-Organization-SCL: -1
X-MS-TNEF-Correlator:
X-MS-Exchange-Organization-RecordReviewCfmType: 0
Content-Type: multipart/alternative; boundary="_000_DS0PR19MB65017C496EC3DA8B146A78D3FC919DS0PR19MB6501namp_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/5LxyLXXGCRGNbJ5PpAYJXZeLg2o>
Subject: Re: [Teas] WG Last Call: draft-ietf-teas-yang-te-29
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Jul 2022 15:59:24 -0000

Hi Tom,

Thanks for your comments (as usual). We have published a revision -30 of the draft that have addressed most of your comments below (diffs at https://www.ietf.org/rfcdiff?url2=draft-ietf-teas-yang-te-30.txt). We are planning to upload a new revision to address the remaining ones.

Please see below inline for responses.

From: Teas <teas-bounces@ietf.org> on behalf of t petch <ietfa@btconnect.com>
Date: Monday, April 11, 2022 at 7:18 AM
To: Lou Berger <lberger@labn.net>, TEAS WG <teas@ietf.org>
Cc: TEAS WG Chairs <teas-chairs@ietf.org>
Subject: Re: [Teas] WG Last Call: draft-ietf-teas-yang-te-29
On 21/03/2022 13:28, Lou Berger wrote:
>
> All,
>
> This starts working group last call on
> https://datatracker.ietf.org/doc/draft-ietf-teas-yang-te/
>
> Given the size of the document and this week's meeting, this will be an
> extended LC. The working group last call ends on April 13th.
> Please send your comments to the working group mailing list.
>
> Positive comments, e.g., "I've reviewed this document
> and believe it is ready for publication", are welcome!
> This is useful and important, even from authors.

It has been a few years since I reviewed this so the
Copyright 2019
seems about right.

However, reading Adrian's comments brought back memories and indeed, my
notes say 'three e-mail of comments' which suggests to me that they were
never acted on:-)

So
- there are ten references in the YANG to RFC that do not appear in the
I-D references (used to be four)

[TS]: Fixed in latest revision.


- abbreviations need expanding, I suggest in s.2 with a separate heading
to the current s.2

[TS]: We will add an abbreviations section in next revision.


- http: needs to be https:

[TS]: Fixed in latest revision.

- the TLP are out of date (that's new)

[TS]: Fixed in latest revision.


- the format of the tree diagram is clumsy - identifiers are split in
the middle, across lines

[TS]: Fixed in latest revision.

- revision should be 'Initial ..' not 'latest'

[TS]: Fixed in latest revision.


- /constraitnt/constraint/

[TS]: Fixed in latest revision.


I will plough on - my target is by Easter, ie COB 14th April

[TS]: thanks.

Regards,
Tarek


Tom Petch

>
> Thank you,
> Lou (Co-Chair & doc Shepherd)
>
>
>
>
> _______________________________________________
> Teas mailing list
> Teas@ietf.org
> https://www.ietf.org/mailman/listinfo/teas
> .
>

_______________________________________________
Teas mailing list
Teas@ietf.org
https://www.ietf.org/mailman/listinfo/teas