[Teas] Rtgdir early review of draft-ietf-teas-pcecc-use-cases-14

Carlos Pignataro via Datatracker <noreply@ietf.org> Fri, 10 May 2024 20:19 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: teas@ietf.org
Delivered-To: teas@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id C72D2C1D620B; Fri, 10 May 2024 13:19:27 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Carlos Pignataro via Datatracker <noreply@ietf.org>
To: rtg-dir@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.11.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <171537236779.60420.8514799251735039686@ietfa.amsl.com>
Date: Fri, 10 May 2024 13:19:27 -0700
Message-ID-Hash: 7ABUCFQE23KMQWP7WG4BEZV5KD6XPR4K
X-Message-ID-Hash: 7ABUCFQE23KMQWP7WG4BEZV5KD6XPR4K
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-teas.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-teas-pcecc-use-cases.all@ietf.org, teas@ietf.org
X-Mailman-Version: 3.3.9rc4
Reply-To: Carlos Pignataro <cpignata@gmail.com>
Subject: [Teas] Rtgdir early review of draft-ietf-teas-pcecc-use-cases-14
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/n-T3mwO_mmVwvIbxfcThkD8gfGs>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Owner: <mailto:teas-owner@ietf.org>
List-Post: <mailto:teas@ietf.org>
List-Subscribe: <mailto:teas-join@ietf.org>
List-Unsubscribe: <mailto:teas-leave@ietf.org>

Reviewer: Carlos Pignataro
Review result: Has Issues

Hi,

Please find below the Routing Area Directorate (rtgdir) review for
draft-ietf-teas-pcecc-use-cases-11.

Review of   draft-ietf-teas-pcecc-use-cases
Type        Early Review
Team        Routing Area Directorate (rtgdir)
Reviewer    Carlos Pignataro

Summary:

This is a useful and easy-to-understand document. There are a number of
grammatical errors, notably missing articles; while they do not get in the way
of readability, they ought to be fixed. This document describes use cases for a
PCE as a central controller, and has an Informational intended status.

More Substantive:

The main relatively substantive comment I have relates the organization of
References. To understand SR, SFC, or BIER use cases, I'd expect the main
document specifying that technology (e.g., RFC8402, RFC7665, etc.) would be a
Normative Reference. Yet, all of those are in the Informative section. I'd
review this.

Also, in regards to:

Appendix A.  Other Use Cases of PCECC

   This section lists some more advanced use cases of PCECC that were
   discussed and could be worked on in future.

CMP: This organization carries some Risk. First, what defines what "Advanced"
is to include here or in the main part of the document?

CMP: Second, does "could be worked on in future" imply that these are not
worked, not solved, could be wrong or incomplete or insecure, etc.?

CMP: So, net-net, I'd recomment to either (1) move these to the main part of
the document, or (2) move them out of the document, either (2a) delete them or
(2b) push them to another I-D to be progressed and solved.

Minor:

3.4.  PCECC for Load Balancing (LB)

CMP: THis section could describe more the LB expected, if ECMP, UCMP, etc.

3.8.  PCECC for SFC

CMP: This section could specify more explicity the role of metadata and how a
PCE/PCECC has a role there. Largely, it describes the forwarding of SFCs, less
so the shared context -- those being the 2 key definitions for SFC.

Appendix B.  Contributor Addresses

   Following authors contributed text for this document and should be
   considered as co-authors:

CMP: I do not follow this sentence -- are co-authors or contributors?
CMP: Is this defining something different than the RFC Editor definitions?

More Editorial:

Please find some nits and editorial suggestions:

           Use Cases for PCE as a Central Controller (PCECC).

CMP: "for *a* PCE" and remove the ending "."

   PCECC:  PCE as a central controller.  Extension of PCE to support SDN
   functions as per [RFC8283].

CMP: Capitalize "Central Controller"

I hope these help and are clear and useful.

Thanks!

Carlos.