[Teas] Re: AD review for draft-ietf-teas-gmpls-controller-inter-work-13

"Linyi (Yi)" <yi.lin@huawei.com> Tue, 11 June 2024 22:57 UTC

Return-Path: <yi.lin@huawei.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 72D01C14F6E4; Tue, 11 Jun 2024 15:57:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.204
X-Spam-Level:
X-Spam-Status: No, score=-4.204 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 13vOK-VUL-Q8; Tue, 11 Jun 2024 15:57:27 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A08C6C14F69B; Tue, 11 Jun 2024 15:57:26 -0700 (PDT)
Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VzPD311Qwz6K8sc; Wed, 12 Jun 2024 06:56:03 +0800 (CST)
Received: from lhrpeml100002.china.huawei.com (unknown [7.191.160.241]) by mail.maildlp.com (Postfix) with ESMTPS id 96ECE140516; Wed, 12 Jun 2024 06:57:23 +0800 (CST)
Received: from canpemm100004.china.huawei.com (7.192.105.92) by lhrpeml100002.china.huawei.com (7.191.160.241) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 11 Jun 2024 23:57:22 +0100
Received: from dggpemf200009.china.huawei.com (7.185.36.246) by canpemm100004.china.huawei.com (7.192.105.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 12 Jun 2024 06:57:19 +0800
Received: from dggpemf200009.china.huawei.com ([7.185.36.246]) by dggpemf200009.china.huawei.com ([7.185.36.246]) with mapi id 15.02.1544.011; Wed, 12 Jun 2024 06:57:19 +0800
From: "Linyi (Yi)" <yi.lin@huawei.com>
To: James Guichard <james.n.guichard@futurewei.com>, Vishnu Pavan Beeram <vbeeram@juniper.net>, 'Vishnu Pavan Beeram' <vishnupavan@gmail.com>, "draft-ietf-teas-gmpls-controller-inter-work@ietf.org" <draft-ietf-teas-gmpls-controller-inter-work@ietf.org>
Thread-Topic: AD review for draft-ietf-teas-gmpls-controller-inter-work-13
Thread-Index: Adq8DxU9/R1XWKNaRgKCtXn6h9vLZw==
Date: Tue, 11 Jun 2024 22:57:19 +0000
Message-ID: <32487184a86a40f1934eabda9b92765c@huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.45.158.41]
Content-Type: multipart/alternative; boundary="_000_32487184a86a40f1934eabda9b92765chuaweicom_"
MIME-Version: 1.0
Message-ID-Hash: FDWPLCJ3EMGE3ZOSG7HLG5XNBIJBAZ4A
X-Message-ID-Hash: FDWPLCJ3EMGE3ZOSG7HLG5XNBIJBAZ4A
X-MailFrom: yi.lin@huawei.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-teas.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "teas@ietf.org" <teas@ietf.org>, "teas-chairs@ietf.org" <teas-chairs@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Teas] Re: AD review for draft-ietf-teas-gmpls-controller-inter-work-13
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/wGUdzTd_YGLlBeIcpyD49cMfUG0>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Owner: <mailto:teas-owner@ietf.org>
List-Post: <mailto:teas@ietf.org>
List-Subscribe: <mailto:teas-join@ietf.org>
List-Unsubscribe: <mailto:teas-leave@ietf.org>

Dear Jim and Pavan,



Thank you for your review, comments and suggestions, which we have addressed below (with remarks as needed).

We have performed a full review, squashed several additional editorial bugs, and improved the  English where possible. We have also provided some additional terminology clarity for some readers unfamiliar with optical transport terms.



You can find a diff of the document, with our recent updates addressing your comments here: Diff: draft-ietf-teas-gmpls-controller-inter-work-13.txt - draft-ietf-teas-gmpls-controller-inter-work-14.txt<https://author-tools.ietf.org/iddiff?url1=draft-ietf-teas-gmpls-controller-inter-work-13&url2=draft-ietf-teas-gmpls-controller-inter-work-14&difftype=--html>



Below you will find a quick summary of changes specific to your comment and/or suggestion.



1)      Jim’s comments:

118     Generalized Multi-Protocol Label Switching (GMPLS) [RFC3945] extends



Jim> No need to expand on GMPLS as it is a well-known abbreviation as stated here -> https://www.rfc-editor.org/materials/abbrev.expansion.txt.

[Yi] OK



132     nodes. One of the examples is the Abstraction and Control of Traffic



Jim> s/‘One of the examples’/‘One example’

[Yi] OK



152   2. Overview



154     In this section, overviews of GMPLS control plane and centralized

155     controller system are discussed as well as the interactions between



Jim> s/system/systems

[Yi] OK



216           +-------------+      +-------------+       +-------------+

217           |Controller(N)|      |Controller(G)|       |Controller(G)|

218           |    (PNC)    |      |    (PNC)    |       |    (PNC)    |

219           +-------------+      +-------------+       +-------------+



Jim> What do (N) and (G) represent above? I assume GMPLS and non-GMPLS? It looks like you clarify this later in the document so perhaps simply provide a pointer here so that the figure is understandable.

[Yi] Yes, Controller(N) is for non-GMPLS domain, and Controller(G) is for GMPLS domain. Added the explanations under the figure.



222         NETCONF|  |PCEP       NETCONF|  |PCEP       NETCONF|  |PCEP



Jim> Please expand on PCEP and add reference.

[Yi] Added the expansion and reference for PCEP in the second paragraph under the figure, where PCEP is the first time mentioned in the text.



433     technology-specific signaling. The RSVP-TE extensions for OTN, WSON,



Jim> please expand acronyms OTN and WSON

[Yi] OK



467     interface) in the hierachy of the controllers (e.g. MPI and SBI for



Jim> s/hierachy/hierarchy

[Yi] OK



2)      Pavan’s comments (sent on March 13th, 2024):

Section 1, Second Paragraph

s/provision services to corresponding nodes /provision services on corresponding nodes [Yi] OK



Section1, Third Paragraph

s/describes how GMPLS control interworks /describes how GMPLS control plane interworks [Yi] OK



Section 2.1, Second Paragraph

s/for GMPLS control [RFC3945]/ for GMPLS control plane [RFC3945] [Yi] OK



Section 2.2

Please add appropriate references/expansions when NETCONF, YANG, RESTCONF, PCEP and PCC are first introduced.

[Yi] Added expansions to NETCONF, PCEP and PCC (RFC8040 and RFC7950 do not provide the expansions to RESTCONF and YANG), and added reference to NETCONF, YANG, RESTCONF and PCEP



Section 2.2

s/ utilizing the, e.g., [RFC8795] Yang model /utilizing the [RFC8795] Yang model s/ exploit, e.g., [TE-Tunnel] Yang model / exploit the [TE-Tunnel] Yang model [Yi] OK (I think both changes are in Section 2.3)



Section 4.1

Please expand OTN and WSON (at first occurrence) [Yi] OK



Section 7.2, Second Paragraph

s/hierachy/hierarchy

[Yi] OK



Section 7.3.1

Please expand VNTM and NMS (at first occurrence) [Yi] OK




B.R.
Yi LIN

HUAWEI France
Marco Polo A2, 790 Avenue Maurice Donat, 06250 Mougins France
http://www.huawei.com<https://urldefense.com/v3/__http:/www.huawei.com/__;!!D9dNQwwGXtA!Xsp-O9h6SXnygDOPTfzFdS9Kukr7nZ_NNzPlwoW_94XFXCB4iZRMiocCqd0kO4xWTSGP9ctwHB7XGJyZ$>
---------------------------------------------------------------------------------------------
This e-mail and its attachments contain confidential information from HUAWEI, which
is intended only for the person or entity whose address is listed above. Any use of the
information contained herein in any way (including, but not limited to, total or partial
disclosure, reproduction, or dissemination) by persons other than the intended
recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender
by phone or email immediately and delete it!

发件人: James Guichard <james.n.guichard@futurewei.com>
发送时间: 2024年5月31日 21:03
收件人: draft-ietf-teas-gmpls-controller-inter-work@ietf.org
抄送: teas@ietf.org
主题: AD review for draft-ietf-teas-gmpls-controller-inter-work-13

Hi Authors,

Thank you for this document. Please see my review comments for v-13 of the document. I have used line numbers from idnits to help with your review:


118     Generalized Multi-Protocol Label Switching (GMPLS) [RFC3945] extends



Jim> No need to expand on GMPLS as it is a well-known abbreviation as stated here -> https://www.rfc-editor.org/materials/abbrev.expansion.txt.



132     nodes. One of the examples is the Abstraction and Control of Traffic



Jim> s/‘One of the examples’/‘One example’



152   2. Overview



154     In this section, overviews of GMPLS control plane and centralized

155     controller system are discussed as well as the interactions between



Jim> s/system/systems



216           +-------------+      +-------------+       +-------------+

217           |Controller(N)|      |Controller(G)|       |Controller(G)|

218           |    (PNC)    |      |    (PNC)    |       |    (PNC)    |

219           +-------------+      +-------------+       +-------------+



Jim> What do (N) and (G) represent above? I assume GMPLS and non-GMPLS? It looks like you clarify this later in the document so perhaps simply provide a pointer here so that the figure is understandable.



222         NETCONF|  |PCEP       NETCONF|  |PCEP       NETCONF|  |PCEP



Jim> Please expand on PCEP and add reference.



433     technology-specific signaling. The RSVP-TE extensions for OTN, WSON,



Jim> please expand acronyms OTN and WSON



467     interface) in the hierachy of the controllers (e.g. MPI and SBI for



Jim> s/hierachy/hierarchy

Thanks!

Jim