Re: [Teas] Fw: Status update on draft-ietf-teas-yang-sr-te-topo -09

t petch <ietfa@btconnect.com> Mon, 29 March 2021 10:06 UTC

Return-Path: <ietfa@btconnect.com>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AC4343A3727 for <teas@ietfa.amsl.com>; Mon, 29 Mar 2021 03:06:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.701
X-Spam-Level:
X-Spam-Status: No, score=-1.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, MSGID_FROM_MTA_HEADER=0.001, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z1SPJJ4Ibusq for <teas@ietfa.amsl.com>; Mon, 29 Mar 2021 03:05:56 -0700 (PDT)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50109.outbound.protection.outlook.com [40.107.5.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5DA183A3724 for <teas@ietf.org>; Mon, 29 Mar 2021 03:05:56 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nB3i4VFrB64ve6rjC6eEajHRtt64JB/BL+LBrT7BBmBB4lYtEj+VgQNHc0GH6SDc/1SOfApB4c26XVvAjLHdAFSuwZenBvebVNMspq+cxUrAvRnH/6pBomeVefy7hlK/mxkrPxaRYqnyTNc8WDZPCThxZ1cDQp4DmRj1ovk7ImNhD8nSd6QRj3jinpSqQvmZU8/G1nwPdxkLNPG9ppg3CvdeYraUMrm69TfYE0L+fWNri+/mbchu5iSteXT634zyEQnwGetPT719/uf0eaCiKzt8FBwg14HKhQN3sRO5qmg/w7BSoJPXyncRHlquHvOpJ6TeRgi0WRUi1Op+IqrNtw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oJ95PWOKoF8Y0Jh2C+cqsnuLFlIpvbDSy3R1yT1YGoM=; b=fp0JL+rDZlgYezSl9bfffCdx0L7mtBOs+yt+Tg2xUMpJwZ4wDjG6dvNX6DtVFOu6P1mf0MImuDa1e3ITqMj1ZEf0SvmfyBi++NtPluRoQINMWAPAWnSDhC82GTBtDG2Q6aWCwQsobfQf9QCZEIDylB6ddZ3B4pzVPNwdkk4VNe+iz1tz5OwiH7i0oDjMKwEmWfFIiv2TuuZppxH0BCxjZ5SA9F4uxnWy6IK2kh4QI+1UMuVCFaC/IuA3I1Qa6b6yxbDemp9weQo+m3ZAHHCaLMGnE5eMyFtsarU43ET4k2kLO4Z1qGPjT6QLphpmFLk2P8Uuq9R2Kos1tRKh9A3x8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oJ95PWOKoF8Y0Jh2C+cqsnuLFlIpvbDSy3R1yT1YGoM=; b=VE9uLn3jaBSj4oOva0xWt2wnB04nblxROhz1hm+oMiNF1XRsubCjDJwceGI3ANqeP1FXe6YS9gcYTks8VkmFlcNZccUN4q9mj/6bw/3JMsK3Ae0Wzl/QprliRxhKguJBu911ris2m/v2XKhgUxkSfSHUBpOf0cgMzXoHD6LnNYg=
Authentication-Results: ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=btconnect.com;
Received: from DB7PR07MB5546.eurprd07.prod.outlook.com (2603:10a6:10:73::23) by DB7PR07MB5356.eurprd07.prod.outlook.com (2603:10a6:10:70::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.16; Mon, 29 Mar 2021 10:05:53 +0000
Received: from DB7PR07MB5546.eurprd07.prod.outlook.com ([fe80::e5d9:cd75:1ebc:a236]) by DB7PR07MB5546.eurprd07.prod.outlook.com ([fe80::e5d9:cd75:1ebc:a236%4]) with mapi id 15.20.3999.016; Mon, 29 Mar 2021 10:05:53 +0000
References: <CAEz6PPTitjtVBngGEBTi3O3cwEsfwxaQw_wnq+afdDFc=8tFaw@mail.gmail.com> <DB7PR07MB5786A1A81AFA1EF6572B0F49A2E60@DB7PR07MB5786.eurprd07.prod.outlook.com> <CAEz6PPTXMxJQ03ZHwn7xupF_kUwY6ks7Ts5cTMHoYf5domKifA@mail.gmail.com> <DB7PR07MB55463121B7C3B7B35AE00CE8A27E9@DB7PR07MB5546.eurprd07.prod.outlook.com>
From: t petch <ietfa@btconnect.com>
To: Xufeng Liu <xufeng.liu.ietf@gmail.com>, teas@ietf.org
Message-ID: <6061A67B.9080501@btconnect.com>
Date: Mon, 29 Mar 2021 11:05:47 +0100
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
In-Reply-To: <DB7PR07MB55463121B7C3B7B35AE00CE8A27E9@DB7PR07MB5546.eurprd07.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [86.146.121.140]
X-ClientProxiedBy: LO2P265CA0098.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::14) To DB7PR07MB5546.eurprd07.prod.outlook.com (2603:10a6:10:73::23)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.65] (86.146.121.140) by LO2P265CA0098.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3977.30 via Frontend Transport; Mon, 29 Mar 2021 10:05:53 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c85b52cc-820b-40cf-dbc5-08d8f29a3d09
X-MS-TrafficTypeDiagnostic: DB7PR07MB5356:
X-Microsoft-Antispam-PRVS: <DB7PR07MB53566B6C1977E3E8CE975FB7A27E9@DB7PR07MB5356.eurprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 0K1eGiTzHc1cKgOO5Kf1Mys7nPb0VL7X0TDMqghOoysSXMnetAgUfpoJpAgJ7nZkbptdjwk5fRx0+pS2qUKCIKANltpzusZtRC+cSju54JYfVA61y8rsRulivdPEBId4bAmd7AiMoJgPfePgnUak6MwpJEmG6++lOGLe3jwq7551J59UTnkN0tzXlC0ABFcHenyxzEQb60R3lZ18BcvD41iq5lL7/uIiZ1pPRLsZ76GAiQPOz1Lz5tz8j4Ywg9AzZ8FONTJtjW/MX/7QRGv0cHcoG3toQZwOIWJZNU9V9pyl/asTsworT+MOrtPyQSGFrtPWMCIzJeN0MsMSilQPvCi3q1dDXqzjv/UthryBOkKphtIVN4C4S/t62tqu/SuIFXKNNArPfDpLwdT0mveEHGhr7mGsqjLbvOF5iTlVpExQ0aIgxBOpRXQB//vrek6ivK1u6fbh6kIFG5LgXqLdXZQKhL4h1xnAoBmIjHJPMXVK0dYIeIXuBCkv7X3p/gzdDFLftyiHixSq2Qqa/WA2mZF5VegodxN7EL+558yK0dkXUF7N0tbQWXhIsWTdJAAXhJ3ldYzP0y4+NNzMtwovRTcmfZ1oLd9Jm9RejQ9z7+vbJgisGuYkFCS5aLTtoDrofDYnvi5Ct/vOgi6tandOTO6rD4AeLjQdXZC6FZeFQ1m/QA4osfGpr5U1ph5o5pTbqQnZEzveBi2F1O/f6UT7GKAzdLnOWp+zoCquM4RYDWY=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR07MB5546.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(396003)(376002)(366004)(346002)(39860400002)(966005)(66946007)(66476007)(86362001)(66556008)(6666004)(316002)(66574015)(53546011)(5660300002)(16576012)(52116002)(87266011)(38100700001)(8676002)(8936002)(6486002)(36756003)(83380400001)(186003)(15650500001)(2906002)(26005)(16526019)(2616005)(478600001)(33656002)(956004); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: =?Windows-1252?Q?DeEqo07tObLngXoyCVqs06rbjVWmPkpbvJMRgYiykHo88oOTy2HQDzNk?= =?Windows-1252?Q?hMHbfxPzUTAcq0/jSQzmjLvaxxBkyD/jEFczsuwFJB23sgWYr+J9Ww1i?= =?Windows-1252?Q?6wVvMATs3UpHSJ2nk9uEqABxmPmSm0xvoFCWj8NeLudnZLx2vdCR54pV?= =?Windows-1252?Q?FRKLNff96et+V70H1gIsW3NrIX/kTXxXlD3oEBV+7M9eaF5dzFE+oUaw?= =?Windows-1252?Q?JUtSM51GW0tvlKt9g/2VPVK6ZMI62Zwdk4r/JpeA/vBZ3yuPm+v4a331?= =?Windows-1252?Q?ZnlXeAubTPqSbbjmOPh8SF1c0DnoAKByMRgUIe6shXg451YIsNLSN9GI?= =?Windows-1252?Q?Bf9j4Kl1ZnZZQrYtr2XGOYmtGtt799GEr4CULDYqFZTSEMByxKDPnfMp?= =?Windows-1252?Q?uhExzq5fcZPk9cPsrEW0RCS3lO1XQ+RAwVDxpLkQ8s5VzvHByio95JgU?= =?Windows-1252?Q?sZmmILoRODYmM62V+USgBfYcnV/S2+Bl9wsjIDFXlxHfl3p54wYZnf7h?= =?Windows-1252?Q?OcSpNaPzf+yRoE4qmfxo8RZ4i7yBGMChjqLTXKinXHvH7499s2zJsvTe?= =?Windows-1252?Q?gL8xd0VQ6wgpjEVc/UVAL471/DBjAkOPWCT4vTpx20sJQOsBaEgsYU7D?= =?Windows-1252?Q?4VRqhh02XdGZoNQEkhdQzhiSoKjuGUsA+W/JW325yTurX3ooEepIcZXk?= =?Windows-1252?Q?J+8w083kYfHIkCTpwt1Ce0jrLjTXSYcjbR3RQQTQSM/hY9ygDecxMysz?= =?Windows-1252?Q?sn+wyqjVi7o517ZP29ZIc4gt4Ujzei4MSh5hIHsBevqRsfvNjCehhrVe?= =?Windows-1252?Q?Yfol0i8aUECbOrYYLbLzraTY3iBywuT6UJ21WbdI7AW/6ZH+LksDigob?= =?Windows-1252?Q?uCyLEg8sN0wlMTUQuO4kv86H+q+RLRPQ+SoM0ZuT9RU7FiZ52I5iMxBY?= =?Windows-1252?Q?m82AiA4wuVS/2HhSj8hi4ZrDw2guJgKe8iyFy59HMjDgp3Seklc43jB2?= =?Windows-1252?Q?FKcgG1hFN02BGaBC3xVuDyxe7JWp2BCCl1RF+EtB5oSM1lV08Y7yrH0q?= =?Windows-1252?Q?WoqTzd4jLaAmuRLtyA7hBurE+dMC2kHaLVydQyhsNdS9Nq/NXM8zu+oF?= =?Windows-1252?Q?um4nFm1mQNp6GecUjFvFA6IfFydt6lmDlrG0zzqHYHDG7fHV08ehUhz4?= =?Windows-1252?Q?AjBfEgBZu/5npG1JbjPQ+3qtk3Gj5i4GFHO4XGwggn99/8i2QL21I0y6?= =?Windows-1252?Q?cnaUZoqb2znADlEKKLZ4IN0dwTI7Zee6R7kQhXsvwfxJbpX21Jz3HAWZ?= =?Windows-1252?Q?iI+7Ntik06CxlPilOdM8CcoKgF5vP4TBiO86+UPFk4QVXTUGJ8iEd95h?= =?Windows-1252?Q?TFyIxOjPxT+yx1SVS9jFFkWZC3YV6TAy97JqNMedE9IWhqJBFpfo1dqf?=
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c85b52cc-820b-40cf-dbc5-08d8f29a3d09
X-MS-Exchange-CrossTenant-AuthSource: DB7PR07MB5546.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 10:05:53.7106 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fQ/8qSAqIgiPEiREsROT6V6zXdD1Pjck2qZzZLVoWDEwJ9YTRbREym+Zh4Fgo91GfcXqQHT9ETvFIpG9TDZcTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR07MB5356
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/zpl76fLbU_42D40VDX_rVVXQCrY>
Subject: Re: [Teas] Fw: Status update on draft-ietf-teas-yang-sr-te-topo -09
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Mar 2021 10:06:01 -0000

On 29/03/2021 10:37, tom petch wrote:
> ________________________________________
> From: Xufeng Liu <xufeng.liu.ietf@gmail.com>
> Sent: 24 February 2021 17:07
>
> Hi Tom,
>
> Thank you much for the additional comments. We have posted an updated version https://tools.ietf.org/html/draft-ietf-teas-yang-sr-te-topo-09. Section 2.2 has been reworded. I'm wondering if it is any better.

Xufeng,

Yes, I am getting there but it remains a tough read.  I think that the 
problem is partly that the work of TEAS lacks an overall structure and 
that, with hindsight, the organisation could be more rational but that 
is the way that the IETF works and is not going to change; and this 
brings together many different technologies, some of which I am 
comfortable with, others not.  It makes references to other documents 
more necessary for me.

So,
1.3 Prefixes
you need to add tet which you (rightly) use in the I-D.

2.2
/  <other netowrk / <other network/

OLD
Each type of topologies is indicated by
"network-types" defined in
    [RFC8345].

NEW
Each type of topology is indicated by
a YANG presence container which augments
"network-types" as defined in
    [RFC8345].


The five following references ae inconsistent in their use of YANG 
prefix.  I suggest including all the prefix in the path statements.

The five references need references, all of them!  The I-D for packet is 
not obvious to me.

2.5
    by augmenting the container "l3-topology-attributes" in the L3 
toplogy model.
needs a reference to the I-D IMHO.  I would like to see references in 
the subsequent sections as well, for those who are dipping into a 
section and not reading this cover-to-cover.

2.6
Wrong!  This is not the YANG module of -09!

2.7
Wrong! This is not the YANG module of -09!

3
The use of multiple presence containers stands out to me as odd.  I 
think that the reason for it (assuming there is one!) needs explaining.

4
   description "Augment only for SR topology.";
May make sense now but may not in future. Perhaps
   description "Augment only for SR MPLS topology.";
to cater for IPv6 which must be on the way. This applies to all the YANG 
'when'.

Appendix B
                  "router-id": ["203.0.113.3"],
                  "prefix": [
                    {
                      "prefix": "203.0.113.1/32",
Should that be 113.1?

Tom Petch




> Best regards,
> - Xufeng
>
> On Fri, Nov 13, 2020 at 7:34 AM tom petch <ietfa@btconnect.com<mailto:ietfa@btconnect.com>> wrote:
> From: Teas <teas-bounces@ietf.org<mailto:teas-bounces@ietf.org>> on behalf of Xufeng Liu <xufeng.liu.ietf@gmail.com<mailto:xufeng.liu.ietf@gmail.com>>
> Sent: 13 November 2020 01:04
>
> Current Status:
>
>    *  Received further valuable comments from Tom Petch.
>    *  The updated revision -08 was posted on Nov 1, 2020:
>       - Addressed some review comments from Tom
>       - Updated the reference to the latested draft-ietf-spring-sr-yang
>
> Open Issues:
>
>    *  Authors working on addressing Tom’s comments.
>
>