IETF Logo Mail Archive

Re: [TICTOC] Yangdoctors early review of draft-ietf-tictoc-1588v2-yang-10

Rodney Cummings <rodney.cummings@ni.com> Thu, 25 October 2018 14:41 UTC

Return-Path: <prvs=98369dc28e=rodney.cummings@ni.com>
X-Original-To: tictoc@ietfa.amsl.com
Delivered-To: tictoc@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EC789130E63; Thu, 25 Oct 2018 07:41:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.602
X-Spam-Level:
X-Spam-Status: No, score=-0.602 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, KHOP_DYNAMIC=1.999, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nio365.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4yPxbZpR4C6g; Thu, 25 Oct 2018 07:41:22 -0700 (PDT)
Received: from mx0b-00010702.pphosted.com (mx0b-00010702.pphosted.com [148.163.158.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B95E1128CF3; Thu, 25 Oct 2018 07:41:22 -0700 (PDT)
Received: from pps.filterd (m0098779.ppops.net [127.0.0.1]) by mx0b-00010702.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9PEQnBg020303; Thu, 25 Oct 2018 09:41:07 -0500
Authentication-Results: ppops.net; dkim=pass header.d=nio365.onmicrosoft.com header.s=selector1-ni-com
Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp0017.outbound.protection.outlook.com [216.32.180.17]) by mx0b-00010702.pphosted.com with ESMTP id 2nav26bu87-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 25 Oct 2018 09:41:07 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nio365.onmicrosoft.com; s=selector1-ni-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CcMyn45yJ0iyDEUaTbB7UvBzrJ4VHGjbJ1hVsAlQ1fc=; b=avy7lOe1fgMYcMXZ+fLBVp9NTI/ukinKDaX8wsqYzX3GTuzBn+eLOHS9/9nTl45vRsDOEzRrMGaWxsSI8lQ6bZPN9zVrZd66rWRQaif2Si0gAIcEKuexOWweFVaROCU8Fp1zetldRI13Ry/kyxIoEOObSOvXYzTXBX2SHLCz5mo=
Received: from CY4PR04MB1127.namprd04.prod.outlook.com (10.173.192.137) by CY4PR04MB0329.namprd04.prod.outlook.com (10.168.168.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.18; Thu, 25 Oct 2018 14:41:05 +0000
Received: from CY4PR04MB1127.namprd04.prod.outlook.com ([fe80::25ed:9e78:9b6c:7306]) by CY4PR04MB1127.namprd04.prod.outlook.com ([fe80::25ed:9e78:9b6c:7306%2]) with mapi id 15.20.1273.022; Thu, 25 Oct 2018 14:41:05 +0000
From: Rodney Cummings <rodney.cummings@ni.com>
To: Jiangyuanlong <jiangyuanlong@huawei.com>, Radek Krejčí <rkrejci@cesnet.cz>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "draft-ietf-tictoc-1588v2-yang.all@ietf.org" <draft-ietf-tictoc-1588v2-yang.all@ietf.org>, "tictoc@ietf.org" <tictoc@ietf.org>
Thread-Topic: Yangdoctors early review of draft-ietf-tictoc-1588v2-yang-10
Thread-Index: AQHUbDuHtVJ99iE5akqqNjc1QZytMqUwCJnA
Date: Thu, 25 Oct 2018 14:41:04 +0000
Message-ID: <CY4PR04MB1127E5071942134CDC1AE9BE92F70@CY4PR04MB1127.namprd04.prod.outlook.com>
References: <154045022283.6867.1264697701888740594@ietfa.amsl.com> <3B0A1BED22CAD649A1B3E97BE5DDD68BBC23ED62@dggeml512-mbx.china.huawei.com>
In-Reply-To: <3B0A1BED22CAD649A1B3E97BE5DDD68BBC23ED62@dggeml512-mbx.china.huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [130.164.62.219]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; CY4PR04MB0329; 6:i2ElOgbIDvb2H9RHj8pDDs018yNjFEA9iA1hJo+vHZZTkEXNcrkLKWQvAG3i4xaCHx+KourRfb/hq0wdTH3a7FA3EBMVWjP5UI2/vfZpn6txE0tjWvg62KwAotwhsLalFcVyhRxPytoFn8b/Xvp7DBGUC9SWTjfEEXZBBCgaWf1nVC5BK3SdQdtpoTyC72ZEpRCwDJUQdOWhI+cgEXWLrKXIdPsU0J9uWRzDAb6rNOGyA+29s03VeitugGOW8q8cd76xNL7FR6ZWDA0FOef11staPGA6St2qac7lfI8jC/vHVG187hGAGttk1zArY0k8Jt06Roe6k4bG5/e7T3Y5gse/fq82wMotU3ZG2heTObESUhd+W8QRRgOPQydqbydQuwCXFxyL1IVy+tc8N8ZyHnn2kHr9YUws2Gt3uWSY0a07GMD/nzUDteCEP+5yh2np3DyuQTTSn8hHxyKDCyYmng==; 5:j8jCh4NsSsU5TpjY+w4KuxT+q6rXAAclqHK6Y54pg4IdbH8EL3HoXLeQW3m0qsR5TV0FVILi6v9RTH3P8zMimxRHBvrXLh9bn4ZS9kZhCO9JgPCXJa+2RnrVGrJSFMNq79bpfzhe2LOAiOwZIoqC/Xet4h6IKIFNv/uf2D5UWHg=; 7:PrGMtlLXb8msFDx2QcLuDupi5YMMV8HgtcUhNF6YRGKX86VU2SOxbq/Q5u3puDevrRmpoS/AkhTjbBItousFJhesTSiQ80MowxdraXyrvlxFsdzDNAUp7CT25ZXsPcbIbG9GchZJJOVOaPNwD+RsIQ==
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 6f4a73c6-a5a2-4f7a-a7f5-08d63a87e4b0
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:CY4PR04MB0329;
x-ms-traffictypediagnostic: CY4PR04MB0329:
x-microsoft-antispam-prvs: <CY4PR04MB03296726AE8EEDBA3F0CDEE792F70@CY4PR04MB0329.namprd04.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(50582790962513);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:CY4PR04MB0329; BCL:0; PCL:0; RULEID:; SRVR:CY4PR04MB0329;
x-forefront-prvs: 083691450C
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(366004)(346002)(39860400002)(136003)(396003)(13464003)(189003)(199004)(55016002)(229853002)(11346002)(2900100001)(486006)(2501003)(99286004)(71190400001)(66066001)(476003)(5250100002)(44832011)(186003)(6246003)(4326008)(26005)(478600001)(6506007)(14454004)(76176011)(5660300001)(53546011)(86362001)(6116002)(106356001)(105586002)(446003)(3846002)(7696005)(71200400001)(316002)(68736007)(54906003)(9686003)(53936002)(6436002)(97736004)(8936002)(81166006)(8676002)(25786009)(256004)(305945005)(33656002)(14444005)(81156014)(102836004)(74316002)(7736002)(2906002)(110136005); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR04MB0329; H:CY4PR04MB1127.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ni.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: giLs6Ypz4zmOc3bLoziCdKr0Yf8wzJxmyZTiUKy16sRu4Ptpi3tAAzgFTU8V2B1w54UVFYqHRCmObGtEZifjFqL2XAJSXKAExdBREGTkbGDqv5U8OzFNuCWhgTmHBFR24C9pUai7d6UL5nXFxLdJioZTX/rdg9aMXfU5QdCZZobCTNaFKB+DZak8b44Hk2UlSroL3HM3L/LsT/ED/bScZVHp6nHf5HkgGJ4Rc7d7rSj0N8bdlsxe/qJPSvPB7JT3SMTr1fz5LIo5+p7ZQyUhZefHtS1HVyHeprM9xC+inqoq2phm2uHO1A3gDvEGZ6StcjsNoFFpxMi/zHVtKo/oAbghqksCsRUInLIeJNa5M6s=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ni.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f4a73c6-a5a2-4f7a-a7f5-08d63a87e4b0
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2018 14:41:04.9981 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 87ba1f9a-44cd-43a6-b008-6fdb45a5204e
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR04MB0329
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-10-25_07:, , signatures=0
X-Proofpoint-Spam-Details: rule=inbound_policy_notspam policy=inbound_policy score=30 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=30 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810250124
Archived-At: <https://mailarchive.ietf.org/arch/msg/tictoc/R47eYVJZB2D0s8t01inRO5GheiA>
Subject: Re: [TICTOC] Yangdoctors early review of draft-ietf-tictoc-1588v2-yang-10
X-BeenThere: tictoc@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Timing over IP Connection and Transfer of Clock BOF <tictoc.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tictoc>, <mailto:tictoc-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tictoc/>
List-Post: <mailto:tictoc@ietf.org>
List-Help: <mailto:tictoc-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tictoc>, <mailto:tictoc-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Oct 2018 14:41:25 -0000

Yuanlong,

Radek is referring to:
	     prefix "ptp";

I agree with his comment. We can remove the paragraph that he quotes in 2).

Rodney

> -----Original Message-----
> From: Jiangyuanlong <jiangyuanlong@huawei.com>
> Sent: Thursday, October 25, 2018 3:20 AM
> To: Radek Krejčí <rkrejci@cesnet.cz>; yang-doctors@ietf.org
> Cc: draft-ietf-tictoc-1588v2-yang.all@ietf.org; tictoc@ietf.org
> Subject: RE: Yangdoctors early review of draft-ietf-tictoc-1588v2-yang-10
> 
> Hi Radek,
> 
> Thanks much for the review.
> Please see my comments in the line.
> 
> Best regards,
> Yuanlong
> 
> -----Original Message-----
> From: Radek Krejčí [mailto:rkrejci@cesnet.cz]
> Sent: Thursday, October 25, 2018 2:50 PM
> To: yang-doctors@ietf.org
> Cc: draft-ietf-tictoc-1588v2-yang.all@ietf.org; tictoc@ietf.org
> Subject: Yangdoctors early review of draft-ietf-tictoc-1588v2-yang-10
> 
> Reviewer: Radek Krejčí
> Review result: Ready with Nits
> 
> This is my YANG-doctor review of draft-ietf-tictoc-1588v2-yang-10. I have
> reviewed it mainly from the YANG perspective, since I'm not familiar with
> IEEE 1588.
> 
> The draft as well as the YANG module ietf-ptp@2018-09-10 are in a good
> shape and ready to publish. I have only 2, say, editorial notes.
> 
> 1) email of Rodney Cummings in the module's contact statement misses (in
> contrast to emails of other authors) starting ('<') and ending ('>') tags.
> [YJ] Good catch, I found this inconsistence too, and we will update it in
> the next revision.
> 
> 2) I don't see any reason for the following paragraph in the appendix A3:
> 
>    Under the assumptions of section A.1, the first IEEE 1588 YANG
>    module prefix can be the same as the last IETF 1588 YANG module
>    prefix (i.e. "ptp"), since the nodes within both YANG modules are
>    compatible.
> 
> Since the module's prefix is used only locally, it may change when the
> module is updated (RFC 7950, sec. 11). So the mentioned paragraph seems
> pointless to me (and therefore confusing for readers).
> [YJ] Good catch, there is a misspelling here, "prefix" should be "postfix"
> in A.3, it is not the "prefix" statement in the YANG. The logic is, both
> "ieee1588-ptp" and "ietf-ptp" have a "ptp" postfix.

v2.23.0 | Report a Bug | By Email