Re: [Time] Comments on draft-tissa-netmod-oam-01

[Qin Wu <[e-mail]>]

Sorry to chime in.
See some comments inline below.
-----邮件原件-----
>发件人: netmod [mailto:[e-mail]] 代表 Nobo Akiya (nobo)
>发送时间: 2014年7月5日 1:09
>收件人: Tissa Senevirathne (tsenevir)
>抄送: [e-mail]
>主题: [netmod] Comments on draft-tissa-netmod-oam-01

>Hi Tissa, authors,

>First of all, intent of this document seems widely beneficial. I am interested to see how and In what form this document will progress.

>Please find below few comments I have on the draft-tissa-netmod-oam-01, from a quick look at the document.


>Comment #1: Section 6

> [snip]
>     typedef CCM-Interval {
>       default "interval-1min";
>       type enumeration {
>         enum "interval-invalid" {
>           value 0;
>         }
         ...
>         enum "interval-10min" {
>           value 7;
>         }
>      }
       ...
>     }
> [snip]

>When considering all OAM tools out there, defining a hard coded set of intervals (via enum) may not be a good idea. BFD implementations (SW/HW) springs to my mind immediately. For HW 
>based BFD, BFD WG is working on an informational document for recommended set of intervals: draft-ietf-bfd-intervals. However, intervals outside of that set can still be implemented by 
>vendors for HW based BFD. SW based BFD, obviously, has much more flexibility in the range of intervals to use. A better approach may be to change above from enum to identify ref (or
>something else) which can be augmented.


>Comment #2: Section 6

> [snip]
>     typedef ecmp-choices {
>       type enumeration {
>         enum "ecmp-use-platform-hash" {
>           value 0;
>         }
>         enum "ecmp-use-round-robin" {
>           value 1;
>         }
>       }
>     }
> [snip]
>                 leaf ecmp-choice {
>                   config true;
>                   type ecmp-choices;
>                   description
>                     "0 means use the specified interface
>                      1 means use round robin";
>                 }
> [snip]

>Above two seems a bit conflicting for the value of zero(0). Former states that zero(0) indicates usage of platform hash but the latter indicates that specific interface is used (i.e. not hashed?). >Thinking about this, I believe "ecmp-choices" is overloaded. You actually want to be able to describe 3 different things here.

>1. Configuring a specific load balancing technique on a system (ex: EL, round-robin or something else).

[Qin]: are you proposing to replace ecmp-use-platform-hash with EL and have the following change to ecmp-choices typdef
NEW TEXT:
"
     typedef ecmp-choices {
       type enumeration {
         enum "Entropy Lable" {
           value 0;
         }
         enum "ecmp-use-round-robin" {
           value 1;
         }
       }
     }
"
However draft-tissa also has flow-entropy grouping to be defined
"
     grouping flow-entropy {
       description
         "defines the grouping statement for flow-entropy";
       choice flow-entropy {
         case flow-entropy-null;
       }
     }
"
Which make me difficult to understand how flow-entropy grouping is related to ecmp-choices

>2. Describing the output behavior on the OAM instance (ex: out to specific interface vs. load balanced).

[Qin]: I am wondering why not consider input behavior or input key to load balancing technique.

>3. Describe the setting on the path discovery OAM instance (ex: LSP tree trace using multipath 2, 4, 8, 9, 10).

[Qin]: Is this setting on path discovery OAM instance common setting? Or different OAM tool have different setting for path discovery mechanism.
Or you are just talking about different path have different setting?
I am trying to understand this.

>Perhaps a different object for each may be a good idea. (2) can be an enum 

>but it'll be beneficial to be able for various OAM tools to augment (1) and (3).

[Qin]: I tend to agree with this.