Re: [TLS] I-D Action: draft-ietf-tls-ticketrequests-02.txt

Hubert Kario <hkario@redhat.com> Mon, 30 September 2019 13:28 UTC

Return-Path: <hkario@redhat.com>
X-Original-To: tls@ietfa.amsl.com
Delivered-To: tls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D745120803 for <tls@ietfa.amsl.com>; Mon, 30 Sep 2019 06:28:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.901
X-Spam-Level:
X-Spam-Status: No, score=-6.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Y8erxVY8z5c for <tls@ietfa.amsl.com>; Mon, 30 Sep 2019 06:28:07 -0700 (PDT)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 87C44120802 for <tls@ietf.org>; Mon, 30 Sep 2019 06:28:07 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3108559465; Mon, 30 Sep 2019 13:28:07 +0000 (UTC)
Received: from pintsize.usersys.redhat.com (ovpn-200-35.brq.redhat.com [10.40.200.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id 820C226199; Mon, 30 Sep 2019 13:28:06 +0000 (UTC)
From: Hubert Kario <hkario@redhat.com>
To: tls@ietf.org
Date: Mon, 30 Sep 2019 15:28:05 +0200
Message-ID: <1765606.IRqicVgrGs@pintsize.usersys.redhat.com>
In-Reply-To: <8c2b10b3-bfc2-44b0-997a-1cab0789f1b7@www.fastmail.com>
References: <156962803631.24993.3421537129925787732@ietfa.amsl.com> <8c2b10b3-bfc2-44b0-997a-1cab0789f1b7@www.fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart1850592.pTbIhduR21"; micalg="pgp-sha512"; protocol="application/pgp-signature"
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 30 Sep 2019 13:28:07 +0000 (UTC)
Archived-At: <https://mailarchive.ietf.org/arch/msg/tls/9ZOQ_xS6zTYQFfcC3aUc0grMDOs>
Subject: Re: [TLS] I-D Action: draft-ietf-tls-ticketrequests-02.txt
X-BeenThere: tls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "This is the mailing list for the Transport Layer Security working group of the IETF." <tls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tls>, <mailto:tls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tls/>
List-Post: <mailto:tls@ietf.org>
List-Help: <mailto:tls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tls>, <mailto:tls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Sep 2019 13:28:09 -0000

On Saturday, 28 September 2019 01:59:42 CEST Christopher Wood wrote:
> This version addresses some of the comments we received from Hubert a while
> back. We think it's ready to go for WGLC, modulo whatever nits folks find.
> :-)

I still see the "vend" instead of "send" typos... Same for "vended"

```
      Clients must therefore
      bound the number of parallel connections they initiate by the
      number of tickets in their possession, or risk ticket re-use.
```

I'm not a native speaker, but shouldn't it be "...therefore bind the 
number..."?

```
Servers MUST NOT send more than 255 tickets to clients.
```

per what? session? at a time? connection?

what's the expected behaviour with tickets and post-handshake authentication?
Are tickets sent after PHA also bound by this limit?

```
   Clients MUST NOT change the value of TicketRequestContents.count in
   second ClientHello messages sent in response to a HelloRetryRequest.
```

'A server MUST abort the connection with an "illegal_parameter" if the value 
of the extension changed, it was added or removed in second ClientHello.' ?


-- 
Regards,
Hubert Kario
Senior Quality Engineer, QE BaseOS Security team
Web: www.cz.redhat.com
Red Hat Czech s.r.o., Purkyňova 115, 612 00  Brno, Czech Republic