Re: [TLS] [Gen-art] Genart last call review of draft-ietf-tls-tls13-cert-with-extern-psk-03

Russ Housley <housley@vigilsec.com> Thu, 19 December 2019 15:08 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: tls@ietfa.amsl.com
Delivered-To: tls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DCD5412007C for <tls@ietfa.amsl.com>; Thu, 19 Dec 2019 07:08:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lSUlBif6nujC for <tls@ietfa.amsl.com>; Thu, 19 Dec 2019 07:08:46 -0800 (PST)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2DA1812004C for <tls@ietf.org>; Thu, 19 Dec 2019 07:08:46 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 337C3300B15 for <tls@ietf.org>; Thu, 19 Dec 2019 10:08:44 -0500 (EST)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id j30V4r9Er3ON for <tls@ietf.org>; Thu, 19 Dec 2019 10:08:41 -0500 (EST)
Received: from a860b60074bd.fios-router.home (pool-108-51-198-163.washdc.fios.verizon.net [108.51.198.163]) by mail.smeinc.net (Postfix) with ESMTPSA id 9BA01300688; Thu, 19 Dec 2019 10:08:41 -0500 (EST)
From: Russ Housley <housley@vigilsec.com>
Message-Id: <86068E17-D072-4B53-BB68-3914A3F35D8E@vigilsec.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_CAADB6BD-E74F-42ED-B885-C7957657A159"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Date: Thu, 19 Dec 2019 10:08:41 -0500
In-Reply-To: <961ACE56-8BF5-4AC5-AC78-2F9235BDE916@cooperw.in>
Cc: IETF Gen-ART <gen-art@ietf.org>, IETF TLS <tls@ietf.org>
To: Ines Robles <mariainesrobles@googlemail.com>
References: <157533115179.2256.879699004944357388@ietfa.amsl.com> <961ACE56-8BF5-4AC5-AC78-2F9235BDE916@cooperw.in>
X-Mailer: Apple Mail (2.3445.104.11)
Archived-At: <https://mailarchive.ietf.org/arch/msg/tls/CxAzvdiLN2mWGw0DxuONKUKaMls>
Subject: Re: [TLS] [Gen-art] Genart last call review of draft-ietf-tls-tls13-cert-with-extern-psk-03
X-BeenThere: tls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "This is the mailing list for the Transport Layer Security working group of the IETF." <tls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tls>, <mailto:tls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tls/>
List-Post: <mailto:tls@ietf.org>
List-Help: <mailto:tls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tls>, <mailto:tls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Dec 2019 15:08:48 -0000

Ines:

Thanks for taking the time to review the document.

> Reviewer: Ines Robles
> Review result: Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.
> 
> Document: draft-ietf-tls-tls13-cert-with-extern-psk-??
> Reviewer: Ines Robles
> Review Date: 2019-12-02
> IETF LC End Date: 2019-12-02
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> The document is well written.
> 
> This document specifies a TLS 1.3 extension permitting certificate-based server
> authentication to be combined with an external PSK as an input to the TLS 1.3
> key schedule.
> 
> Major issues: Not found
> 
> Minor issues: Not found
> 
> Nits/editorial comments:
> 
> I think that would be nice to add in IANA Considerations a table specifying the
> fields of the TLS ExtensionType Values indicated in
> https://www.iana.org/assignments/tls-extensiontype-values/tls-extensiontype-values.xhtml <https://www.iana.org/assignments/tls-extensiontype-values/tls-extensiontype-values.xhtml>

I am willing to add the table, but I observe that IANA was able to correctly add the entry based on the words in the document.  You will see that they have assigned the number 33 to this extension.

Russ