[TLS] Minor comments on draft-ietf-tls-dtls-heartbeat

Eric Rescorla <ekr@rtfm.com> Thu, 01 September 2011 00:50 UTC

Return-Path: <ekr@rtfm.com>
X-Original-To: tls@ietfa.amsl.com
Delivered-To: tls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3B45521F8CEE for <tls@ietfa.amsl.com>; Wed, 31 Aug 2011 17:50:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.977
X-Spam-Level:
X-Spam-Status: No, score=-102.977 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, FM_FORGED_GMAIL=0.622, RCVD_IN_DNSWL_LOW=-1, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VudqIQKcpnmy for <tls@ietfa.amsl.com>; Wed, 31 Aug 2011 17:49:59 -0700 (PDT)
Received: from mail-ww0-f44.google.com (mail-ww0-f44.google.com [74.125.82.44]) by ietfa.amsl.com (Postfix) with ESMTP id 8544321F8CE8 for <tls@ietf.org>; Wed, 31 Aug 2011 17:49:59 -0700 (PDT)
Received: by wwf5 with SMTP id 5so912896wwf.13 for <tls@ietf.org>; Wed, 31 Aug 2011 17:51:30 -0700 (PDT)
Received: by 10.227.165.202 with SMTP id j10mr994794wby.18.1314838290328; Wed, 31 Aug 2011 17:51:30 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.227.3.5 with HTTP; Wed, 31 Aug 2011 17:51:10 -0700 (PDT)
From: Eric Rescorla <ekr@rtfm.com>
Date: Wed, 31 Aug 2011 17:51:10 -0700
Message-ID: <CABcZeBOaYCecK3jqfteLp19DBQ2YS_xcQ_mbqstq-nW7Q7AoDQ@mail.gmail.com>
To: draft-ietf-dtls-heartbeat@tools.ietf.org
Content-Type: text/plain; charset=ISO-8859-1
Cc: tls@ietf.org
Subject: [TLS] Minor comments on draft-ietf-tls-dtls-heartbeat
X-BeenThere: tls@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "This is the mailing list for the Transport Layer Security working group of the IETF." <tls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tls>, <mailto:tls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/tls>
List-Post: <mailto:tls@ietf.org>
List-Help: <mailto:tls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tls>, <mailto:tls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Sep 2011 00:50:00 -0000

S 1.1.
"and their adoptions" -> "and their adaptations"

"as described" -> described


S 3.
"Like the ChangeCipherSpec message,.... can arrive at any time"

I guess a CSS can in principle arrive at any time, but it's not permitted at
any time. You couldn't send it as the first message of a connection,
for instance. I'm not sure there is a specific statement to this effect
in 5246, but it seems implicit in S 7.3.

"MUST stop the retransmission timer" -> "MUST stop the DTLS retransmission
timer" perhaps?

"HeartbeatRequest messages from older epochs must be discarded"
I would clarify that this is DTLS only since TLS has no epochs.


S 4.
You should probably clarify why the padding length is what it is.


S 5.1
We'll need to update the 4347 citation to DTLS 1.2

5.2.
"allows this check" -> "allows a check" perhaps?

"multiple round trip times"
You should probably recommend some multiple.

S 6.
Specification required is a pretty low bar for a field this small... Perhaos
Expert Review would be better.


-Ekr